Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 09:45, "Patrick Valsecchi" escreveu: > > Early optimization is root to all evil. > > Anyway this question is eluded by my one liner replacement. Yes, it is. I do prefer your version. Can you send a patch ( with a sob line)? > > Tomaz Canabrava a écrit : >> >> Em 26/12/2013 08:23,

Re: christmas patches.

2013-12-26 Thread Tomaz Canabrava
Em 26/12/2013 08:23, "Tomaz Canabrava" escreveu: > Hy > Em 26/12/2013 07:03, "Patrick Valsecchi" escreveu: > > > > Hi, > > > > About the patch 0001: > > http://qt-project.org/doc/qt-4.8/qstringlist.html#contains > > > > So that would be shorter: > > > > const bool foundGoogleMap = > list.contain

Re: christmas patches.

2013-12-26 Thread Patrick Valsecchi
Hi, About the patch 0001: http://qt-project.org/doc/qt-4.8/qstringlist.html#contains So that would be shorter: const bool foundGoogleMap = list.contains("earth/googlesat/googlesat.dgml"); And, for your information, QString is copy on write. So a copy by value is nearly costless. CU On 24.

christmas patches.

2013-12-24 Thread Tomaz Canabrava
Mostly code-style issues, optimizations. only real bug was for dark backgrounds. From 068a26efa81b178fa920f2c5628b4bbef59059e5 Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Tue, 24 Dec 2013 09:38:35 -0200 Subject: [PATCH 1/8] Rework foreach for a faster iteration. The old code used a QStri