Re: French Translation updated on transifex

2014-12-11 Thread Guillaume Gardet
Le 10/12/2014 18:48, Dirk Hohndel a écrit : On Wed, Dec 10, 2014 at 06:37:26PM +0100, Guillaume Gardet wrote: Hi, I updated french translation on transifex. Thanks. I periodically pull all the new translations, it seems quite a few people are actively translating right now :-) We are making

Re: [PATCH] Allow more flexible GPS coordinates for CSV import

2014-12-11 Thread Willem Ferguson
On 11/12/2014 07:22, Miika Turkia wrote: On Thu, Dec 11, 2014 at 12:56 AM, Pedro Neves nevesdi...@gmail.com mailto:nevesdi...@gmail.com wrote: Miika: I'm sorry to disturb you with this. Do you mind trying importing the attached .CSV file into Subsurface? On my machine,

Re: [PATCH] Allow more flexible GPS coordinates for CSV import

2014-12-11 Thread Dirk Hohndel
On Thu, Dec 11, 2014 at 11:36:31AM +0200, Willem Ferguson wrote: Currently only the d.dd d.d format is supported so that is what should be currently documented. However, we already have a function on the GUI code that decodes the other coordinate formats. We just do not use that

Re: [PATCH] Allow more flexible GPS coordinates for CSV import

2014-12-11 Thread Willem Ferguson
On 11/12/2014 13:30, Dirk Hohndel wrote: On Thu, Dec 11, 2014 at 11:36:31AM +0200, Willem Ferguson wrote: Currently only the d.dd d.d format is supported so that is what should be currently documented. However, we already have a function on the GUI code that decodes the other

Windows dailies.

2014-12-11 Thread Long, Martin
Hi, Maybe I'm being dumb. Where can I find the Windows daily binaries? thanks Martin ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: Windows dailies.

2014-12-11 Thread Davide DB
http://subsurface-divelog.org/downloads/daily/ On Thu, Dec 11, 2014 at 2:07 PM, Long, Martin mar...@longhome.co.uk wrote: Hi, Maybe I'm being dumb. Where can I find the Windows daily binaries? thanks Martin ___ subsurface mailing list

UDDF Export

2014-12-11 Thread Long, Martin
So. I ran the UDDF output through the XSL schema from the uddf site. It looks like there are still lots of areas where we are not compliant. - Lots of areas where there are mandatory tags we need to provide (looks like most of this is static). - Lots of ID which aren't compliant. I think this

Re: UDDF Export

2014-12-11 Thread Dirk Hohndel
On December 11, 2014 8:07:49 AM Long, Martin mar...@longhome.co.uk wrote: So. I ran the UDDF output through the XSL schema from the uddf site. It looks like there are still lots of areas where we are not compliant. In general I have a dim view of the UDDF format (it's over designed and

Problem with Atomic Cobalt 2

2014-12-11 Thread Familie Rave
Hello, I have a problem with the import from my divecomputer Atomic Cobalt 2. I like import all my dives from the dive computer, but the programm (dive computer) import only the last dive - I start the programm SUBSURFACE 4.2.205.0 - I click the button IMPORT - I click IMPORT FROM DIVE

Re: Problem with Atomic Cobalt 2

2014-12-11 Thread Miika Turkia
On Thu, Dec 11, 2014 at 7:04 PM, Familie Rave ewa-r...@web.de wrote: Hello, I have a problem with the import from my divecomputer Atomic Cobalt 2. I like import all my dives from the dive computer, but the programm (dive computer) import only the last dive - I start the programm SUBSURFACE

Re: Problem with Atomic Cobalt 2

2014-12-11 Thread Familie Rave
Hello, heres the logfile: *Event: vendor=3239313430353431E20002000200** **Event: model=2 (0x0002), firmware=14811138 (0x00e20002), serial=29140541 (0x01bca63d)* When i select Save libdivecomputer dumpfile there come a window Dive data import error Wolfgang Am 11.12.2014 21:29,

[PATCH] Don't try to malloc a zero sized list

2014-12-11 Thread Anton Lundin
If we tried to copy a divecomputer without samples, we where to malloc a zero sized blob. dives/test15.xml triggered this and it was found with valgrind. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dive.c b/dive.c

Re: [PATCH] Don't try to malloc a zero sized list

2014-12-11 Thread Linus Torvalds
On Thu, Dec 11, 2014 at 3:31 PM, Anton Lundin gla...@acc.umu.se wrote: If we tried to copy a divecomputer without samples, we where to malloc a zero sized blob. dives/test15.xml triggered this and it was found with valgrind. This is *not* correct. First off, allocating a zero-sized area is

Re: [PATCH] Don't try to malloc a zero sized list

2014-12-11 Thread Anton Lundin
On 11 December, 2014 - Linus Torvalds wrote: On Thu, Dec 11, 2014 at 3:31 PM, Anton Lundin gla...@acc.umu.se wrote: If we tried to copy a divecomputer without samples, we where to malloc a zero sized blob. dives/test15.xml triggered this and it was found with valgrind. This is *not*

Re: [PATCH] Don't try to malloc a zero sized list

2014-12-11 Thread Linus Torvalds
On Dec 11, 2014 11:07 PM, Anton Lundin gla...@acc.umu.se wrote: So, should the right approach here be not to trust malloc returning NULL here and we explicitly set sample to null if s-samples == 0 ? That sounds fine, yes. Or just initialize the fields to zero/NULL and then do that if (!nr)

[PATCH 2/2] Don't rely on malloc to return NULL for zero size

2014-12-11 Thread Anton Lundin
We rely on samples being NULL if a dc have no samples. Its completely legal for malloc to return a valid pointer to nowhere for zero sized malloc, which you can't follow and read what its pointing at. Its only viable to call free() on. In other code, if samples is a valid pointer, we dereference

[PATCH 1/2] Initialize alloc_samples in copy_samples

2014-12-11 Thread Anton Lundin
We rely on alloc_samples in prepare_sample. If alloc_samples weren't initialized prepare_sample would wreak havoc on the samples list. Signed-off-by: Anton Lundin gla...@acc.umu.se --- dive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dive.c b/dive.c index bb92818..8e8330f 100644 ---