Re: Translation window and some ideas

2015-01-24 Thread Robert C. Helling
Hi, > Am 25.01.2015 um 01:37 schrieb Lubomir I. Ivanov : > > on the other hand the developers should be more strict not to send > typos in the first place, so that the typos don't make it in > transifex. Absolutely. Ideally, at the same time, the developers should be more strict not to send b

Re: Translation window and some ideas

2015-01-24 Thread Lubomir I. Ivanov
On 25 January 2015 at 02:37, Lubomir I. Ivanov wrote: > perhaps i check occasionally for things like pO2 using the subscript > 2, and request a re-send from the developer. > also, will see if i can sort a patch tomorrow with some text fixes. :-) > and that's a typo right there...should be: "pO2 n

Re: Translation window and some ideas

2015-01-24 Thread Lubomir I. Ivanov
On 25 January 2015 at 00:48, Dirk Hohndel wrote: > Case in point - I asked people to test the 4.3.950 binaries for the > different Linux flavors. > > Look at the long list of reports I have gotten since. > > :-( i think that google+ and linus can help with that? e.g. if there is a concept to be p

Re: Translation window and some ideas

2015-01-24 Thread Dirk Hohndel
On Sat, Jan 24, 2015 at 05:50:29PM +0200, Lubomir I. Ivanov wrote: > hello, > > can't do much ATM other than translating, but i would like to propose > a couple of ideas. > > 1) use a translation window > > the idea of a translation windows is that between the release of the > first beta (or the

Re: subsurface installation blues on Fedora20

2015-01-24 Thread Dirk Hohndel
On Sat, Jan 24, 2015 at 09:31:31AM -0800, Thiago Macieira wrote: > On Saturday 24 January 2015 15:37:49 Willem Ferguson wrote: > > It appears that unicodeUFT8 is deprecated in Qt5, so code that use it > > should not compile under Qt5, at least that is what the Qt discussion > > forum thinks. > > D

Re: subsurface installation blues on Fedora20

2015-01-24 Thread Thiago Macieira
On Saturday 24 January 2015 15:37:49 Willem Ferguson wrote: > It appears that unicodeUFT8 is deprecated in Qt5, so code that use it > should not compile under Qt5, at least that is what the Qt discussion > forum thinks. Deprecated because source code strings are assumed to be UTF-8 and that's our

Translation window and some ideas

2015-01-24 Thread Lubomir I. Ivanov
hello, can't do much ATM other than translating, but i would like to propose a couple of ideas. 1) use a translation window the idea of a translation windows is that between the release of the first beta (or the Nth beta) and the final release, no patches with strings changes should be accepted.

[PATCH 01/11] CSV import, fix known import handling with tab separator

2015-01-24 Thread Miika Turkia
When we have the separator as tab, we need to use the proper tab character instead of the string for known imports. Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimp

[PATCH 03/11] Enable importing of dive profile from CSV files

2015-01-24 Thread Miika Turkia
This assumes that we have either dive details or dive profile, not combined log files. Before the change in the import UI, user selected the import type by the tab on import dialog, now we make an educated guess based on whether sample time field is available. Signed-off-by: Miika Turkia --- qt-

[PATCH 09/11] Improve detection of continuation lines in CSV import

2015-01-24 Thread Miika Turkia
Signed-off-by: Miika Turkia --- xslt/manualcsv2xml.xslt | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/xslt/manualcsv2xml.xslt b/xslt/manualcsv2xml.xslt index ef63975..50fc241 100644 --- a/xslt/manualcsv2xml.xslt +++ b/xslt/manualcsv2xml.xslt @@ -396,7 +396,15 @@

[PATCH 11/11] Fix detection of numeric field

2015-01-24 Thread Miika Turkia
Discarding header lines was faulty as the test whether dive number was numeric did not work properly. Signed-off-by: Miika Turkia --- xslt/manualcsv2xml.xslt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xslt/manualcsv2xml.xslt b/xslt/manualcsv2xml.xslt index 50fc241..e7f29

[PATCH 10/11] Match ₂ to 2 and cylinder to cyl. on CSV import

2015-01-24 Thread Miika Turkia
This improves the column name matching so our own columns are properly supported. See #814 Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index ecd09bc..ada1fc4 100

[PATCH 04/11] Fix a bug if CSV file does not have ending new line

2015-01-24 Thread Miika Turkia
Add a new line when importing a CSV file, so we get the last dive imported as well (in case file ends without last new line). See #814 Signed-off-by: Miika Turkia --- file.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/file.c b/file.c index cbe38eb..eacd875 100

[PATCH 08/11] Switch Subsurface CSV import to use tab separator

2015-01-24 Thread Miika Turkia
As changing the export to use tabs, we need to switch the import to do that as well. However, we also need to support comma separation as older exports use that. Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-

[PATCH 05/11] Limit the row count properly when displaying CSV file

2015-01-24 Thread Miika Turkia
The import dialog now displays only a maximum of 10 lines of the CSV file to be imported. Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index 8c3099f.

[PATCH 02/11] Fix the support of APD Log Viewer CSV import

2015-01-24 Thread Miika Turkia
Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp index fe8e0a5..838ea89 100644 --- a/qt-ui/divelogimportdialog.cpp +++ b/qt-ui/divelogimportdialog.cpp @@ -385,6

[PATCH 07/11] Block the signals properly

2015-01-24 Thread Miika Turkia
It seems that at least in this occasion, the signal blocking requires the UI element to be given. Signed-off-by: Miika Turkia --- qt-ui/divelogimportdialog.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qt-ui/divelogimportdialog.cpp b/qt-ui/divelogimportdialog.cpp in

[PATCH 06/11] Switching to tab delimited CSV export

2015-01-24 Thread Miika Turkia
Use tab as separator when exporting dive details to CSV file. This also replaces tabs and line feeds from notes with spaces. Signed-off-by: Miika Turkia --- xslt/xml2manualcsv.xslt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xslt/xml2manualcsv.xslt b/xslt/xml2manual

Re: subsurface installation blues on Fedora20

2015-01-24 Thread Willem Ferguson
On 23/01/2015 12:28, Willem Ferguson wrote: On 21/01/2015 21:00, Dirk Hohndel wrote: The quickest way should be to install the things that we have in the INSTALL documenent for Fedora and build from source. But I really need to investigate what's up with libgit2 and why it isn't pulled in with

Re: [RFC PATCH] setCurrentText in qt4 not supported

2015-01-24 Thread Dirk Hohndel
On Sat, Jan 24, 2015 at 06:22:05AM +0200, Miika Turkia wrote: > > Never mind, Dirk has this already figured out as we do seem to have a > proper beta build waiting to be published for 12.04 on Launchpad. Yep. Just waiting for testers... > > (I am actually not able to test this properly, as gener