Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Rick Walsh
Hi Robert, On 5 July 2015 at 16:18, Robert C. Helling hell...@atdotde.de wrote: Hi Rick, On 05 Jul 2015, at 01:41, Rick Walsh rickmwa...@gmail.com wrote: 0016-MOD-of-oxygen-at-pO2-of-1.6-is-20ft.patch I am not really familiar with diving in imperial system but this patch seems quite

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Dirk Hohndel
On Jul 5, 2015, at 4:29 AM, Rick Walsh rickmwa...@gmail.com wrote: I am not really familiar with diving in imperial system but this patch seems quite specific. Could somebody please check that this problem really only affects the MOD of EAN100 and not other standard gases? I checked EAN50

Re: [PULL REQUEST] VPM-B Attempt 2.

2015-07-05 Thread Dirk Hohndel
On Sat, Jul 04, 2015 at 12:27:23AM +0200, Jan Darowski wrote: Hi, Here is another pull request. I hope now it's better. Everything was reorganized from scratch, the final code is almost the same. I like the patches much better. I agree with Robert that you could have squashed a couple

Re: [Patches] Planner preferences and deco stops at 10ft increments

2015-07-05 Thread Dirk Hohndel
Hi Rick, On Sun, Jul 05, 2015 at 08:39:15AM +1000, Rick Walsh wrote: On 4 July 2015 at 23:42, Dirk Hohndel d...@hohndel.org wrote: We have macros to make this easier: M_OR_FT(3, 10) gives you the correct value for 3m if the user has things set up for meters and 10ft if the user is in

Re: GSoC Status - Week 6 (Customizable prints)

2015-07-05 Thread Lubomir I. Ivanov
On 5 July 2015 at 19:36, Gehad Elrobey gehadelro...@gmail.com wrote: Hello, This week I was working on the following tasks: - fixing issues from last week progress. - adding TemplateEdit window. - add custom.html template that is editable from subsurface. - some minor fixes to existing

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Robert C. Helling
Hi, On 05 Jul 2015, at 15:09, Dirk Hohndel d...@hohndel.org wrote: But what I've seen in diver training and in blender training (I'm a certified trimix diver and trimix blender) is that you round to the nearest foot. Not truncate. I guess that is the best solution: Round to the nearest

[PULL REQUEST] GSoC Printing: part 3

2015-07-05 Thread Lubomir I. Ivanov
These are the third series from Gehad. Not much is happening visually except fixes for the print selected issue and the addition of the template editor dialog. The template edit itself is WIP. There is also the addition of the Preview window which we had in the previous Qt implementation. This

Re: dive plan test

2015-07-05 Thread Robert C. Helling
Dirk, On 05 Jul 2015, at 18:45, Dirk Hohndel d...@hohndel.org wrote: So I just pushed a commit that adds a TestPlan test. right now, I cannot pull it. Are you sure you pushed it? I will sit down with the debugger tomorrow and try to find the origin of the differences. Consider this as

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Henrik Brautaset Aronsen
On 5 Jul 2015 21:11, Linus Torvalds torva...@linux-foundation.org wrote: At the very least, split it up, and do the rounding separately. And no, you shouldn't add roundto-1 unless you always want to round _up_. I'd assume you'd want to round-to-nearest, and add roundto/2 instead. I would

[GSoC] Week 6 (Native Bluetooth support)

2015-07-05 Thread Claudiu Olteanu
Hi there, I spent this week doing some tests to find out the possible reasons of some issues: - first the QtSocketBluetooth::connectToService(address, uuid, mode) doesn't work as expected. On some devices, the SPP profile is never found. - second on some environments the connection takes too

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 07:03:09AM +1000, Rick Walsh wrote: Hi, On 6 Jul 2015 4:26 am, Robert C. Helling hell...@atdotde.de wrote: Hi, On 05 Jul 2015, at 15:09, Dirk Hohndel d...@hohndel.org wrote: But what I've seen in diver training and in blender training (I'm a certified

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Linus Torvalds
On Sun, Jul 5, 2015 at 2:42 PM, Dirk Hohndel d...@hohndel.org wrote: So rounding to 5m seems wrong - the typical stop depth are multiples of 3m/10ft. Are they, though? At shallow depths, sure. But do metric divers really prefer 21m/24m to 20m/25m? That sounds odd. But I've never done any

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Pedro Neves
On 05-07-2015 22:48, Linus Torvalds wrote: Are they, though? At shallow depths, sure. But do metric divers really prefer 21m/24m to 20m/25m? That sounds odd. I sure do... .. but maybe that's just me... Pedro ___ subsurface mailing list

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-05 Thread Claudiu Olteanu
I forgot to specify that the Fedora 22 and ArchLinux environments are two virtual machines. I don't know if this could cause the problem. If it does, I expect that it shouldn't work with the HW OSTCs device as well. Claudiu ___ subsurface mailing list

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Rick Walsh
Hi, On 6 Jul 2015 7:42 am, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jul 06, 2015 at 07:03:09AM +1000, Rick Walsh wrote: Hi, On 6 Jul 2015 4:26 am, Robert C. Helling hell...@atdotde.de wrote: Hi, On 05 Jul 2015, at 15:09, Dirk Hohndel d...@hohndel.org wrote: But what

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Linus Torvalds
On Sun, Jul 5, 2015 at 11:56 AM, Dirk Hohndel d...@hohndel.org wrote: static inline depth_t gas_mod(struct gasmix *mix, pressure_t po2_limit, int roundto) { depth_t depth; depth.mm = ((po2_limit.mbar * 1000 / get_o2(mix) * 10 - 1) / roundto) * roundto; return

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Dirk Hohndel
On Sun, Jul 05, 2015 at 12:11:15PM -0700, Linus Torvalds wrote: On Sun, Jul 5, 2015 at 11:56 AM, Dirk Hohndel d...@hohndel.org wrote: static inline depth_t gas_mod(struct gasmix *mix, pressure_t po2_limit, int roundto) { depth_t depth; depth.mm = ((po2_limit.mbar * 1000 /

Week 6 GSoC Progress Update (Android Port)

2015-07-05 Thread Grace Karanja
Hello everyone,This week, I managed the following:-- Adding a preferences dialog for the user to store cloud credentials.- Loading dives/Saving them to the cloud.- Displaying the dive profile in QML.This coming week, I will :-- Finish working on the dive profileand- Spend time on improving Android

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Rick Walsh
On 6 Jul 2015 7:55 am, Pedro Neves nevesdi...@gmail.com wrote: On 05-07-2015 22:48, Linus Torvalds wrote: Are they, though? At shallow depths, sure. But do metric divers really prefer 21m/24m to 20m/25m? That sounds odd. I sure do... .. but maybe that's just me... We do in Australia

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Dirk Hohndel
On Sun, Jul 05, 2015 at 03:19:52PM -0700, Linus Torvalds wrote: On Sun, Jul 5, 2015 at 2:55 PM, Pedro Neves nevesdi...@gmail.com wrote: But do metric divers really prefer 21m/24m to 20m/25m? I sure do... .. but maybe that's just me... The metric PADI tables do something odd, and go in

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread David Tillotson
On 5 July 2015 23:19:52 BST, Linus Torvalds torva...@linux-foundation.org wrote: On Sun, Jul 5, 2015 at 2:55 PM, Pedro Neves nevesdi...@gmail.com wrote: But do metric divers really prefer 21m/24m to 20m/25m? I sure do... .. but maybe that's just me... The metric PADI tables do something

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-05 Thread Dirk Hohndel
Hi Grace On Sun, Jul 05, 2015 at 11:00:31PM +0300, Grace Karanja wrote: This week, I managed the following:- - Adding a preferences dialog for the user to store cloud credentials. - Loading dives/Saving them to the cloud. - Displaying the dive profile in QML. Things looks nice, great

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Linus Torvalds
On Sun, Jul 5, 2015 at 2:55 PM, Pedro Neves nevesdi...@gmail.com wrote: But do metric divers really prefer 21m/24m to 20m/25m? I sure do... .. but maybe that's just me... The metric PADI tables do something odd, and go in two-meter increments from 10m to 22m, and then they switch to 5m

Re: [GSoC] Week 6 (Native Bluetooth support)

2015-07-05 Thread Dirk Hohndel
On Sun, Jul 05, 2015 at 10:50:59PM +0300, Claudiu Olteanu wrote: Hi there, I spent this week doing some tests to find out the possible reasons of some issues: - first the QtSocketBluetooth::connectToService(address, uuid, mode) doesn't work as expected. On some devices, the SPP profile is

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-05 Thread Dirk Hohndel
I did pick one commit from your current devel branch (the build fix for subsurface-mobile - while the subsurface-mobile in master isn't really useful it made sense to have this fix in master). And as it happens, that's our commit #1000 since 4.4.2 (actually, the way git describe counts this is a

Re: [PATCH] MOD of oxygen at pO2 of 1.6 is 20ft

2015-07-05 Thread Dirk Hohndel
On Sun, Jul 05, 2015 at 11:25:41PM +0100, David Tillotson wrote: The BSAC 88 tables work in 3m increments, as do the tables that ScotSAC use IIRC. I guess most are a result of the original USN work. Good data points. Is anyone aware of an organisation that teaches deco stops that aren't on