Re: world peace and the perfect location editing widget

2015-07-19 Thread Miika Turkia
From the e-mails received, this sounds like a really cool implementation. However, I seem to be suffering more corner cases / bugs than I expected to see (but then again, I seem to be suffering these with all the new features of Subsurface :D). I wonder if its my data, OS or something else. Here

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Rick Walsh
Hi Claudiu, I tested your patches, but haven't looked at the code or commits. On 19 July 2015 at 06:55, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: Hi there, I attached some patches which should improve the user experience when the Bluetooth download mode is enabled. The

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-19 Thread Gehad Elrobey
On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:17, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:10, Gehad Elrobey gehadelro...@gmail.com wrote: Yes it does, you can test it on current master. this is

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Rick Walsh
Hi Claudiu, On 19 July 2015 at 20:50, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: Hi Rick, I can select my usb bluetooth dongle (using the one that came with my petrel), and power it up or down, but I was not able to pair or unpair (when previously paired using the onboard

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Claudiu Olteanu
Thanks for the info, Rick! Did you tried to download the dives after you paired the devices manually (using bluetoothctl)? Currently the QtBluetooth library doesn't have an agent which can be used to set a custom PIN code on pairing step [1]. I don't know when they will implement it. The pairing

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Claudiu Olteanu
Hi Rick, I can select my usb bluetooth dongle (using the one that came with my petrel), and power it up or down, but I was not able to pair or unpair (when previously paired using the onboard bluetooth). Downloading fails with the usb dongle, even when it had already been paired. It didn't

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Rick Walsh
On 19 July 2015 at 22:06, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: Thanks for the info, Rick! Did you tried to download the dives after you paired the devices manually (using bluetoothctl)? I didn't think to try that before. But I just tried and it worked. Currently

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Claudiu Olteanu
I didn't think to try that before. But I just tried and it worked. Great to hear that :). That's annoying. Thankfully, most systems have a reasonably friendly way to pair bluetooth devices, and it only needs to be done once. Can you detect if pairing fails, and ask the user to pair the

Re: world peace and the perfect location editing widget

2015-07-19 Thread Dirk Hohndel
On Sun, Jul 19, 2015 at 10:42:42AM +0300, Miika Turkia wrote: From the e-mails received, this sounds like a really cool implementation. However, I seem to be suffering more corner cases / bugs than I expected to see (but then again, I seem to be suffering these with all the new features of

Ctrl-+ and Qt5.5

2015-07-19 Thread Dirk Hohndel
ArchLinux updated to Qt5.5 and it seems that with that the Add Dive shortcut Ctrl-+ went away. Am I making this up or could something in Qt5.5 have broken that? Is Ctrl-+ working for others? Which version of Qt are you using? /D ___ subsurface mailing

Re: world peace and the perfect location editing widget

2015-07-19 Thread Dirk Hohndel
On Sun, Jul 19, 2015 at 05:45:52AM -0700, Dirk Hohndel wrote: 1) When I change the location using the arrow keys, the globe does not show the new location. Otherwise, this way seems to work. *** the behavior of the globe is the same on the later test cases as well, but I do not mention

Re: world peace and the perfect location editing widget

2015-07-19 Thread Miika Turkia
On Sun, Jul 19, 2015 at 4:55 PM, Dirk Hohndel d...@hohndel.org wrote: On Sun, Jul 19, 2015 at 05:45:52AM -0700, Dirk Hohndel wrote: 1) When I change the location using the arrow keys, the globe does not show the new location. Otherwise, this way seems to work. *** the behavior of the

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Miika Turkia
On Sun, Jul 19, 2015 at 4:47 PM, Dirk Hohndel d...@hohndel.org wrote: ArchLinux updated to Qt5.5 and it seems that with that the Add Dive shortcut Ctrl-+ went away. Am I making this up or could something in Qt5.5 have broken that? Is Ctrl-+ working for others? Which version of Qt are you

Re: world peace and the perfect location editing widget

2015-07-19 Thread Dirk Hohndel
On Jul 19, 2015, at 7:00 AM, Miika Turkia miika.tur...@gmail.com wrote: On Sun, Jul 19, 2015 at 4:55 PM, Dirk Hohndel d...@hohndel.org wrote: On Sun, Jul 19, 2015 at 05:45:52AM -0700, Dirk Hohndel wrote: 1) When I change the location using the arrow keys, the globe does not show the new

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Claudiu Olteanu
Hi there, I have a Fedora 22 with Qt 5.5.0 and the shortcut is working. Subsurface version: 4.4.2-1040-g5cbbff008411c322. Claudiu ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Thiago Macieira
On Sunday 19 July 2015 06:28:37 Gaetan Bisson wrote: [2015-07-19 17:06:48 +0300] Claudiu Olteanu: I have a Fedora 22 with Qt 5.5.0 and the shortcut is working. Subsurface version: 4.4.2-1040-g5cbbff008411c322. It might be related to this patch, then:

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Thiago Macieira
On Sunday 19 July 2015 23:25:17 Claudiu Olteanu wrote: I saw that Q_OS_MAC doesn't include the open source version and I didn't know which is that :). Huh? I didn't look over the implementation. I just read the description from here[1] and it is mentioned something about an open source

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Thiago Macieira
On Sunday 19 July 2015 19:38:25 Thiago Macieira wrote: On Sunday 19 July 2015 06:28:37 Gaetan Bisson wrote: [2015-07-19 17:06:48 +0300] Claudiu Olteanu: I have a Fedora 22 with Qt 5.5.0 and the shortcut is working. Subsurface version: 4.4.2-1040-g5cbbff008411c322. It might be related

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Gaetan Bisson
[2015-07-19 17:06:48 +0300] Claudiu Olteanu: I have a Fedora 22 with Qt 5.5.0 and the shortcut is working. Subsurface version: 4.4.2-1040-g5cbbff008411c322. It might be related to this patch, then:

Re: GSoC Status - Week 7 (Customizable prints)

2015-07-19 Thread Lubomir I. Ivanov
On 19 July 2015 at 13:23, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:17, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:10, Gehad Elrobey gehadelro...@gmail.com wrote:

Re: Ctrl-+ and Qt5.5

2015-07-19 Thread Thiago Macieira
On Sunday 19 July 2015 06:47:32 Dirk Hohndel wrote: ArchLinux updated to Qt5.5 and it seems that with that the Add Dive shortcut Ctrl-+ went away. Am I making this up or could something in Qt5.5 have broken that? Is Ctrl-+ working for others? Which version of Qt are you using? That's an

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Claudiu Olteanu
Child QObjects don't need to be cleaned. But I'm not seeing any parent-child relationship here. I'm deferring to you here. I'm just pointing out, I haven't done any investigation. Would you like me to? I don't have too much experience with C++ and Qt framework. If you have time, it

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Thiago Macieira
On Saturday 18 July 2015 23:55:35 Claudiu Olteanu wrote: Subject: [PATCH 3/8] Don't block the save button for Bluetooth device selection After commit #69a75fed05fc3 we don't need to block the save Dirk, please remember to update the commit SHA-1 after you cherry-pick patch 1 :-)

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Claudiu Olteanu
Claudiu, most people only have one local bluetooth device. We shouldn't display a list to select an entry if there's only one entry to be selected. Can you hide the list if the list contains only one? Of course I can do. One of the attached patches (#0009) should do the trick. Where is

Re: [PATCH] Bluetooth improvements

2015-07-19 Thread Thiago Macieira
On Sunday 19 July 2015 22:23:46 Claudiu Olteanu wrote: Claudiu, most people only have one local bluetooth device. We shouldn't display a list to select an entry if there's only one entry to be selected. Can you hide the list if the list contains only one? Of course I can do. One of the