Re: Android App

Made a fast walk through, did not find anything significant... 2017-03-12 14:19 GMT+07:00 Anton Lundin : > On 11 March, 2017 - Dirk Hohndel wrote: > > > I would like to update the app. It would be nice if a few people could > try the new Subsurface-mobile that's available in

Re: Android App

On 11 March, 2017 - Dirk Hohndel wrote: > I would like to update the app. It would be nice if a few people could try > the new Subsurface-mobile that's available in the beta test channel... Just > as a check to make sure I didn't break anything obvious > LGTM //Anton -- Anton Lundin

Re: direct import form dive computer

On 12/03/2017 00:41, Alessandro Volpi wrote: Dear Jef, It is worth while to mention that the IR interface is a package not being maintained for many years. The interface works with Ubuntu Trusty, at least with the Galileo Sol device. It DOES NOT WORK AT ALL with newer systems, such as

Re: Android App

I believe it is this one from another thread 3 hours ago: https://play.google.com/apps/testing/org.subsurfacedivelog.mobile miika On Sun, Mar 12, 2017 at 7:28 AM, Willem Ferguson wrote: > From phone. Where does one find the beta test channel? Kind regards,

Re: Android App

>From phone. Where does one find the beta test channel? Kind regards, willem On 12 Mar 2017 04:32, "Dirk Hohndel" wrote: I would like to update the app. It would be nice if a few people could try the new Subsurface-mobile that's available in the beta test channel... Just as a

Android App

I would like to update the app. It would be nice if a few people could try the new Subsurface-mobile that's available in the beta test channel... Just as a check to make sure I didn't break anything obvious Thanks /D ⁣-- >From my phone​___

[PATCH 3/4] planner.c: fix a couple of float -> int cast warnings

From: "Lubomir I. Ivanov" Use lrint() to fix both: 1) core\planner.c:902:23: warning: conversion to 'int' from 'doub le' may alter its value [-Wfloat-conversion] 2) core\planner.c:907:21: warning: conversion to 'int32_t' from ' double' may alter its value

[PATCH 4/4] qtserialbluetooth.cpp: mark qt_serial_get_transmitted() as unused

From: "Lubomir I. Ivanov" The function is unused, to silence the warning add the "unused" GCC attribute to the function declaration. Signed-off-by: Lubomir I. Ivanov --- core/qtserialbluetooth.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 2/4] templateedit.ui: give the layout for "Border width" unique name

From: "Lubomir I. Ivanov" Warning introduced in e8c918622fb: desktop-widgets\templateedit.ui: Warning: The name 'horizontal Layout_3' (QHBoxLayout) is already in use, defaulting to 'horizontalLayout_31'. Signed-off-by: Lubomir I. Ivanov ---

[PATCH 1/4] Only enable -Wmissing-field-initializers for Clang

From: "Lubomir I. Ivanov" The following pragma is Clang specific: It produces a warning: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] Only enable it for Clang by checking the __clang__ macro. Signed-off-by: Lubomir I. Ivanov ---

Re: Several float to int potential rounding errors/inconsistencies

On 11 March 2017 at 17:24, Dirk Hohndel wrote: > On Sat, Mar 11, 2017 at 03:41:53PM +0200, Lubomir I. Ivanov wrote: >> On 11 March 2017 at 07:21, Jérémie Guichard wrote: >> > Hey guys, >> > >> > I've added the flag conditionally as discussed in previous

Re: Several float to int potential rounding errors/inconsistencies

On 11 March 2017 at 18:32, Linus Torvalds wrote: > On Sat, Mar 11, 2017 at 5:41 AM, Lubomir I. Ivanov > wrote: >> >> of course, there is no need of lrint() in a lot of locations and >> rint() can be used instead, like here: >> >> -

Re: Several float to int potential rounding errors/inconsistencies

On Sat, Mar 11, 2017 at 5:41 AM, Lubomir I. Ivanov wrote: > > of course, there is no need of lrint() in a lot of locations and > rint() can be used instead, like here: > > - sample->depth.mm = depth * FEET * 1000; > + sample->depth.mm = lrint(depth * FEET * 1000); > > "mm" is

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

> On Mar 11, 2017, at 8:30 AM, Stefan Fuchs wrote: > > Hi Dirk, > > > Am 11.03.2017 um 14:47 schrieb Stefan Fuchs: >> >> Pull request submitted. >> >> One important hint: Can happen that there will be a conflict with an still >> open pull request from Robert. Dirk, if you

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

Hi Dirk, Am 11.03.2017 um 14:47 schrieb Stefan Fuchs: > > Pull request submitted. > > One important hint: Can happen that there will be a conflict with an > still open pull request from Robert. Dirk, if you can't merge it after > merging Roberts changes, please tell me! I will then rebase it

Re: Several float to int potential rounding errors/inconsistencies

On Sat, Mar 11, 2017 at 03:41:53PM +0200, Lubomir I. Ivanov wrote: > On 11 March 2017 at 07:21, Jérémie Guichard wrote: > > Hey guys, > > > > I've added the flag conditionally as discussed in previous mail, and updated > > the pull request. > > i've tested the changes locally

Re: [Subsurface-divelog/subsurface] [Idea] Rock bottom/Minimum gas calculation (#188)

Hi All, Am 06.03.2017 um 06:41 schrieb Dirk Hohndel: >> >> How is this progressing? Since I have started to pull new features >> maybe this should get merged as well? >> Or is it still too early for that? >> >> > Status update: Implementation and review: Code unchanged since a few days. No known

Re: Several float to int potential rounding errors/inconsistencies

On 11 March 2017 at 07:21, Jérémie Guichard wrote: > Hey guys, > > I've added the flag conditionally as discussed in previous mail, and updated > the pull request. i've tested the changes locally on Windows and it builds fine. llrint() is also available. 4.9.0 seems to be