Crash on Windows when importing dives via USB from OSTC2

2017-04-18 Thread Stefan Fuchs
Hi All, unfortunately I see a new crash when importing via USB from my OSTC2. This happens under Windows 10 with current master and was not there about 2 weeks ago. It happens every time at the end of data transfer from the dive computer. Stack trace attached. I already started to think about one

preparing for a 4.6.4

2017-04-18 Thread Dirk Hohndel
I know, we've spent all this time on Subsurface-mobile and the bugs there still aren't fully understood (let alone fixed). But I can't forget about our main app again - and we really need to get an update out to our users with the fixed libdivecomputer. I have two options. I can do a quick new bui

Re: Failing to connect to shearwater perdix on linux with subsurface

2017-04-18 Thread Robert Sevat
On 04/18/2017 04:45 AM, Linus Torvalds wrote: > On Mon, Apr 17, 2017 at 3:28 PM, Robert Sevat wrote: >> I am unable to setup a bluetooth connection with subsurface to my >> shearwater perdix on linux. I've run out of troubleshooting ideas. Maybe >> you guys have some pointers/ideas. > This looks l

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Thiago Macieira
Em terça-feira, 18 de abril de 2017 00:08:57 PDT você escreveu: > I will try it this morning. > Two remaining questions: > - What is the default state now if we don't set it explicitly? Enabled true > or false? Depends on the argument passed in the macro. With QtDebugMsg, it defaults to enabled;

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Thiago Macieira
Em terça-feira, 18 de abril de 2017, às 09:23:12 PDT, Stefan Fuchs escreveu: > /home/stefan/Entwicklung/Subsurface/marble-source/src/lib/marble/MarbleDebug > .cpp:27:53: error: passing 'const QLoggingCategory' as 'this' argument of > 'void QLoggingCategory::setEnabled(QtMsgType, bool)' discards qua

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Stefan Fuchs
Hello Lubomir, Am 18.04.2017 um 16:00 schrieb Lubomir I. Ivanov: > i must admit i followed Thiago's suggestions blindly. > Thiago, do you have an idea why this happens? > > the macro: > #define mDebug qCDebug(Marble::loggingCategory) > > expands calls like this one: > mDebug() << "innerRing: size

Re: [PATCH] FAQ: update section on Bluetooth on Linux

2017-04-18 Thread Dirk Hohndel
I know this is stupid - but I actually should remove this file from the Subsurface sources since we now maintain the website in a different repository. I'll apply this and merge the change into the subsurface-website repository, but in the future, pull requests for THAT are the much better (and mo

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Lubomir I. Ivanov
On 18 April 2017 at 16:59, Stefan Fuchs wrote: > Am 18.04.2017 um 15:54 schrieb Lubomir I. Ivanov: > > Sorry, I'm once again lost... > I have multiple compile issues like this: > > /home/stefan/Entwicklung/Subsurface/marble-source/src/lib/marble/geodata/data/GeoDataPolygon.cpp: > In member functio

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Lubomir I. Ivanov
On 18 April 2017 at 16:47, Stefan Fuchs wrote: > Hello Lubomir, > > Am 18.04.2017 um 13:22 schrieb Lubomir I. Ivanov: > > here are the updated Marble files and a patch diff for review. > i can't build Marble to test these changes ATM though. > > Looks good, so long as "Marble::category" isn't too

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Dirk Hohndel
On Tue, Apr 18, 2017 at 02:22:52PM +0300, Lubomir I. Ivanov wrote: > On 18 April 2017 at 10:08, Stefan Fuchs wrote: > > Hello Lubomir, > > > > > > Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov: > > > > here are the updated Marble files and a patch diff for review. > > i can't build Marble to te

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Lubomir I. Ivanov
On 18 April 2017 at 10:08, Stefan Fuchs wrote: > Hello Lubomir, > > > Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov: > > here are the updated Marble files and a patch diff for review. > i can't build Marble to test these changes ATM though. > > Looks good, so long as "Marble::category" isn't to

Re: [PATCH] MarbleDebug: don't use a class extending QIODevice as a null device

2017-04-18 Thread Stefan Fuchs
Hello Lubomir, Am 17.04.2017 um 23:53 schrieb Lubomir I. Ivanov: >>> here are the updated Marble files and a patch diff for review. >>> i can't build Marble to test these changes ATM though. >> Looks good, so long as "Marble::category" isn't too generic a name. >> > ok, i've renamed it to Marable