Re: this looks suspiciously easy

2018-04-18 Thread Dirk Hohndel
On Wed, Apr 18, 2018 at 11:37:53PM -0700, Dirk Hohndel wrote: > On Thu, Apr 19, 2018 at 08:13:23AM +0200, Jef Driesen wrote: > > > > You can also get the mask with the built-in transports from libdivecomputer > > with the dc_context_get_transports() function. With the above, you'll for > > example

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Robert Helling
Hi, > On 19. Apr 2018, at 08:01, Robert Helling wrote: > > I double checked: In 4.7.8, I can connect with BT classic, in your branch I > cannot. Also, in the release version I can change the settings in BLE while > in your branch I get an „Unsupported operation“ error (BTW, we should show > t

Re: this looks suspiciously easy

2018-04-18 Thread Dirk Hohndel
On Thu, Apr 19, 2018 at 08:13:23AM +0200, Jef Driesen wrote: > > You can also get the mask with the built-in transports from libdivecomputer > with the dc_context_get_transports() function. With the above, you'll for > example show usb or usbhid devices even when libdivecomputer was build > withou

Re: call for more testing [was Re: this looks suspiciously easy]

2018-04-18 Thread Dirk Hohndel
On Thu, Apr 19, 2018 at 02:27:14AM -0400, Federico Masias wrote: > Tested an Aqualung i200 on macOS, downloads fine. When I get home in the > morning I can test on a Windows VM as well, to confirm. > > As a total aside, when creating a new log, where does the Map initialize? > It seems to have ini

Re: call for more testing [was Re: this looks suspiciously easy]

2018-04-18 Thread Federico Masias
Tested an Aqualung i200 on macOS, downloads fine. When I get home in the morning I can test on a Windows VM as well, to confirm. As a total aside, when creating a new log, where does the Map initialize? It seems to have initialized in downtown London, which is the last place I looked up in google

Re: this looks suspiciously easy

2018-04-18 Thread Jef Driesen
On 2018-04-19 06:25, Dirk Hohndel wrote: @@ -123,10 +109,31 @@ void fill_computer_list() dc_iterator_t *iterator = NULL; dc_descriptor_t *descriptor = NULL; + int transportMask = 0; +#if defined(BT_SUPPORT) + transportMask |= DC_TRANSPORT_BLUETOOTH; +#endif +#if defin

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Robert Helling
LInus, > On 19. Apr 2018, at 00:54, Linus Torvalds > wrote: > > Did this work with the previous release (4.7.8 or whatever)? > > I had been hoping that I got the config thing right, but I've never > used it or tested it (I'm not sure I even have any of the dive > computers that are supported),

call for more testing [was Re: this looks suspiciously easy]

2018-04-18 Thread Dirk Hohndel
OK, this has been added to the NG branch, current binaries are at the link below. They should only show supported devices on your system. Tested here with a few combinations and it seems to do the right thing. I no longer am offered IRDA computers on my Mac, for example. As with everything in th

IrDA communications

2018-04-18 Thread Willem Ferguson
On 18/04/2018 21:33, Sébastien Dugué wrote: On Wed, Apr 18, 2018 at 9:20 PM, Linus Torvalds wrote: If you're more comfortable just sending packets to the device, doing it in user space would be much better. Right, I like writing drivers, but this has to be a userspace thing. It would also

Re: this looks suspiciously easy

2018-04-18 Thread Linus Torvalds
Looks good to me. Linus On Wed, Apr 18, 2018, 21:26 Dirk Hohndel wrote: > Hey Linus, > > I am surprised how simple this seems to be. What am I missing? > > /D > > > From 4da077bcb6ef06655abd5216dce742b2b185efeb Mon Sep 17 00:00:00 2001 > From: Dirk Hohndel > Date: Wed, 18 Apr 2018 21:19:14

this looks suspiciously easy

2018-04-18 Thread Dirk Hohndel
Hey Linus, I am surprised how simple this seems to be. What am I missing? /D From 4da077bcb6ef06655abd5216dce742b2b185efeb Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Wed, 18 Apr 2018 21:19:14 -0700 Subject: [PATCH] Only offer dive computers with supported transports On Android we still

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 19, 2018, at 12:54 AM, Linus Torvalds > wrote: > > On Wed, Apr 18, 2018 at 3:37 PM, Robert Helling wrote: >> >> Couldn’t get the dive computer configuration to work either with BLE or >> classic. > > Did this work with the previous release (4.7.8 or whatever)? > > I had been hopin

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 4:18 PM, Linus Torvalds wrote: > > Hmm. Which IRDA chip is it that is in the Uwatec dongle? > > Is it perhaps the MosChip MCS7780? You'd know, because then it would > be using USB ID 9710:7780. That seems to be the common case. Hmm. Googling around, I see that it might als

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:27 PM, Sébastien Dugué wrote: > > I looked into this when writing a simulator of my 2G and as far as I > remember, there's not much of the stack involved when talking to an irda > DC. All special cases. I may still have the traffic captures laying around Hmm. Which IR

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 3:37 PM, Robert Helling wrote: > > Couldn’t get the dive computer configuration to work either with BLE or > classic. Did this work with the previous release (4.7.8 or whatever)? I had been hoping that I got the config thing right, but I've never used it or tested it (I'

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Robert Helling
Hi, > On 18. Apr 2018, at 23:01, Dirk Hohndel wrote: > > We now have binaries for Windows, Mac, and Linux (AppImage only) available in > order for people to test this. > > https://github.com/Subsurface-divelog/subsurface/releases/tag/continuous-NG >

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Salvador Cuñat
Good night, On Wed, Apr 18, 2018 at 11:01:28PM +0200, Dirk Hohndel wrote: > > We now have binaries for Windows, Mac, and Linux (AppImage only) available in > order for people to test this. > AppImage works fine for USB download (on debian with an OSTC 2N device). Best regards. Salva. _

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
We now have binaries for Windows, Mac, and Linux (AppImage only) available in order for people to test this. https://github.com/Subsurface-divelog/subsurface/releases/tag/continuous-NG /D_

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 18, 2018, at 10:13 PM, Robert Helling wrote: > > Dirk, > >> On 18. Apr 2018, at 21:28, Dirk Hohndel > > wrote: >> >> I'm trying to get Travis to do that for us. >> Which OSs can you test? Travis creates an AppImage, Windows and an unsigned >> Mac .app - assum

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Willem Ferguson
>From phone. You guys in the developed world have resources for all the latest kit. I my country iRda is commonly used. In addition the CCR community worldwide often use iRda. It has a significant role to play at least for the next 10 years. Therefore I strongly argue for the continued support of i

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Robert Helling
Dirk, > On 18. Apr 2018, at 21:28, Dirk Hohndel wrote: > > I'm trying to get Travis to do that for us. > Which OSs can you test? Travis creates an AppImage, Windows and an unsigned > Mac .app - assuming the builds don't fail :-) please excuse my ignorance. It seems that the Mac build on Travis

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Hartley Horwitz
> > > > -- Forwarded message -- > From: Linus Torvalds > To: "Sébastien Dugué" > Cc: Subsurface Mailing List > Bcc: > Date: Wed, 18 Apr 2018 12:20:35 -0700 > Subject: Re: Any brave dive computer download testers out there? > On Wed, Apr 18, 2018 at 12:14 PM, Sébastien Dugué > wr

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:27 PM, Sébastien Dugué wrote: > > I looked into this when writing a simulator of my 2G and as far as I > remember, there's not much of the stack involved when talking to an irda > DC. All special cases. I may still have the traffic captures laying around Yeah, it shou

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Matt Thompson
I can test all three platforms. I have a Macbook and a dual boot PC and a pile of computers with fresh dives from this weekend! :) On Wed, Apr 18, 2018 at 2:28 PM, Dirk Hohndel wrote: > > > On Apr 18, 2018, at 9:17 PM, Matt Thompson wrote: > > > > I don't have time to set up a build environmen

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 9:20 PM, Linus Torvalds wrote: > If you're more comfortable just sending packets to the device, doing > it in user space would be much better. Right, I like writing drivers, but this has to be a userspace thing. > > It would also make it possible to work on OS X, because

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 18, 2018, at 9:17 PM, Matt Thompson wrote: > > I don't have time to set up a build environment but if I can get a test build > for any of the supported OS's I can test with a Cobalt, Suunto D4i, and > Aqualung i750tc. I'm trying to get Travis to do that for us. Which OSs can you test

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 9:17 PM, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 12:10 PM, Sébastien Dugué > wrote: >> >> Looks like a bit daunting for me. However maybe a userspace approach >> might be doable. Dunno. Will have to think a bit more about it. > > Indeed. That has been my long-ter

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:14 PM, Sébastien Dugué wrote: > > Right, only bring back those pieces that are of interest. I'll take a look > at this, but I'm not really into bloated communication stacks... I'm merely > a low-level driver coder. If you're more comfortable just sending packets to th

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Matt Thompson
I don't have time to set up a build environment but if I can get a test build for any of the supported OS's I can test with a Cobalt, Suunto D4i, and Aqualung i750tc. On Wed, Apr 18, 2018 at 2:04 PM, Dirk Hohndel wrote: > > > On Apr 18, 2018, at 8:56 PM, Linus Torvalds < > torva...@linux-foundat

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:10 PM, Sébastien Dugué wrote: > > Looks like a bit daunting for me. However maybe a userspace approach > might be doable. Dunno. Will have to think a bit more about it. Indeed. That has been my long-term thinking about IRDA - most of the IRDA dongles are just USB or s

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 9:07 PM, Linus Torvalds wrote: >> I'd love to bring it back, but it would need a maintainer.. Hint hint. > > And by "it", I don't actually mean all of irda. irda is dead, dead, > dead. But maybe the actual individual driver that somebody is willing > to maintain, and a smal

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:06 PM, Sébastien Dugué wrote: > > OK, it's good to go. The download is in progress (it's painfully > slow), but that > means divecomputer_device_open() did succeed! Thanks. Committed and pushed out to the libdivecomputer-NG branch. Linus

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Miika Turkia
On Wed, Apr 18, 2018 at 9:47 PM, Linus Torvalds < torva...@linux-foundation.org> wrote: > On Wed, Apr 18, 2018 at 11:31 AM, Miika Turkia > wrote: > > > > I failed with BT download (OSTC Sport). But my download fails also with > the > > release version of Subsurface. Unpairing-pairing works but no

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Federico Masias
I've never been able to get a proper build on macOS (though I honestly haven't been particularly motivated to do so lately) so I can't test Linus' branch I'd be able to test an i200 if you did a test binary, but I'm not sure the effort is worth it for one person who can only test USB On Wed, Apr

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 9:00 PM, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 11:57 AM, Sébastien Dugué > wrote: >>> >>> Note that IRDA support is going away in the kernel, though - we had >>> too many bugs and it was impossible to maintain. So you'll have to use >>> an older kernel. >> >> A

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:00 PM, Linus Torvalds wrote: > > I'd love to bring it back, but it would need a maintainer.. Hint hint. And by "it", I don't actually mean all of irda. irda is dead, dead, dead. But maybe the actual individual driver that somebody is willing to maintain, and a small sub

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 8:58 PM, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 11:48 AM, Linus Torvalds > wrote: >> On Wed, Apr 18, 2018 at 12:55 AM, Sébastien Dugué >> wrote: >>> >>> That's really cool! I'll try that out tonight (CET) with my Uwatec DCs >>> just to >>> check IRDA is still

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 18, 2018, at 8:56 PM, Linus Torvalds > wrote: > > On Wed, Apr 18, 2018 at 11:48 AM, Dirk Hohndel wrote: >> >> I think that's backwards. If the dive computer and the Subsurface version >> both support BT, we should prefer that over BLE by default. > > Well, since it seems to be broke

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 11:57 AM, Sébastien Dugué wrote: >> >> Note that IRDA support is going away in the kernel, though - we had >> too many bugs and it was impossible to maintain. So you'll have to use >> an older kernel. > > Arghhh! You mean the whole stack? Darn! will have to keep some old

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 11:48 AM, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 12:55 AM, Sébastien Dugué > wrote: >> >> That's really cool! I'll try that out tonight (CET) with my Uwatec DCs >> just to >> check IRDA is still functional. > > I'm pretty sure I broke IRDA. It should be easy to

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 8:48 PM, Linus Torvalds wrote: > On Wed, Apr 18, 2018 at 12:55 AM, Sébastien Dugué > wrote: >> >> That's really cool! I'll try that out tonight (CET) with my Uwatec DCs >> just to >> check IRDA is still functional. > > I'm pretty sure I broke IRDA. It should be easy to

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 11:48 AM, Dirk Hohndel wrote: > > I think that's backwards. If the dive computer and the Subsurface version > both support BT, we should prefer that over BLE by default. Well, since it seems to be broken, I'm not sure that's a good idea. I also definitely don't want to de

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 18, 2018, at 8:47 PM, Linus Torvalds > wrote: > > On Wed, Apr 18, 2018 at 11:31 AM, Miika Turkia wrote: >> >> I failed with BT download (OSTC Sport). But my download fails also with the >> release version of Subsurface. Unpairing-pairing works but no download with >> subsurface on Li

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 12:55 AM, Sébastien Dugué wrote: > > That's really cool! I'll try that out tonight (CET) with my Uwatec DCs just > to > check IRDA is still functional. I'm pretty sure I broke IRDA. It should be easy to fix. Note that IRDA support is going away in the kernel, though -

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Dirk Hohndel
> On Apr 18, 2018, at 8:40 PM, Linus Torvalds > wrote: > >> - Successful download over BLE >> - Cannot download over classic BT (it always goes to BLE, even in case >> "force classic" in the UI is chosen). But unsure this is related to the >> transport refactoring. > > Yeah, right now the logi

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
On Wed, Apr 18, 2018 at 9:55 AM, Sébastien Dugué wrote: > Hello Linus, > > On Wed, Apr 18, 2018 at 5:35 AM, Linus Torvalds > wrote: >> So libdivecomputer has a new custom IO model, which allows us to drop >> our home-made one. >> >> However, that new model is fairly different from our old model,

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 11:31 AM, Miika Turkia wrote: > > I failed with BT download (OSTC Sport). But my download fails also with the > release version of Subsurface. Unpairing-pairing works but no download with > subsurface on Linux desktop for me :( Is the OSTC sport a rfcomm (legacy BT) device

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Linus Torvalds
On Wed, Apr 18, 2018 at 2:29 AM, Jan Mulder wrote: > > Tested on Arch Linux with an OSTC3 (desktop only, so no mobile-on-desktop, > or Android). Thanks. > - Successful download over BLE > - Cannot download over classic BT (it always goes to BLE, even in case > "force classic" in the UI is chosen

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Miika Turkia
On Wed, Apr 18, 2018 at 12:29 PM, Jan Mulder wrote: > On 18-04-18 05:35, Linus Torvalds wrote: > >> >> I have *TEST* branches for both, in case people want to help test. >> Note! I only do source code, so this really only works for people who >> can build their own subsurface binary, but if you a

Re: Problems importing APD CCR dive logs.

2018-04-18 Thread Anton Lundin
On 18 April, 2018 - Miika Turkia wrote: > On Wed, Apr 18, 2018 at 6:19 PM, Anton Lundin wrote: > > > On 18 April, 2018 - Willem Ferguson wrote: > > > > > On 18/04/2018 16:05, Miika Turkia wrote: > > > >On Wed, Apr 18, 2018 at 4:14 PM, Willem Ferguson > > > > > > >

Re: Problems importing APD CCR dive logs.

2018-04-18 Thread Miika Turkia
On Wed, Apr 18, 2018 at 6:19 PM, Anton Lundin wrote: > On 18 April, 2018 - Willem Ferguson wrote: > > > On 18/04/2018 16:05, Miika Turkia wrote: > > >On Wed, Apr 18, 2018 at 4:14 PM, Willem Ferguson > > > > >> wrote: > > > > > >Dear Miika, > > > > > >

Re: Problems importing APD CCR dive logs.

2018-04-18 Thread Anton Lundin
On 18 April, 2018 - Willem Ferguson wrote: > On 18/04/2018 16:05, Miika Turkia wrote: > >On Wed, Apr 18, 2018 at 4:14 PM, Willem Ferguson > > >> wrote: > > > >Dear Miika, > > > >Would you by any chance be prepared to look at the attached APD > >d

Re: Problems importing APD CCR dive logs.

2018-04-18 Thread Willem Ferguson
On 18/04/2018 16:05, Miika Turkia wrote: On Wed, Apr 18, 2018 at 4:14 PM, Willem Ferguson > wrote: Dear Miika, Would you by any chance be prepared to look at the attached APD dive log? The setpoint data are there and correctly identified in

Fwd: Re: [Subsurface-divelog/subsurface] Plot OC-pO2 graph for SCR dives (#1166)

2018-04-18 Thread Willem Ferguson
On 18/04/2018 15:42, Robert C. Helling wrote: Sorry, I missed this. From a coding perspective: This looks good to me. Could you explain, in which situation this "OC equivalent" becomes relevant, why would one look at this line? Further, why don't you directly base this onto your branch wh

Re: Problems importing APD CCR dive logs.

2018-04-18 Thread Miika Turkia
On Wed, Apr 18, 2018 at 4:14 PM, Willem Ferguson < willemfergu...@zoology.up.ac.za> wrote: > Dear Miika, > > Would you by any chance be prepared to look at the attached APD dive log? > The setpoint data are there and correctly identified in the import dialog. > However, it is not written to xml. C

Problems importing APD CCR dive logs.

2018-04-18 Thread Willem Ferguson
Dear Miika, Would you by any chance be prepared to look at the attached APD dive log? The setpoint data are there and correctly identified in the import dialog. However, it is not written to xml. Consequently the setpoint is erroneously shown as the same value as pO2. Can it be user error (tha

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Jan Mulder
On 18-04-18 05:35, Linus Torvalds wrote: I have *TEST* branches for both, in case people want to help test. Note! I only do source code, so this really only works for people who can build their own subsurface binary, but if you are one of those hardy souls, it realy would be good to get more cas

Re: Any brave dive computer download testers out there?

2018-04-18 Thread Sébastien Dugué
Hello Linus, On Wed, Apr 18, 2018 at 5:35 AM, Linus Torvalds wrote: > So libdivecomputer has a new custom IO model, which allows us to drop > our home-made one. > > However, that new model is fairly different from our old model, and > there were other updates too, so the changes are "flag-day" c