[Fwd: Re: road to 4.9]

Forwarded Message From: Steve Reply-To: stevewilli...@internode.on.net To: Berthold Stoeger Cc: subsurface@subsurface-divelog.org, Dirk Hohndel Subject: Re: road to 4.9 Date: Mon, 15 Jul 2019 14:55:36 +1000 On Mon, 2019-07-15 at 00:11 +0200, Berthold Stoeger wrote: > Hi

Re: road to 4.9

On Sun, 2019-07-14 at 16:51 -0700, Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 3:57 PM Steve < > stevewilli...@internode.on.net > > wrote: > > Yes I am in Adelaide Australia, I haven't played with the local on > > purpose but if anything if there is no en_au then I would have > > choose > >

Re: 4.9

On Sun, Jul 14, 2019 at 5:17 PM Dirk Hohndel wrote: > > I won't get to 4.9 today. > Soon, but not today. Ok. I have updated the libdivecomputer repositories with the upstream merge from Jef, but haven't touched subsurface itself. That way you can make the decision at any time. The changes

Re: 4.9

I won't get to 4.9 today. Soon, but not today. /D On July 14, 2019 11:33:30 AM PDT, Linus Torvalds wrote: >On Sat, Jul 13, 2019 at 9:15 PM Dirk Hohndel wrote: >> >> Is there anything missing? Anything I should wait for? > >Not worth waiting for, but I _could_ do a libdivecomputer update from

Re: road to 4.9

On Sun, Jul 14, 2019 at 3:57 PM Steve wrote: > > Yes I am in Adelaide Australia, I haven't played with the local on > purpose but if anything if there is no en_au then I would have choose > en_gb. I tried to look through our history. I don't think we've ever localized the cylinder usage

Re: road to 4.9

On Sun, 2019-07-14 at 10:56 -0700, Linus Torvalds wrote: > On Sun, Jul 14, 2019 at 10:40 AM Linus Torvalds > < > torva...@linux-foundation.org > > wrote: > > Better version here - this does the save-git case too, and > > simplifies > > things by using 'show_utf8()' that already checks for NULL >

Re: road to 4.9

Hi Steve, > Cheers, output below: Many thanks. Just for my peace of mind, would you please provide the output of the following gdb commands after it hits the crash: (gdb) print i (gdb) print nr (gdb) print cylinder (gdb) print *cylinder (gdb) print dive->cylinder (gdb) print >cylinder

Re: 4.9

On Sunday, 14 July 2019 22:53:07 CEST Linus Torvalds wrote: > Steve's problem with the cylinder usage was easy to reproduce. > > Just export one dive that has a cylinder as xml. Then edit it to add > something like > > use="impossible" > > for the cylinder. Sure, but what I'd like to

Re: 4.9

On Sun, Jul 14, 2019, 13:43 Berthold Stoeger said: > > > We have at least one reproducible crash ( > https://github.com/Subsurface-divelog/subsurface/issues/2167) > > No idea on that one. But: no confirmation that Steve's problem

Re: 4.9

On Sunday, 14 July 2019 06:15:12 CEST Dirk Hohndel wrote: > Is there anything missing? Anything I should wait for? We have at least one reproducible crash (https://github.com/Subsurface-divelog/subsurface/issues/2167) [1]and no confirmation that Steve's problem was fixed (I'd like to

Re: 4.9

On Sat, Jul 13, 2019 at 9:15 PM Dirk Hohndel wrote: > > Is there anything missing? Anything I should wait for? Not worth waiting for, but I _could_ do a libdivecomputer update from Jef. The only real reason to do that would be the Aqualung i550C support. I've never seen one, and it could wait.

Re: road to 4.9

On Sun, Jul 14, 2019 at 10:40 AM Linus Torvalds wrote: > > Better version here - this does the save-git case too, and simplifies > things by using 'show_utf8()' that already checks for NULL internally. I've created a pull request, and while testing it I found another (pretty harmless) bug in xml

Re: road to 4.9

On Sun, Jul 14, 2019 at 10:18 AM Linus Torvalds wrote: > > Maybe a patch like the attached? Better version here - this does the save-git case too, and simplifies things by using 'show_utf8()' that already checks for NULL internally. Linus core/dive.c | 2 +- core/dive.h |

Re: road to 4.9

On Sun, Jul 14, 2019 at 6:16 AM Steve wrote: > > (gdb) where > #0 0x00708fcd in save_cylinder_info (dive=0xc34f240, > b=0x7fffc2c0) at /home/steve/src/subsurface/core/save-xml.c:193 Interesting. It looks like you likely have an odd cylinder "use" string that you load, resulting in

Re: 4.9

I'm happy to pull translations again. 4.9 vs 4.9.0... We always talk about 4.9, but in order for our version numbering to work, I need to tag it as 4.9.0 I can change it in the README, I guess, but I didn't think it would be a problem .. /D On July 14, 2019 5:15:57 AM PDT, Miika Turkia

Re: road to 4.9

On Sun, 2019-07-14 at 10:03 +0200, Berthold Stoeger wrote: > Hi Steve, > > > > On Sunday, 14 July 2019 08:00:44 CEST Steve wrote: > > > I had a quick chance today to setup a build environment, I also > found > > > something that consistently caused it to crash which was loading > from > > >

Re: 4.9

On Sun, Jul 14, 2019 at 7:15 AM Dirk Hohndel wrote: > > I updated the manual, support dive computer list, README, ReleaseNotes, > translations... > Should probably state this to be README file for 4.9.0 as this version number is used for file names and tag. I just did the Finnish translation.

Re: road to 4.9

Hi Steve, On Sunday, 14 July 2019 08:00:44 CEST Steve wrote: > I had a quick chance today to setup a build environment, I also found > something that consistently caused it to crash which was loading from > cloud and then trying to save to a local file.eg: load from cloud, then > file save as

Re: road to 4.9

On Mon, 2019-06-24 at 12:50 +0800, Dirk Hohndel wrote: > Hi Steve, > Thanks for the testing and reports (and update to old reports on > GitHub). > This is so incredibly useful to me > > > On Jun 24, 2019, at 11:42 AM, Steve > > wrote: > > > > When editing a dive date the date chooser is jumping