[PATCH] The 3 late patches

Hello, I have fixed the 3 late patches and added one more patch for style fixing. -- regards, Gehad From ee86aebe3498debae579db10bc5d3f51f44dd64d Mon Sep 17 00:00:00 2001 From: Gehad elrobey <gehadelro...@gmail.com> Date: Thu, 27 Aug 2015 22:40:04 +0200 Subject: [PATCH 1/4] Printing: s

Re: printing patches

On Fri, Sep 11, 2015 at 8:53 PM, Dirk Hohndel <d...@hohndel.org> wrote: > On Fri, Sep 11, 2015 at 08:50:16PM +0200, Gehad Elrobey wrote: > > > I understand that you are busy, Gehad. Trust me, I know the feeling. > > > Right now I'm holding back Beta 2, waiting for yo

Re: printing patches

On Wed, Sep 9, 2015 at 1:14 PM, Lubomir I. Ivanov wrote: > On 9 September 2015 at 13:15, Dirk Hohndel wrote: > > Gehad, Lubomir, > > > > I saw some patches a while ago that Lubomir commented on and that Gehad > > said he would rework and resubmit. Did I

Re: Beta 1 released

On Fri, Sep 4, 2015 at 11:29 AM, Lubomir I. Ivanov wrote: > On 4 September 2015 at 12:05, Guillaume Gardet > wrote: > > Hi, > > > > Le 03/09/2015 23:10, Dirk Hohndel a écrit : > >> > >> Let the testing begin. > > > > > > I tried beta 1 just now.

Re: Customizable prints progress

On Sat, Aug 22, 2015 at 6:44 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 22 August 2015 at 19:20, Gehad Elrobey gehadelro...@gmail.com wrote: On Sat, Aug 22, 2015 at 5:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: can we eventually support HTML/CSS editing

Re: Customizable prints progress

On Fri, Aug 21, 2015 at 9:38 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 21 August 2015 at 20:52, Gehad Elrobey gehadelro...@gmail.com wrote: On Tue, Aug 18, 2015 at 10:06 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 August 2015 at 03:51, Gehad Elrobey gehadelro

Re: Customizable prints progress

On Sat, Aug 22, 2015 at 6:44 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 22 August 2015 at 19:20, Gehad Elrobey gehadelro...@gmail.com wrote: On Sat, Aug 22, 2015 at 5:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: can we eventually support HTML/CSS editing

Re: Customizable prints progress

On Sat, Aug 22, 2015 at 5:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 22 August 2015 at 17:09, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Aug 21, 2015 at 9:38 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 21 August 2015 at 20:52, Gehad Elrobey gehadelro

Re: Customizable prints progress

On Fri, Aug 21, 2015 at 10:34 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 21 August 2015 at 22:38, Lubomir I. Ivanov neolit...@gmail.com wrote: but please wait for my user-manual comments to be finished before updating your github three. WIP... done. we are doing a single

Re: Customizable prints progress

On Tue, Aug 18, 2015 at 10:06 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 August 2015 at 03:51, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, As I am progressing with the documentation, I want to add description for users willing to write their own templates, so I

Re: Customizable prints progress

Hello Lubomir, As I am progressing with the documentation, I want to add description for users willing to write their own templates, so I will need to describe many concepts related to our defined css selectors, Grantlee names, etc. do you think it is relevant to add these details in the user

Re: at some point we need to release Subsurface 4.5

On Mon, Aug 17, 2015 at 4:20 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 August 2015 at 17:06, Gehad Elrobey gehadelro...@gmail.com wrote: On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: ATM, the plan for the statistics print

Re: at some point we need to release Subsurface 4.5

On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 August 2015 at 16:16, Dirk Hohndel d...@hohndel.org wrote: I've been saying this for a while now. But I'd like to actually try and make this happen sooner rather than later... So here's what I can

Re: Customizable prints progress

On Sat, Aug 15, 2015 at 2:23 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 15 August 2015 at 14:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 August 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov neolit

Re: Customizable prints progress

On Sat, Aug 15, 2015 at 1:59 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 August 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 13, 2015 at 10:47 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 12 August 2015 at 18:47, Gehad Elrobey gehadelro

Re: Customizable prints progress

Hello Lubomir, I have resolved most of the issues you have mentioned above, still working on enhancing the statistics view, I hope I didn't miss anything so please have a look and update me if you have any notes. All commits are pushed to my branch. Regards, Gehad

Re: Customizable prints progress

are annoying but we need to fix them before the user feedback as more will stack and we may lose track of what has to be done. On 9 August 2015 at 04:10, Gehad Elrobey gehadelro...@gmail.com wrote: On Thu, Aug 6, 2015 at 11:51 AM, Lubomir I. Ivanov neolit...@gmail.com here are some observations

Re: Customizable prints progress

On Thu, Aug 6, 2015 at 11:51 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: hello Gehad, On 6 August 2015 at 02:25, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I wanted to update you with my progress till now, Last week I got stuck with a bug that took long time

Customizable prints progress

Hello Lubomir, I wanted to update you with my progress till now, Last week I got stuck with a bug that took long time to debug and fix (I didn't fix it completely but hopefully will refactor my fixing code soon), here is what I completed till now Template enhancement: - Manage unused space in

Re: GSoC Status - Week 9 (Customizable prints)

On Mon, Jul 27, 2015 at 8:31 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 27 July 2015 at 18:10, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, This week I was working on the following tasks: - Search for templates in printing_templates directory. - Fix

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 4:41 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 12:18:36PM +0300, Lubomir I. Ivanov wrote: More from Gehad: - added a Table print template - we had this one before - added a Flow print template - as discussed at GSoC start, this one can span

Re: default colors for print [was: Re: [PULL REQUEST] GSoC Printing: part 5]

On Tue, Jul 28, 2015 at 7:59 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:47:35PM +0300, Lubomir I. Ivanov wrote: That's not exactly intuitive. But once we find a color palette that's reasonably pleasing to the eye maybe this is not too bad... With the deepest

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 7:35 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 19:26, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 07:09:37PM +0300, Lubomir I. Ivanov wrote: In my case the toggle calculated ceilings setting is on (as I want to see

Re: [PULL REQUEST] GSoC Printing: part 5

On Tue, Jul 28, 2015 at 6:09 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 28 July 2015 at 18:41, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 28, 2015 at 06:34:36PM +0300, Lubomir I. Ivanov wrote: I am blown away. This is really great work. It's not perfect, there are things

GSoC Status - Week 9 (Customizable prints)

Hello Lubomir, This week I was working on the following tasks: - Search for templates in printing_templates directory. - Fix QSettingsGroup issue. - Make TemplateEdit dialog re-sizable. - Implement import,export and delete templates. - Add shades of blue color palette. - Add flow layout. - Add

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 4:59 PM, Dirk Hohndel d...@hohndel.org wrote: On Jul 20, 2015, at 07:30, Miika Turkia miika.tur...@gmail.com wrote: Agreed. Better looking templates or at least templates that look closer to what we had. I'll admit that the shades of orange and beige color

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 21, 2015 at 3:15 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Jul 21, 2015 at 11:24:19AM +0200, Gehad Elrobey wrote: On Mon, Jul 20, 2015 at 4:59 PM, Dirk Hohndel d...@hohndel.org wrote: I want to admit that I am not a clever color chooser, I will add another color

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 12:20 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 July 2015 at 13:06, Gehad Elrobey gehadelro...@gmail.com wrote: On Sun, Jul 19, 2015 at 9:56 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 July 2015 at 13:23, Gehad Elrobey gehadelro

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 20, 2015 at 3:02 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 July 2015 at 14:59, Gehad Elrobey gehadelro...@gmail.com wrote: Now we always rasterize for grayscale, I pushed the updates. PR sent. thank you for bearing with the greyscale issues... some important

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 9:28 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:17, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 22:10, Gehad Elrobey gehadelro...@gmail.com wrote: Yes it does, you can test it on current master

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:38, Gehad Elrobey gehadelro...@gmail.com wrote: On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 13:19, Gehad Elrobey gehadelro

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 21:36, Tomaz Canabrava tcanabr...@kde.org wrote: I am forces to render the dive profile on a QImage so that I can convert it to grayscale image and then render it on top of the QWebview, Do

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 9:01 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 21:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jul 17, 2015 at 8:46 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 21:36, Tomaz Canabrava tcanabr

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:51 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 21:49, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jul 17, 2015 at 8:37 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 21:13, Gehad Elrobey gehadelro

Re: GSoC Status - Week 7 (Customizable prints)

On Fri, Jul 17, 2015 at 8:08 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 17 July 2015 at 20:06, Gehad Elrobey gehadelro...@gmail.com wrote: On Tue, Jul 14, 2015 at 1:43 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:38, Gehad Elrobey gehadelro

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 2:01 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:51, Gehad Elrobey gehadelro...@gmail.com wrote: On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:43, Lubomir I. Ivanov neolit

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:29 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 13:19, Gehad Elrobey gehadelro...@gmail.com wrote: On Jul 14, 2015 12:15 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 00:16, Gehad Elrobey gehadelro...@gmail.com wrote

Re: GSoC Status - Week 7 (Customizable prints)

On Tue, Jul 14, 2015 at 1:46 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:43, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 14:38, Gehad Elrobey gehadelro...@gmail.com wrote: 3) i get no text / data in the tables under the profiles. could

GSoC Status - Week 7 (Customizable prints)

Hello all, This week I was working on the following tasks: - Enhancing the one dive per page template. - Refactoring the Printing class to handle QPrinter and QPixmap. - Implement the Preview section in TemplateEdit dialog. - Adding color tab to TemplateEdit. - Adding color palettes to template

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 11:13 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 13 July 2015 at 23:54, Gehad Elrobey gehadelro...@gmail.com wrote: On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 13 July 2015 at 22:35, Gehad Elrobey gehadelro

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 10:33 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 13 July 2015 at 22:35, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was working on the following tasks: - Enhancing the one dive per page template. - Refactoring the Printing class

Re: GSoC Status - Week 7 (Customizable prints)

On Mon, Jul 13, 2015 at 11:22 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 July 2015 at 00:19, Lubomir I. Ivanov neolit...@gmail.com wrote: then again, there was this huge lines issues with QImage on Linux in Qt5.x, so if this bug is still present QPixmap should be used. via

Re: GSoC Status - Week 5 (Customizable prints)

On Wed, Jul 1, 2015 at 8:38 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 19:05, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 01, 2015 at 05:23:32PM +0300, Lubomir I. Ivanov wrote: On 1 July 2015 at 17:18, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 01, 2015

Re: GSoC Status - Week 5 (Customizable prints)

On Wed, Jul 1, 2015 at 3:23 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 16:11, Lubomir I. Ivanov neolit...@gmail.com wrote: i don't understand CSS very well, but if that's a viable solution we should definitely give it a go. the problem i see here is that if the

Re: GSoC Status - Week 5 (Customizable prints)

On Wed, Jul 1, 2015 at 8:47 PM, Gehad Elrobey gehadelro...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:38 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 19:05, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 01, 2015 at 05:23:32PM +0300, Lubomir I. Ivanov wrote: On 1

Re: GSoC Status - Week 5 (Customizable prints)

On Wed, Jul 1, 2015 at 9:01 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 21:47, Gehad Elrobey gehadelro...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:38 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 19:05, Dirk Hohndel d...@hohndel.org wrote

Re: GSoC Status - Week 5 (Customizable prints)

On Wed, Jul 1, 2015 at 4:23 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 1 July 2015 at 17:18, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jul 01, 2015 at 04:51:13PM +0300, Lubomir I. Ivanov wrote: basically, i was going to ask about the whole bw vs color printing. given that in

Re: GSoC Status - Week 5 (Customizable prints)

On Tue, Jun 30, 2015 at 11:13 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 30 June 2015 at 03:53, Gehad Elrobey gehadelro...@gmail.com wrote: On Mon, Jun 29, 2015 at 4:13 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 29 June 2015 at 05:08, Gehad Elrobey gehadelro

Re: GSoC Status - Week 5 (Customizable prints)

On Mon, Jun 29, 2015 at 4:13 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 29 June 2015 at 05:08, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was working on the list of tasks which I have discussed with Lubomir. Tasks completed so far

GSoC Status - Week 5 (Customizable prints)

Hello all, This week I was working on the list of tasks which I have discussed with Lubomir. Tasks completed so far: - QPrintPreviewDialog triggered from the main dialog - add print selected dives support - print in colors or gray scale - fix dive profile bugs - fixed two dives per page template

Re: [PULL REQUEST] GSoC Printing: part 2

On Sat, Jun 20, 2015 at 11:03 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 June 2015 at 06:19, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task

Re: [PULL REQUEST] GSoC Printing: part 2

On Fri, Jun 19, 2015 at 9:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: So this is the second batch of patches for this GSoC task. Here Gehad has added another template which is the one dive per page, some minor fixes and renames here and there and also support for printing on any

Re: GSoC Status - Week 3 (Customizable prints)

On Sat, Jun 20, 2015 at 6:09 AM, Dirk Hohndel d...@hohndel.org wrote: On Fri, Jun 19, 2015 at 09:15:02PM +0300, Lubomir I. Ivanov wrote: On 19 June 2015 at 14:56, Lubomir I. Ivanov neolit...@gmail.com wrote: On 19 June 2015 at 14:37, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun

Re: GSoC Status - Week 3 (Customizable prints)

On Fri, Jun 19, 2015 at 1:37 PM, Gehad Elrobey gehadelro...@gmail.com wrote: On Jun 19, 2015 12:58 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 June 2015 at 14:35, Gehad Elrobey gehadelro...@gmail.com wrote: rebased with current master and pushed. for the last batch

Re: HTML export - expanding a dive

Yes, .target is working here on chromium and yes I meant Expansion I ll refactor that sorry for the wrong spelling. On Wed, Jun 17, 2015 at 7:02 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Jun 17, 2015 at 09:59:21AM -0700, Dirk Hohndel wrote: I couldn't reproduce this on Chromium but I

Re: GSoC Status - Week 3 (Customizable prints)

wrote: On 14 June 2015 at 18:59, Lubomir I. Ivanov neolit...@gmail.com wrote: On 14 June 2015 at 13:43, Gehad Elrobey gehadelro...@gmail.com wrote: Hello all, This week I was mainly working to add the dive profile to the print output, what I have finished so far: - I have added the dive

Re: HTML export - expanding a dive

87d9285e20ed2ea07e5474e19d440f291c03ffbc Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Wed, 17 Jun 2015 17:53:51 +0200 Subject: [PATCH] HTML: fix the unclosed ul tag. The ul tag must be closed as defined by the html specs. Signed-off-by: Gehad elrobey gehadelro...@gmail.com

GSoC Status - Week 3 (Customizable prints)

Hello all, This week I was mainly working to add the dive profile to the print output, what I have finished so far: - I have added the dive profile correctly to the templates. - I have added the option to export one dive per page. - I have fixed some printing bugs. what needs fixing before

GSoC Status - Week 2 (Customizable prints)

Hello, This is my weekly update for the second week of GSoC, Things I have done: - I fixed the print dive model so now its native c++ class and removed the QObject inheritance. - I worked on cleaning the completed code to be pushed to master. - I have done some further work in the Printer class

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 4, 2015 at 8:13 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 20:02, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:58:10PM +0300, Lubomir I. Ivanov wrote: So this is the initial work from Gehad. I'm looking forward to getting this in

Re: [PULL REQUEST] GSoC Printing: initial batch of patches

On Thu, Jun 4, 2015 at 7:52 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 June 2015 at 19:42, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 04, 2015 at 05:47:02PM +0200, Guillaume Gardet wrote: Le 04/06/2015 17:43, Lubomir I. Ivanov a écrit : On 4 June 2015 at 18:27, Lubomir I.

Re: GSoC - Customizable print formats

On Sun, May 31, 2015 at 8:01 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 31 May 2015 at 08:59, Gehad Elrobey gehadelro...@gmail.com wrote: I think we can use standard c++ generic classes with grantlee as their documentation says http://www.grantlee.org/apidox

GSoC Status - Week 1 (Customizable prints)

Hello, This is a weekly update of my progress in GSoC, I didn't do much this week as I am having my final exams now. I did some prototyping with Grantlee before gsoc, and I am now working to clean the code and fix the issues. Things I have done so far: - Created a 2 dives per page Grantlee

Re: GSoC - Customizable print formats

On Wed, May 27, 2015 at 10:32 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 27 May 2015 at 20:09, Gehad Elrobey gehadelro...@gmail.com wrote: On Tue, May 26, 2015 at 12:55 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 25 May 2015 at 21:26, Gehad Elrobey gehadelro

Re: GSoC - Customizable print formats

On Sat, May 30, 2015 at 9:33 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 30 May 2015 at 20:07, Gehad Elrobey gehadelro...@gmail.com wrote: On Wed, May 27, 2015 at 10:32 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: well, having the code as WIP in master without the macro

Re: GSoC - Customizable print formats

On Tue, May 26, 2015 at 12:55 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 25 May 2015 at 21:26, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, As GSoC coding period have begun, I wanted to update you with my progress till now, I've pushed some more commits to my git

Re: GSoC - Customizable print formats

On Tue, May 12, 2015 at 11:24 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 7 May 2015 at 09:28, Lubomir I. Ivanov neolit...@gmail.com wrote: Dirk and others, what do you think - should we make this new library dependency (Grantlee) optional like we do with Marble? Should the

Re: GSoC - Customizable print formats

Hello Lubomir, I think you have suggested before that I should find a way to remove all the existing printing code and replace it with the new Grantlee based printing, also you have suggested to use 'NEW_PRINTING' as a preprocessor. So now I am not sure if the old printing module will be

Prototype for customizable printing support.

test this and tell me what do you think? -- regards, Gehad From d274d487dd500d50788517fd42787937c18398cd Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Wed, 15 Apr 2015 21:00:19 +0200 Subject: [PATCH 1/9] Create two dives per page grantlee template Signed-off-by: Gehad

[PATCH] Manual added dives edit button is missing

I attached a patch that fixes #847 -- regards, Gehad From e0baa156970a606f8d2de1ea1c7b39e0a45b30a7 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Wed, 25 Mar 2015 16:07:42 +0200 Subject: [PATCH] Manual added dives edit button is missing once the manual added dive

[PATCH] HTML: don't collapse the dive if hyperlink is clicked

The attached patch fixes #713 -- regards, Gehad From 1cf50c4d578722a8589283582a4beef3c72bde9e Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Wed, 25 Mar 2015 01:23:23 +0200 Subject: [PATCH] HTML: don't collapse the dive if hyperlink is clicked fixes the wrong

Re: Customizable Print Formats GSoC 2015

On Fri, Mar 20, 2015 at 5:59 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 20 March 2015 at 17:06, Gehad Elrobey gehadelro...@gmail.com wrote: On Fri, Mar 20, 2015 at 2:43 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2015 at 23:22, Gehad Elrobey gehadelro...@gmail.com

Re: Customizable Print Formats GSoC 2015

On Fri, Mar 20, 2015 at 2:43 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 18 March 2015 at 23:22, Gehad Elrobey gehadelro...@gmail.com wrote: Hello Lubomir, I am attaching a draft of my proposal in pdf format, Please review it. your feedback is most welcome :) Gehad, your application

Re: Customizable Print Formats GSoC 2015

On Tue, Mar 10, 2015 at 1:20 AM, Long, Martin mar...@longhome.co.uk wrote: I've only really scanned this thread, so please excuse me if I'm raising something that's already been covered. It seems we're talking about rendering using HTML along with a few other things. Have we considered

[PATCH 2/2] HTML: Report start cylinder pressure correctly.

Fix start pressure cylinder values. -- regards, Gehad From 8a211da68dabdbccb856f60b68d96558d81d Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Tue, 10 Mar 2015 02:05:28 +0200 Subject: [PATCH 2/2] HTML: Report start cylinder pressure correctly. Report start

Re: Customizable Print Formats GSoC 2015

wrote: On 8 March 2015 at 00:23, Gehad Elrobey gehadelro...@gmail.com wrote: On Sun, Mar 8, 2015 at 12:11 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 7 March 2015 at 23:47, Lubomir I. Ivanov neolit...@gmail.com wrote: one thing to figure out is how are we going to embed

Re: Customizable Print Formats GSoC 2015

On Sun, Mar 8, 2015 at 12:11 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 7 March 2015 at 23:47, Lubomir I. Ivanov neolit...@gmail.com wrote: one thing to figure out is how are we going to embed the profile pictures... if we are capturing the output of a QWebPage then we first need

Re: Customizable Print Formats GSoC 2015

On Thu, Mar 5, 2015 at 6:55 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 March 2015 at 16:31, Tomaz Canabrava tcanabr...@kde.org wrote: On Wed, Mar 4, 2015 at 11:14 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 March 2015 at 16:05, Tomaz Canabrava tcanabr...@kde.org

Re: Customizable Print Formats GSoC 2015

On Wed, Mar 4, 2015 at 4:14 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 4 March 2015 at 16:05, Tomaz Canabrava tcanabr...@kde.org wrote: also, i don't understand Tomaz' idea about the Grantlee extension, so perhaps we need to investigate into that as well. it probably uses

Re: Customizable Print Formats GSoC 2015

On Tue, Mar 3, 2015 at 2:05 PM, Lubomir I. Ivanov neolit...@gmail.com wrote: On 3 March 2015 at 01:10, Gehad Elrobey gehadelro...@gmail.com wrote: Hi, As Subsurface became a mentoring organization in GSoC '15 so I am willing to join this year under Subsurface organization. I am

[PATCH] Show notification message while logs are converted to v2

I attached two patches, one to show notification while converting xml logs to v2. and the other to add the maximum dive data to the dive view. -- regards, Gehad From f5a34cc3fdcdbdfc0234a99a27f0f3a4068500c4 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Sat, 28 Feb

Notification Patches.

which handles the errors and updates. Dirk, Please review the code and tell me what do you think. I attached the patches. -- regards, Gehad From 15b3bb2972654a3cfe495552951de46fc1c05992 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 27 Feb 2015 03:07:25 +0200

Re: Fixing HTML export

On Tue, Feb 24, 2015 at 9:04 PM, Willem Ferguson willemfergu...@zoology.up.ac.za wrote: Dear Gehad, I have a few requests about the HTML export that I would appreciate if you would be prepared to check out?? First terminology. The HTML export has three way of looking at dives: a) List

Re: 4.4.1

___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface -- regards, Gehad From e7d9c041cfa652c0cd6d9579cf09525d73ec69ce Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Wed, 18 Feb 2015 01

Re: HTML Export. Broken character encoding in statistics

The translated text must be HTML quoted before exporting. I ll send a patch to fix this. On Thu, Feb 12, 2015 at 11:35 AM, Sergey Starosek sergey-staro...@yandex.ru wrote: It seems that Total time column values are twice UTF-encoded. The suspicious code is at

[PATCH 2/2] HTML: Fix Null values in yearly statistics export.

Null values should be handeled nicely instead of showing NULL or Nan. Signed-off-by: Gehad elrobey gehadelro...@gmail.com --- qt-ui/divelogexportdialog.cpp | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/qt-ui/divelogexportdialog.cpp b/qt-ui/divelogexportdialog.cpp

[PATCH] HTML: add Depth and Duration data to the dive list view.

This patch adds the more important fields (depth, duration) to the list view. this was recommended by Willem and also Fixes #725. Regards, Gehad From e1260f0a4d5e9b82c7f998acf3be56e80bf2a238 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 6 Feb 2015 10:32:45 +0200

Re: [PATCH] Export the XSLT based exports in a new Thread.

the exporting status to the status bar Main error message widget but I don't know if this breaks the convention as this bar is expected to be for errors only? regards, Gehad On Sat, Jan 31, 2015 at 2:59 AM, Dirk Hohndel d...@hohndel.org wrote: On Fri, Jan 30, 2015 at 10:45:28PM +0200, Gehad

[PATCH] Export the XSLT based exports in a new Thread.

0375852abd694fbd988f8253d77d58e7bc528d45 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 30 Jan 2015 21:42:33 +0200 Subject: [PATCH] Export the XSLT based exports in a new Thread. The XSLT based exports can consume long time while applying the xml format. this time can make the GUI unresponsive

[PATCH] Don't go to edit mode if the dive notes field didn't change.

The main-tab view is inconsistent as mentioned in #804, this patch fixes the notes view. Regards, Gehad From b86ac5633ce73ab22a600ff3986dcfc2dfe8d63c Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 30 Jan 2015 22:27:16 +0200 Subject: [PATCH] Don't go to edit mode

Re: [PATCH] Fix inconsistent search result in HTML export

Dirk, I think you have missed this patch, this patch fixes ticket #723 on the trac. Regards, Gehad On Fri, Oct 31, 2014 at 3:06 AM, Gehad Elrobey gehadelro...@gmail.com wrote: Patch is attached to fix some inconsistency in HTML exports search. From 7da7578385511e516a6010e1186f3542ed0ca1d2

[PATCH] Fix inconsistent search result in HTML export

Patch is attached to fix some inconsistency in HTML exports search. From 7da7578385511e516a6010e1186f3542ed0ca1d2 Mon Sep 17 00:00:00 2001 From: Gehad elrobey gehadelro...@gmail.com Date: Fri, 31 Oct 2014 02:50:17 +0200 Subject: [PATCH] Fix inconsistent search result in HTML export The advanced