Re: count down to Beta 1 - Android app

2015-09-02 Thread Grace Karanja
‎Hi Joakim, I intended the log feature to display some sort of application log. I guess if the name has some confusion we can change it. Meanwhile I will look at the other comments regarding the dive details view. Sent from my phone.   Original Message   From: Joakim Bygdell‎ Had a spin with

Re: Add Dive issue

2015-08-19 Thread Grace Karanja
On Tue, Aug 18, 2015 at 9:51 PM, Tomaz Canabrava tcanabr...@kde.org wrote: On Tue, Aug 18, 2015 at 4:25 AM, Grace Karanja gracie.karanj...@gmail.com wrote: Hi Tomaz, I am a bit stuck here: Check my code here: https://github.com/gracie89/subsurface/tree/devel/qt-mobile When the user

Re: at some point we need to release Subsurface 4.5

2015-08-18 Thread Grace Karanja
On Tue, Aug 18, 2015 at 10:38 PM, Salvador Cuñat salvador.cu...@gmail.com wrote: Sadly, the app doesn't work for me at all (latest dailies, first did). I only get the blue screen with the Subsurface mobile bar and the status bar with subsurface mobile startup. Don't know if it's due to a

Re: GSoC Status: Android Port

2015-08-13 Thread Grace Karanja
Hi, Gehad On Thu, Aug 13, 2015 at 2:39 PM, Gehad Elrobey gehadelro...@gmail.com wrote: I can't build subsurface for android, is there a daily build for android? Should be here: http://subsurface-divelog.org/downloads/daily/ -- Grace K ___

Re: [PATCH] make the top bars look the same.

2015-07-30 Thread Grace Karanja
Hi, On Thu, Jul 30, 2015 at 5:33 PM, David da...@acmelabs.co.uk wrote: On 30 July 2015, Joakim Bygdell j.bygd...@gmail.com wrote: We could place a return button at top left and a save return at bottom right. That way they are clearly separated both in position and in action.

Re: [PATCH] start making the android app more mobile friendly.

2015-07-27 Thread Grace Karanja
On Mon, Jul 27, 2015 at 7:56 AM, Steve stevewilli...@internode.on.net wrote: Just FYI on a Samsung S4 4.3 I cannot get to the menu by pressing the usual menu key (or any other way I can think of). Hi, I will get a device with a menu key and test/implement this. Ideally pressing the menu key

GSoC Status Update - Android Port (Week 7)

2015-07-13 Thread Grace Karanja
Hi all, Last week, I continued my work on the dive profile. After numerous trials and some discussions with Tomaz, we settled on using a QQuickPaintedItem to render the profile to QML, I am still finishing on that, and we will have a PR ready this week. Dirk and Anton have also put a lot of

Re: Week 6 GSoC Progress Update (Android Port)

2015-07-06 Thread Grace Karanja
On Mon, Jul 6, 2015 at 1:51 AM, Dirk Hohndel d...@hohndel.org wrote: Hi Grace On Sun, Jul 05, 2015 at 11:00:31PM +0300, Grace Karanja wrote: This week, I managed the following:- - Adding a preferences dialog for the user to store cloud credentials. - Loading dives/Saving them

Week 6 GSoC Progress Update (Android Port)

2015-07-05 Thread Grace Karanja
Hello everyone,This week, I managed the following:-- Adding a preferences dialog for the user to store cloud credentials.- Loading dives/Saving them to the cloud.- Displaying the dive profile in QML.This coming week, I will :-- Finish working on the dive profileand- Spend time on improving Android

Re: GSoC Status - Week 5 (Android Port)

2015-06-29 Thread Grace Karanja
On Mon, Jun 29, 2015 at 5:02 PM, Dirk Hohndel d...@hohndel.org wrote: On Mon, Jun 29, 2015 at 06:01:54AM +0300, Grace Karanja wrote: Hi everyone, This week I was working on: -Saving the dive details to XML This surprises me - maybe I'm not understanding what you are doing there. Can

GSoC Status - Week 5 (Android Port)

2015-06-28 Thread Grace Karanja
Hi everyone, This week I was working on: -Saving the dive details to XML -Loading and saving dives using the cloud back-end. I am currently still working on the back-end part, and I should have the work ready for a PR this week. -- Grace K ___

GSoC Status - Week 4 (Android Port)

2015-06-21 Thread Grace Karanja
Hello everyone, I did some more additions to the DiveListModel class, and also enhanced the way the dive appears on the QML page. We are now able to preview more details on tapping of a dive. All of the work done so far is now available in the latest master, and the mobile version can be built

Re: GSoC Status - Week 3 (Android Port)

2015-06-21 Thread Grace Karanja
On Sun, Jun 21, 2015 at 12:53 AM, Dirk Hohndel d...@hohndel.org wrote: On Thu, Jun 18, 2015 at 06:26:51PM +0300, Grace Karanja wrote: On Sun, Jun 14, 2015 at 11:55 PM, Tomaz Canabrava tcanabr...@kde.org wrote: Grace, always do a rebase from master so your work is not hard to merge

Re: GSoC Status - Week 3 (Android Port)

2015-06-18 Thread Grace Karanja
with -DSUBSURFACE_MOBILE=True. This will result in a subsurface-mobile executable. -- -- Grace K From faf064b4b7e8b7b931e84ff2f3995a5169e1ac61 Mon Sep 17 00:00:00 2001 From: Grace Karanja gracie.karanj...@gmail.com Date: Thu, 18 Jun 2015 09:13:30 +0300 Subject: [PATCH 21/22] Display more details Show

GSoC Status - Week 3 (Android Port)

2015-06-14 Thread Grace Karanja
Hello everyone, This past week, I managed to: - - Enhance the displaying of the dive log, grouped in trips - Add the ability to tap on a dive and display some basic details. Now I am focussing on adding more details to the dive info page and also the ability to edit and save dive details.

GSoC Status - Week 2 (Android Port)

2015-06-07 Thread Grace Karanja
Hello, So for the second week, I focused on: - Adding a TripList and DiveList class to the qt-models folder. These classes contain models that will be used in the model app to display trips and dives. - Adding a menu in the QML app to fire a FileOpen dialog and select a file from the

GSoC Status - Week 1 (Android port)

2015-05-30 Thread Grace Karanja
Hi everyone,This past week, I started working on the Subsurface Android port. These are the achievementsso far:-- I added a CMake flag for building the mobile version. By adding -SUBSURFACE_MOBILE=Trueto ‎the CMake call, the resulting binary will be subsurface-mobile.- Created a new folder for

GSoC Project - Android Port

2015-04-28 Thread Grace Karanja
Hello team, I have been chosen to work on the Subsurface Android port for GSoC, and my mentor will be Tomaz. I would like to thank the Subsurface mentors for giving me a chance to work on this project this summer. As the project progresses, I will be submitting patches as I go along, for which

[PATCH] Consistent variable names in UndoCommands class

2015-03-16 Thread Grace Karanja
Implements a uniform variable naming scheme in the undocommands class. Signed-off-by: Grace Karanja gracie.karanj...@gmail.com --- qt-ui/undocommands.cpp | 35 +-- qt-ui/undocommands.h | 8 2 files changed, 21 insertions(+), 22 deletions(-) diff --git

Re: Request For Comments - Undo/Redo framework

2015-03-12 Thread Grace Karanja
Hello, Dirk, On Thu, Mar 12, 2015 at 5:53 PM, Dirk Hohndel d...@hohndel.org wrote: Can you look through these comments, Grace? Thanks for your comments. I have gone through all these comments, and will go through the code and come up with a better naming scheme, and implement suggested

Re: Request For Comments - Undo/Redo framework

2015-03-12 Thread Grace Karanja
On Tue, Mar 10, 2015 at 11:08 PM, Grace Karanja gracie.karanj...@gmail.com wrote: On Mon, Mar 9, 2015 at 2:51 PM, Grace Karanja gracie.karanj...@gmail.com wrote: See the attached patch, which implements undo/redo of when merging dives. The next attached patch implements undo/redo when

Re: Request For Comments - Undo/Redo framework

2015-02-27 Thread Grace Karanja
On Thu, Feb 26, 2015 at 8:11 PM, Dirk Hohndel d...@hohndel.org wrote: Hi Grace... Would you mind redoing / resubmitting the patch? Attached is the corrected patch. Thanks /D From aa416922cb0b9a25fe2a02ef96576752645db4c9 Mon Sep 17 00:00:00 2001 From: Grace Karanja gracie.karanj

Re: Request For Comments - Undo/Redo framework

2015-02-24 Thread Grace Karanja
On Sun, Feb 15, 2015 at 6:54 PM, Grace Karanja gracie.karanj...@gmail.com wrote: On Sun, Feb 15, 2015 at 3:09 AM, Dirk Hohndel d...@hohndel.org wrote: Hi Grace... Thanks. Some comments below... This new patch enables undoing of renumbered dives. From

Re: Request For Comments - Undo/Redo framework

2015-02-14 Thread Grace Karanja
undo for time shifts in dives. From 0e3102fa9631551cd7f4dd4a74159685a157eab5 Mon Sep 17 00:00:00 2001 From: Grace Karanja gracie.karanj...@gmail.com Date: Sat, 14 Feb 2015 20:12:05 +0300 Subject: [PATCH] Add ability to undo shifting of dive time Adds the ability to undo shifting of dive times

Re: Request For Comments - Undo/Redo framework

2015-02-11 Thread Grace Karanja
___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface From 120be3981901e8fef6d9291ec3c93b9ad989afe1 Mon Sep 17 00:00:00 2001 From: Grace Karanja gracie.karanj...@gmail.com Date

Re: Request For Comments - Undo/Redo framework

2015-02-10 Thread Grace Karanja
Hello, On Tue, Feb 10, 2015 at 7:32 PM, Tomaz Canabrava tcanabr...@kde.org wrote: I never used Undo / Redo framework before, but why didn't you used the QUndoGroup / QUndoCommand / QUndoStack classes and created your own? I have only been reading about the QUndoFramework a day or two ago. I

Re: Request For Comments - Undo/Redo framework

2015-02-10 Thread Grace Karanja
Hi Dirk, On Tue, Feb 10, 2015 at 8:12 AM, Dirk Hohndel d...@hohndel.org wrote: sorry it took me so long to respond. Today was just crazy... Thank you for your response. Thanks for working on that - it's one of those things that I've wanted for a long time and never managed to focus on.

Request For Comments - Undo/Redo framework

2015-02-09 Thread Grace Karanja
! - Grace K. From b3e44d087bd4ce4e92e9a9beed8230eeb4d1fbbd Mon Sep 17 00:00:00 2001 From: Grace Karanja gracie.karanj...@gmail.com Date: Mon, 9 Feb 2015 09:44:10 +0100 Subject: [PATCH 4/4] Add ability to undo deleted dives Before the dive is deleted, a copy is made and passed to the undo buffer. When edit