Re: Any brave dive computer download testers out there?

file. Jeremie 2018-04-20 23:10 GMT+07:00 Murillo Bernardes <mfbernar...@gmail.com>: > Successfully downloaded dives on a Mac from: > - Oceanic OCi over USB > - Perdix AI over BLE > > Murillo Bernardes > > On Fri, Apr 20, 2018 at 1:05 PM, Jérémie Guichard <djebr..

Re: Any brave dive computer download testers out there?

Hey guys, Just tried this build on Windows 10: https://github.com/Subsurface-divelog/subsurface/releases/download/continuous-NG/subsurface-4.7.8-73-ga12ea13d51f5.exe With Scubapro G2 and Suunto Zoop over USB. Seems to work like a charm. Jeremie 2018-04-20 9:56 GMT+07:00 Matt Thompson

Re: Documenting coding conventions for new comers.

Ok, I'll create the new section in CodingStyle. What about converting this file (CodingStyle) to markdown format? 2018-04-09 16:44 GMT+02:00 Dirk Hohndel : > > On Apr 9, 2018, at 3:26 AM, Miika Turkia wrote: > >> >> To cope with this I've prepared a

Documenting coding conventions for new comers.

Hi everybody, It is not easy for new comers to know about conventions and best practices to be followed when contributing to Subsurface. This creates overhead for new comers and code maintainers. New comers have to extensively browse the code to find utility functions (or end up re-implement

Re: Map issue with release 4.7.8 under windows 10

:00 Lubomir I. Ivanov <neolit...@gmail.com>: > On 5 April 2018 at 21:02, Jérémie Guichard <jeremie.guich...@gmail.com> > wrote: > > Hi guys, > > > > I just installed latest 4.7.8 release on windows 10 machine, seems there > is > > an issue with ma

Map issue with release 4.7.8 under windows 10

Hi guys, I just installed latest 4.7.8 release on windows 10 machine, seems there is an issue with map rendering. Has anybody seen the map working in windows with 4.7.8? For me Subsurface starts but no map get displayed, running from console with - v -v I get: Subsurface v4.7.8, built with

Re: Formatting Dive tags string

Hello Thiago, In order to not mix the two topics in the same change, I decided to keep the conversion to QString as it was in the original code, see: https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L574

Re: Formatting Dive tags string

Here is the pull request :) https://github.com/Subsurface-divelog/subsurface/pull/1187 2018-04-04 14:35 GMT+02:00 Lubomir I. Ivanov <neolit...@gmail.com>: > On 4 April 2018 at 14:27, Lubomir I. Ivanov <neolit...@gmail.com> wrote: > > On 4 April 2018 at 12:36, Jérémie Guichar

Formatting Dive tags string

Hello everybody, While reviewing this change adding display for Tags in dive list view ( https://github.com/Subsurface-divelog/subsurface/pull/1184), Lubomir and Dirk raised a concern regarding tag text that can exceed inputted buffer size. Issue comes from implementation/signature of

Re: error when saving information on the cloud

Hey Davide, Could you run subsurface from command line with logging command line options and send us what you get there? If on windows: subsurface.exe --win32console -v -v Otherwise: subsurface -v -v Thanks, Jeremie 2017-03-24 19:42 GMT+07:00 Davide DB : > Hi guys, > >

Re: Automatic tests - a few general questions

Hey Stefan, The rules you mentioned do add tests, but not as part of the build itself, there is a different target called "check" that can be used to run the tests. Up to recently, some tests were failing under windows, this is why the mxe build script did no enable them. Tests are now passing; I

Re: [PATCH] Planner: ascent and descent rates should be rounded rather than truncated

Pull request ready :) https://github.com/Subsurface-divelog/subsurface/pull/254 2017-03-14 2:00 GMT+07:00 Linus Torvalds <torva...@linux-foundation.org>: > On Mon, Mar 13, 2017 at 11:29 AM, Jérémie Guichard <djebr...@gmail.com> > wrote: > > > > Looking into tha

Re: [PATCH] Planner: ascent and descent rates should be rounded rather than truncated

Ho! I didn't realized I used the -Wfloat-conversion on C code only and not C++ when I did my previous round of float/double to int patch! Looking into that now. There is a bunch of new warnings adding the flag but seems (at first look) to be managable. Working on the patch right now...

Re: Android App

Made a fast walk through, did not find anything significant... 2017-03-12 14:19 GMT+07:00 Anton Lundin : > On 11 March, 2017 - Dirk Hohndel wrote: > > > I would like to update the app. It would be nice if a few people could > try the new Subsurface-mobile that's available in

Re: Several float to int potential rounding errors/inconsistencies

at all, but if nobody has time to look into preparing the env for mxe build and wine test I could look into that. Best regards, Jeremie 2017-03-08 21:34 GMT+07:00 Dirk Hohndel <d...@hohndel.org>: > On Wed, Mar 08, 2017 at 02:42:28PM +0700, Jérémie Guichard wrote: > > > >

Re: DM5 Data structure changes

Hello Max, I guess the easiest would be to look at the dm4_dive and dm5_dive functions in subsurface core/parse-xml.c file https://github.com/Subsurface-divelog/subsurface/blob/master/core/parse-xml.c Good reading, Jeremie 2017-03-09 16:27 GMT+07:00 Max Lindqvist : > Hi, >

Re: Several float to int potential rounding errors/inconsistencies

e will now pass on Windows too, we now only have TestPreference failing! Getting there :) Best regards, Jérémie 2017-03-08 9:21 GMT+07:00 Jérémie Guichard <djebr...@gmail.com>: > I'm looking into that right now :) > > 2017-03-08 7:18 GMT+07:00 Dirk Hohndel <d...@hohndel.org>:

Re: Several float to int potential rounding errors/inconsistencies

I'm looking into that right now :) 2017-03-08 7:18 GMT+07:00 Dirk Hohndel : > On Tue, Mar 07, 2017 at 09:43:06AM -0800, Linus Torvalds wrote: > > On Tue, Mar 7, 2017 at 9:20 AM, Lubomir I. Ivanov > wrote: > > > > > > lrint() seems to build for me with

Several float to int potential rounding errors/inconsistencies

Good morning/afternoon/evening all, I've been lately trying to get subsurface tests to pass under windows. In the current state, TestParse and TestPreferences are the two ones still failing... In short, the error raised by TestParse is caused by a rounding error when converting dm4 sample depth

Re: Subsurface-Mobile download from dive computer

Hello guys, I was lately thinking that being able to load dives from dive computer directly to mobile app would be a great addition. I already use an OTG cable to plug thumb or hard drives to my mobile when I want to back things up without PC or fast internet connection. My guess is that it could

Re: Open / Save to cloud on Windows 10

Hi guys, Pull request sent (https://github.com/Subsurface-divelog/subsurface/pull/222 ) Sorry for the late reply, these days were quite busy with a bit of coding but mainly with my Instructor Training Course :) Based on your recommendations I've added a subsurface_stat portability function.

Re: Open / Save to cloud on Windows 10

the main reason is that most developer do not want to install a win VM to check their code do build there :) Cheers, Jeremie 2017-02-19 23:24 GMT+07:00 Dirk Hohndel <d...@hohndel.org>: > On Sun, Feb 19, 2017 at 05:32:15PM +0700, Jérémie Guichard wrote: > > > > Computer is Suunto

Open / Save to cloud on Windows 10

or windows but did not succeed...) Cheers, Jeremie 2017-02-19 14:41 GMT+07:00 Dirk Hohndel <d...@hohndel.org>: > On Sun, Feb 19, 2017 at 02:05:18PM +0700, Jérémie Guichard wrote: > > Hi guys, > > > > First of all, I'd like to thank you all for the job well