Re: [PATCH] Add native Bluetooth support for Windows platforms

2015-08-24 Thread Dirk Hohndel
On Mon, Aug 24, 2015 at 11:20:29AM +0300, Claudiu Olteanu wrote: Sorry for the late response but I didn't have access to Internet for the last three days. Thiago, thanks again for the review. I saw that the patches are now in the upstream. Dirk, if you think that it is necessary I can

Re: [PATCH] Add native Bluetooth support for Windows platforms

2015-08-24 Thread Claudiu Olteanu
Sorry for the late response but I didn't have access to Internet for the last three days. Thiago, thanks again for the review. I saw that the patches are now in the upstream. Dirk, if you think that it is necessary I can send you another patch using the WSAStringToAddressW (like Thiago

Re: [PATCH] Add native Bluetooth support for Windows platforms

2015-08-21 Thread Lubomir I. Ivanov
hello, chiming in for a couple of comments. On 21 August 2015 at 07:22, Thiago Macieira thi...@macieira.org wrote: On Wednesday 19 August 2015 00:57:20 Claudiu Olteanu wrote: snip I tried as well to replace the WSAStringToAddressA with WSAStringToAddressW but I had to represent the

Re: [PATCH] Add native Bluetooth support for Windows platforms

2015-08-20 Thread Thiago Macieira
On Wednesday 19 August 2015 00:57:20 Claudiu Olteanu wrote: Hi there, As I promised, I created a new set of patches. You can find it attached to this e-mail. Here is a list with the changes I did after the feedback: - initialized the internal variables (patch 06) Thanks! - moved the

[PATCH] Add native Bluetooth support for Windows platforms

2015-08-18 Thread Claudiu Olteanu
Hi there, As I promised, I created a new set of patches. You can find it attached to this e-mail. Here is a list with the changes I did after the feedback: - initialized the internal variables (patch 06) - moved the *WSACleanup* call from patch 06 to patch 12 - removed the implementation of my

Re: [PATCH] Add native Bluetooth support for Windows platforms

2015-08-18 Thread Thiago Macieira
On Wednesday 19 August 2015 00:57:20 Claudiu Olteanu wrote: I tried as well to replace the WSAStringToAddressA with WSAStringToAddressW but I had to represent the address as a wchar_t* and and when I wanted to use mbstowcs_s for conversion (from const char* to wchar_t*) the compiler couldn't