On Sun, Jul 19, 2015 at 11:25:17PM +0300, Claudiu Olteanu wrote:
Child QObjects don't need to be cleaned. But I'm not seeing any
parent-child
relationship here.
I'm deferring to you here. I'm just pointing out, I haven't done any
investigation.
Would you like me to?
I don't
So I pushed these patches and learned that they require at least Qt5.3 as
QBluetoothDeviceDiscoveryAgent::InvalidBluetoothAdapterError isn't defined
yet in Qt5.2.
But that got me thinking - what is actually the reasonable minimum version
for QtBluetooth support to be enabled in Subsurface builds?
In general the mentor is not necessarily the clean up person...
I know, Thiago offered, but just to put this out here.
When I said that he should do some investigations I didn't mean
to start hunting memory leaks on my code. I can do that by myself
using their best friend - Valgring :). I
On Monday 20 July 2015 06:59:30 Dirk Hohndel wrote:
So I pushed these patches and learned that they require at least Qt5.3 as
QBluetoothDeviceDiscoveryAgent::InvalidBluetoothAdapterError isn't defined
yet in Qt5.2.
But that got me thinking - what is actually the reasonable minimum version
Hi,
I agree with Thiago. Probably it is a good idea to keep the Bluetooth
download feature only for versions = 5.4. This is due the fact that in
version 5.4 they added support for BlueZ 5.X stack and probably most
of the users have this stack.
To be honest I didn't take into account to test the
On Mon, Jul 20, 2015 at 07:59:15PM +0300, Claudiu Olteanu wrote:
Hi,
I agree with Thiago. Probably it is a good idea to keep the Bluetooth
download feature only for versions = 5.4. This is due the fact that in
version 5.4 they added support for BlueZ 5.X stack and probably most
of the users
Hi Claudiu,
I tested your patches, but haven't looked at the code or commits.
On 19 July 2015 at 06:55, Claudiu Olteanu
olteanu.vasilica.clau...@gmail.com wrote:
Hi there,
I attached some patches which should improve the user experience
when the Bluetooth download mode is enabled.
The
Hi Claudiu,
On 19 July 2015 at 20:50, Claudiu Olteanu
olteanu.vasilica.clau...@gmail.com wrote:
Hi Rick,
I can select my usb bluetooth dongle (using the one that came with my
petrel), and power it up or down, but I was not able to pair or unpair
(when previously paired using the onboard
Thanks for the info, Rick!
Did you tried to download the dives after you paired the devices
manually (using bluetoothctl)?
Currently the QtBluetooth library doesn't have an agent which
can be used to set a custom PIN code on pairing step [1]. I don't
know when they will implement it. The pairing
Hi Rick,
I can select my usb bluetooth dongle (using the one that came with my
petrel), and power it up or down, but I was not able to pair or unpair
(when previously paired using the onboard bluetooth). Downloading fails
with the usb dongle, even when it had already been paired. It didn't
On 19 July 2015 at 22:06, Claudiu Olteanu
olteanu.vasilica.clau...@gmail.com wrote:
Thanks for the info, Rick!
Did you tried to download the dives after you paired the devices
manually (using bluetoothctl)?
I didn't think to try that before. But I just tried and it worked.
Currently
I didn't think to try that before. But I just tried and it worked.
Great to hear that :).
That's annoying. Thankfully, most systems have a reasonably friendly way
to pair bluetooth devices, and it only needs to be done once. Can you
detect if pairing fails, and ask the user to pair the
On Sunday 19 July 2015 23:25:17 Claudiu Olteanu wrote:
I saw that Q_OS_MAC doesn't include the open source version and I didn't
know which is that :).
Huh?
I didn't look over the implementation. I just read the description from
here[1] and it is mentioned something about an open source
Child QObjects don't need to be cleaned. But I'm not seeing any
parent-child
relationship here.
I'm deferring to you here. I'm just pointing out, I haven't done any
investigation.
Would you like me to?
I don't have too much experience with C++ and Qt framework. If you
have time, it
On Saturday 18 July 2015 23:55:35 Claudiu Olteanu wrote:
Subject: [PATCH 3/8] Don't block the save button for Bluetooth device
selection
After commit #69a75fed05fc3 we don't need to block the save
Dirk, please remember to update the commit SHA-1 after you cherry-pick patch 1
:-)
Claudiu, most people only have one local bluetooth device. We shouldn't
display a list to select an entry if there's only one entry to be selected.
Can you hide the list if the list contains only one?
Of course I can do. One of the attached patches (#0009) should do the trick.
Where is
On Sunday 19 July 2015 22:23:46 Claudiu Olteanu wrote:
Claudiu, most people only have one local bluetooth device. We shouldn't
display a list to select an entry if there's only one entry to be
selected.
Can you hide the list if the list contains only one?
Of course I can do. One of the
Hi there,
I attached some patches which should improve the user experience
when the Bluetooth download mode is enabled.
The first patch should stop the device discovery agent when the
user press the Save/Cancel button. In this way we don't need the
modifications from commit #94d3aa04dccc3 . I
18 matches
Mail list logo
