Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 17 May 2017 at 21:56, Davide DB wrote: > I uploaded a zip containing 54 eccr dives obtained via dctool from a > JJ Petrel controller. > > https://drive.google.com/open?id=0B1RlIJJRLXsHX3JrcXllUXhDTmM > > All dives use 0,7 and 1,2 as setpoints. Another batch of 24 eccr

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

I uploaded a zip containing 54 eccr dives obtained via dctool from a JJ Petrel controller. https://drive.google.com/open?id=0B1RlIJJRLXsHX3JrcXllUXhDTmM All dives use 0,7 and 1,2 as setpoints. I hope they could be useful for testing this and future features. Just keep them for future reference.

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 11-05-17 14:37, Anton Lundin wrote: On 11 May, 2017 - Jef Driesen wrote: I replaced your patch with your latest version, and updated the rest of the series. Please have a look. If you are okay with the changes, I'll merge them to master. LGTM. You can add my Reviewed-by: Anton Lundin

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 11 May 2017 at 16:44, Jef Driesen wrote: > > There is no need to send me the other dives. I already managed to extract > them from the log file. I just need to know which dives I should take look The most recent 5 dives are all mCCR with a setpoint of 0,7 Then jump

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-05-11 14:20, Davide DB wrote: Ok so I made a mistake. I thought 21 was most recent. I even look carefully at the log trying to see if there was some reference. You can use dctool to parse those raw dive files: ./dctool -f petrel parse -o dive.X.xml dive.X.bin And then you can easily

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 11 May, 2017 - Jef Driesen wrote: > On 2017-05-10 15:43, Anton Lundin wrote: > >>>That said, I think setpoint values are still interesting to see, to > >>>validate how well the controller did manage to try to keep the o2 close > >>>to the setpoint. > >> > >>After looking at the data, I had the

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

Ok so I made a mistake. I thought 21 was most recent. I even look carefully at the log trying to see if there was some reference. I'm out at the office now. I will send you everything again later in the afternoon off list. The dives you have now are a mess because they are logs of early training

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-05-10 22:16, Davide DB wrote: I downloaded dives from my SF2 Petrel controller via dctool. I attached some of them here. Dives: 17, 18, 19, 20, 21 are mCCR with a setpoint of 0,7 Dive 15 is eCCR with setpoints of 0,7 and 1,3. It was a training dive so you will find OC parts (bailout

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-05-10 15:43, Anton Lundin wrote: >That said, I think setpoint values are still interesting to see, to >validate how well the controller did manage to try to keep the o2 close >to the setpoint. After looking at the data, I had the impression that the setpoint value is "unused" because it

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

10 May 2017 at 15:47, Anton Lundin wrote: > On 10 May, 2017 - Joakim Bygdell wrote: > > > On 10 May 2017 at 11:33, Anton Lundin wrote: > > > > > Do we have any data from a Shearwater running as solenoid controller? > > > > I have data from a JJ in eCCr

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May 2017 at 15:47, Anton Lundin wrote: > > Anyway, looking at the data would be interesting, trying to figure out > if there is any bits there disclosing that the computer was running in a > controller mode, and if there are any bits there saying when it fired > the

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

Original message From: Jef Driesen <j...@libdivecomputer.org> Date:10/05/2017 21:37 (GMT+09:30) To: Anton Lundin <gla...@acc.umu.se> Cc: Subsurface <subsurface@subsurface-divelog.org> Subject: Re: [PATCH] Visualisation of individual oxygen sensor data for CCR di

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May, 2017 - Joakim Bygdell wrote: > On 10 May 2017 at 11:33, Anton Lundin wrote: > > > Do we have any data from a Shearwater running as solenoid controller? > > I have data from a JJ in eCCr mode. > There is no sensor data in that log, only setpoint information at the >

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May, 2017 - Jef Driesen wrote: > On 2017-05-10 11:33, Anton Lundin wrote: > >On 10 May, 2017 - Jef Driesen wrote: > >>I've implemented the scaling factor now. See attached set of > >>patches. It took me a bit longer than expected because there were a > >>few cases where the ppO2 still ended

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May 2017 at 14:33, Joakim Bygdell wrote: > > I have seen similar things on data from mCCRs, fixed setpoint and variable > sensor data, the setpoint of 0.7 seems to be some sort of default value on > shearwaters DCs. > When the DC is used only as a visual reference of

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May 2017 at 14:07, Jef Driesen wrote: > On 2017-05-10 11:33, Anton Lundin wrote: > >> On 10 May, 2017 - Jef Driesen wrote: >> >>> I've implemented the scaling factor now. See attached set of >>> patches. It took me a bit longer than expected because there were a

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-05-10 11:33, Anton Lundin wrote: On 10 May, 2017 - Jef Driesen wrote: I've implemented the scaling factor now. See attached set of patches. It took me a bit longer than expected because there were a few cases where the ppO2 still ended up being zero. And that turned out to be for dives

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May 2017 at 11:33, Anton Lundin wrote: > On 10 May, 2017 - Jef Driesen wrote: > Do we have any data from a Shearwater running as solenoid controller? > > Ex. On the JJ-CCR's they use a Shearwater Petrel with sensors which > controls the o2 solenoid to try to get the

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May, 2017 - Anton Lundin wrote: > Attached is the last iteration I did of the sensors patch. It has some > minor differences from the one you included, but most of them isn't that > relevant. > > > The only relevant information is that the adc offset value is probably > in 0.025 mV as

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10 May, 2017 - Jef Driesen wrote: > On 2017-04-17 21:49, Jef Driesen wrote: > >On 14-04-17 22:04, Anton Lundin wrote: > >>On 14 April, 2017 - Jef Driesen wrote: > >> > >>>On 2017-04-13 17:04, Jef Driesen wrote: > >>>I tried a different approach yesterday. Instead of adding 1024 to > >>>the

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-17 21:49, Jef Driesen wrote: On 14-04-17 22:04, Anton Lundin wrote: On 14 April, 2017 - Jef Driesen wrote: On 2017-04-13 17:04, Jef Driesen wrote: I tried a different approach yesterday. Instead of adding 1024 to the calibration value, I simply used the stored value as is, and

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-17 22:34, Anton Lundin wrote: On 17 April, 2017 - Jef Driesen wrote: On 14-04-17 21:57, Anton Lundin wrote: >On 13 April, 2017 - Jef Driesen wrote: > >>On 2017-04-12 10:47, Anton Lundin wrote: >>> >>>The issue with current libdivecomputer DC_SAMPLE_PPO2 is that you cant

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 14-04-17 22:04, Anton Lundin wrote: On 14 April, 2017 - Jef Driesen wrote: On 2017-04-13 17:04, Jef Driesen wrote: I tried a different approach yesterday. Instead of adding 1024 to the calibration value, I simply used the stored value as is, and calculated the average ppO2 over all three

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 14-04-17 21:57, Anton Lundin wrote: On 13 April, 2017 - Jef Driesen wrote: On 2017-04-12 10:47, Anton Lundin wrote: The issue with current libdivecomputer DC_SAMPLE_PPO2 is that you cant distinguish between ha "real" "voted" pO2 and the raw sensor value. I would like to see a option to

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 14 April, 2017 - Jef Driesen wrote: > On 2017-04-13 17:04, Jef Driesen wrote: > I tried a different approach yesterday. Instead of adding 1024 to > the calibration value, I simply used the stored value as is, and > calculated the average ppO2 over all three sensors. Then I plotted > all those

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 13 April, 2017 - Jef Driesen wrote: > On 2017-04-12 10:47, Anton Lundin wrote: > > > >The issue with current libdivecomputer DC_SAMPLE_PPO2 is that you cant > >distinguish between ha "real" "voted" pO2 and the raw sensor value. > > > >I would like to see a option to export both, and be able to

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-13 17:04, Jef Driesen wrote: I don't entirely agree with that. If you check the available memory dumps, 5 of them contain CCR dives. I analyzed all of them, and this is what I found: * petrel.marklee.bin The three mV values in the samples are always zero. But since all three O2

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-12 10:47, Anton Lundin wrote: On 12 April, 2017 - Davide DB wrote: On 11 April 2017 at 23:44, Jef Driesen wrote: > I'll need to look again at the old discussion, but if I remember > correctly, your patch produced bogus results for some of the data I

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

For the Shearwater Petrel CCR divers reading this: Can you supply us with some more data to test against? The Petrel protocol doesn't support memory dumps, so you'll need to dump the individual dives. You can do that with libdivecomputer' dctool:

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 12 April, 2017 - Davide DB wrote: > On 11 April 2017 at 23:44, Jef Driesen wrote: > > > > > I'll need to look again at the old discussion, but if I remember > > correctly, your patch produced bogus results for some of the data I tested > > against. And that's why I

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 11 April 2017 at 23:44, Jef Driesen wrote: > > I'll need to look again at the old discussion, but if I remember > correctly, your patch produced bogus results for some of the data I tested > against. And that's why I wanted to double check with Shearwater. But so >

RE: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-09 14:00, Anton Lundin wrote: > On 09 April, 2017 - Joakim Bygdell wrote: >> Jef, how is on the backed side, how many sensors does libdivecomputer >> supports for the Petrel series? > > I sort if figured out now to extract po2 valeues for all sensors from > Shearwater comptuers, but

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 2017-04-09 14:00, Anton Lundin wrote: On 09 April, 2017 - Joakim Bygdell wrote: Jef, how is on the backed side, how many sensors does libdivecomputer supports for the Petrel series? I sort if figured out now to extract po2 valeues for all sensors from Shearwater comptuers, but due to it

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 09 April, 2017 - Joakim Bygdell wrote: > 9 April 2017 at 11:39, Joakim Bygdell wrote: > > > 9 April 2017 at 11:30, Davide DB wrote: > > > >> On 9 April 2017 at 11:22, Joakim Bygdell wrote: > >> > 9 April 2017 at 11:01, Davide

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

Hi Willem, Actually I downoaded the Sweetwater directly via BT with subsurface. I did not install Shearwater we at all. Data format conversion should be libdivecom related or subsurface. ___ subsurface mailing list subsurface@subsurface-divelog.org

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

Currently Subsurface only explicitly accommodates the Poseidon MKVI and the APD Inspiration family of rebreathers, having two/three oxygen sensors by default. The reason is simply: these are the equipment mostly used by local divers here. Since rebreathers often download only one dive at a

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

9 April 2017 at 11:39, Joakim Bygdell wrote: > 9 April 2017 at 11:30, Davide DB wrote: > >> On 9 April 2017 at 11:22, Joakim Bygdell wrote: >> > 9 April 2017 at 11:01, Davide DB wrote: >> >> >> >> I update my

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 9 April 2017 at 11:22, Joakim Bygdell wrote: > 9 April 2017 at 11:01, Davide DB wrote: >> >> > >> > Il 08 apr 2017 13:10, "Joakim Bygdell" ha scritto: >> >> >> >> >> >> Under Preferences -> Graph >> >> You have "Show individual

RE: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

> > Il 08 apr 2017 13:10, "Joakim Bygdell" ha scritto: >> >> >> Under Preferences -> Graph >> You have "Show individual O2 sensors when viewing pO2" >> >> Once you toggle the "show pO2" button on in the profile it should >> show data from all sensors. >> Assuming of course

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

> > Il 08 apr 2017 13:10, "Joakim Bygdell" ha scritto: >> >> >> Under Preferences -> Graph >> You have "Show individual O2 sensors when viewing pO2" >> >> Once you toggle the "show pO2" button on in the profile it should show >> data from all sensors. >> Assuming of course

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

Ouch! Thanks a lot Il 08 apr 2017 13:10, "Joakim Bygdell" ha scritto: > On 8 April 2017 at 12:35, Davide DB wrote: > >> On 12 January 2015 at 09:41, Willem Ferguson >> wrote: >> >> Sorry guys, really a bad day :) So I

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 8 April 2017 at 12:35, Davide DB wrote: > On 12 January 2015 at 09:41, Willem Ferguson > wrote: > > Sorry guys, really a bad day :) So I bring bag to life this old hot topic. > > As far I see there's no way to see individual 02 sensor

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 12 January 2015 at 09:41, Willem Ferguson wrote: > > On 10/01/2015 13:00, Anton Lundin wrote: >> >> >> I've never suggested to remove all the code and start over. I'm >> suggesting better goals to strive towards. >> >> We have discussed o2 sensor plotting on

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 10/01/2015 13:00, Anton Lundin wrote: I've never suggested to remove all the code and start over. I'm suggesting better goals to strive towards. We have discussed o2 sensor plotting on this mailinglist for 2-3 years, and everytime before we have come to the conclusion that plotting

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 09 January, 2015 - Willem Ferguson wrote: On 09/01/2015 16:32, Anton Lundin wrote: I've bin thinking if this is a good idea to plot in our already massive plot. I'm more leaning towards just plotting a computed po2 value here, and the setpoint of course, and then rather add a some

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 09 January, 2015 - Willem Ferguson wrote: This patch implements the visualisation of the oxygen sensor data for CCR dives. The partial pressure measurements of each of the sensors are graphed using the existing partial pressure axis in the dive profile widget. There are now four separate

Re: [PATCH] Visualisation of individual oxygen sensor data for CCR dives

On 09/01/2015 11:20, Davide DB wrote: Any way to display OX sensor values (if available) in a PSCR dive? I have no experience whatsoever with PSCR. Can these data be logged into the existing fields of the structures of sample as defined in dive.h? I suspect that the most important