Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-30 Thread Jef Driesen
On 2015-06-29 23:11, Claudiu Olteanu wrote: Hello Jef, Thanks for making time to let us know what you have in mind for the next release. More or less it is similar with the changes I made, except that I tried to avoid to modify the native serial implementation. I will make you a short resume

Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-29 Thread Jef Driesen
On 2015-06-26 01:33, Claudiu Olteanu wrote: I attached some patches which can be used to make the *libdivecomputer * project to accept callbacks to custom functions used for serial communication. As I mentioned in my weekly report, I am not sure if I made the best decisions on the

Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-29 Thread Claudiu Olteanu
Hello Jef, Thanks for making time to let us know what you have in mind for the next release. More or less it is similar with the changes I made, except that I tried to avoid to modify the native serial implementation. I will make you a short resume about the changes I did because I believe that

Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-27 Thread Claudiu Olteanu
Hi there, I did the modifications we discussed. You can find attached some new patches. I hope that now they are grouped correctly. For the moment I updated only the HW_OSTC3 family to use the custom serial implementation. These patches can be applied on the origin/Subsurface-testing branch.

Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-26 Thread Claudiu Olteanu
I believe this is a good direction. From the discussion earlier I'm doubtful that Jef agrees, but maybe a successful implementation can sway him :-) It would be good if he will give us some feedback. That looks odd. You should have Jef's Copyright there (since it's based on his code), but

Re: [PATCH] libdivecomputer - custom implementation for serial communication

2015-06-26 Thread Dirk Hohndel
On Fri, Jun 26, 2015 at 07:00:37PM +0300, Claudiu Olteanu wrote: I believe this is a good direction. From the discussion earlier I'm doubtful that Jef agrees, but maybe a successful implementation can sway him :-) It would be good if he will give us some feedback. Jef is very busy and has