This is missing a Signed-Off-By: line
and it doesn't compile (toAscii() doesn't exist... did you mean toUtf8()?)
/D
On Tue, Oct 14, 2014 at 09:41:36AM +0200, Salvo Tomaselli wrote:
From 441da7c4e1b8fd41709919e29fb79944999d1209 Mon Sep 17 00:00:00 2001
From: Salvo 'LtWorf' Tomaselli
Hi Salvo
Thanks for the patch. The idea looks good and the networking part per se looks
correct (even if I haven't run the code), but like Dirk said, it needs a
couple of fixes before it goes in. Here are a couple of suggestions from me:
On Sunday 12 October 2014 19:41:41 Salvo Tomaselli
On Monday 13 October 2014 21:23:59 Salvo Tomaselli wrote:
How about now?
I used astyle and I think I've addressed all the comments.
Thanks Salvo.
This looks better. I haven't run your code yet, but it looks like it does what
you're proposing to do.
I only have one issue: your code leaks
On Sun, Oct 12, 2014 at 07:41:41PM +0200, Salvo Tomaselli wrote:
Greetings,
I made this patch that adds a new export option, to diveshare.
Nice
Dives can still be anonymous, but users can click a button and
go on a page where they have a secret string that they can paste
so that dives
