Re: Formatting Dive tags string

On Thu, Apr 5, 2018 at 11:29 PM, Berthold Stoeger < bstoe...@mail.tuwien.ac.at> wrote: > > I'm disappointed to learn that git only does 7-bit ASCII tags...? ☹ > You shouldn't be. It does: $ git tag øl $ git tag  $ git tag øl  Henrik ___

Re: Formatting Dive tags string

On Donnerstag, 5. April 2018 19:45:31 CEST Thiago Macieira wrote: > On Thursday, 5 April 2018 10:32:37 PDT Berthold Stoeger wrote: > > Hi, > > > > On Donnerstag, 5. April 2018 19:28:28 CEST Thiago Macieira wrote: > > > On Thursday, 5 April 2018 10:25:37 PDT Berthold Stoeger wrote: > > > > It's

Re: Formatting Dive tags string

On Thursday, 5 April 2018 10:32:37 PDT Berthold Stoeger wrote: > Hi, > > On Donnerstag, 5. April 2018 19:28:28 CEST Thiago Macieira wrote: > > On Thursday, 5 April 2018 10:25:37 PDT Berthold Stoeger wrote: > > > It's fine as it is, since all C-strings are supposed to be UTF-8 > > > encoded. > > >

Re: Formatting Dive tags string

Hi, On Donnerstag, 5. April 2018 19:28:28 CEST Thiago Macieira wrote: > On Thursday, 5 April 2018 10:25:37 PDT Berthold Stoeger wrote: > > It's fine as it is, since all C-strings are supposed to be UTF-8 encoded. > > The only use I see for fromLatin1() et al. would be importing data from an > >

Re: Formatting Dive tags string

On Thursday, 5 April 2018 10:25:37 PDT Berthold Stoeger wrote: > It's fine as it is, since all C-strings are supposed to be UTF-8 encoded. > The only use I see for fromLatin1() et al. would be importing data from an > external source that is not UTF-8. If it's US-ASCII, it is valid UTF-8, but

Re: Formatting Dive tags string

Hi Jérémie, On Donnerstag, 5. April 2018 16:58:47 CEST Jérémie Guichard wrote: > Hello Thiago, > > In order to not mix the two topics in the same change, I decided to keep > the conversion to QString as it was in the original code, see: >

Re: Formatting Dive tags string

Hello Thiago, In order to not mix the two topics in the same change, I decided to keep the conversion to QString as it was in the original code, see: https://github.com/Subsurface-divelog/subsurface/blob/12dc1889c704c6af9125d3ef3f0d2a1c1fe603f7/desktop-widgets/tab-widgets/maintab.cpp#L574

Re: Formatting Dive tags string

On Wednesday, 4 April 2018 02:55:22 PDT Berthold Stoeger wrote: > char *s = taglist_get_tagstring(...); > QString tags(s); > free(s); One minor note: this decodes the string as UTF-8. If your string is Latin1 or plain US-ASCII, you should use QString::fromLatin1 or QLatin1String (same

Re: Formatting Dive tags string

Here is the pull request :) https://github.com/Subsurface-divelog/subsurface/pull/1187 2018-04-04 14:35 GMT+02:00 Lubomir I. Ivanov : > On 4 April 2018 at 14:27, Lubomir I. Ivanov wrote: > > On 4 April 2018 at 12:36, Jérémie Guichard

Re: Formatting Dive tags string

On 4 April 2018 at 14:27, Lubomir I. Ivanov wrote: > On 4 April 2018 at 12:36, Jérémie Guichard wrote: >> Hello everybody, >> >> While reviewing this change adding display for Tags in dive list view >>

Re: Formatting Dive tags string

On 4 April 2018 at 12:36, Jérémie Guichard wrote: > Hello everybody, > > While reviewing this change adding display for Tags in dive list view > (https://github.com/Subsurface-divelog/subsurface/pull/1184), Lubomir and > Dirk raised a concern regarding tag text that can exceed

Re: Formatting Dive tags string

Hi Jérémie, On Mittwoch, 4. April 2018 11:36:18 CEST Jérémie Guichard wrote: > > Lubomir mentioned he could look into this 'issue' but did not have much > free time, since I do have some on my side I can look into this change. I > do prefer to consult the community before doing it though. Here

Formatting Dive tags string

Hello everybody, While reviewing this change adding display for Tags in dive list view ( https://github.com/Subsurface-divelog/subsurface/pull/1184), Lubomir and Dirk raised a concern regarding tag text that can exceed inputted buffer size. Issue comes from implementation/signature of