Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:07:02PM +0300, Lubomir I. Ivanov wrote: On 6 July 2015 at 17:33, Claudiu Olteanu olteanu.vasilica.clau...@gmail.com wrote: Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 05:33:00PM +0300, Claudiu Olteanu wrote: Hi, These patches create a generic way to represent any type of serial communication. They are used to create a custom serial implementation for HW_OSTC3 and SHEARWATER families. This looks good to me. I'll add these to our

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Claudiu Olteanu
Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread PULL REQUEST. Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull request. Also I knew that Dirk prefers patches instead of pull requests.

Re: [PULL REQUEST] libdivecomputer - Subsurface-testing branch

2015-07-06 Thread Dirk Hohndel
On Mon, Jul 06, 2015 at 06:17:02PM +0300, Claudiu Olteanu wrote: Hi Lubomir, Thanks for the info! Yeah, probably I shouldn't named the thread PULL REQUEST. Since these are the differences between my repository and the Subsurface' one, I thought that the process is similar with a pull