Re: Adding integration with more online dive logs GSoC 2015

2015-03-12 Thread Tomaz Canabrava
On Wed, Mar 11, 2015 at 4:32 PM, Dirk Hohndel d...@hohndel.org wrote: On Wed, Mar 11, 2015 at 07:31:47PM +0200, Yosef Hamza wrote: a) Left it as implemented first for now -safer- b) Done but when passing the gaschange to the helper C function the compiler raised a warning, I guessed

Re: Adding integration with more online dive logs GSoC 2015

2015-03-12 Thread Dirk Hohndel
On Tue, Mar 10, 2015 at 11:08:14PM +0200, Yosef Hamza wrote: Check this and let me know what you think. This is for the second one, I will leave the first one for now and check the new changes made there by Tomaz. The code flow has changed quite a bit for that one, so yes, read what's there

Re: Adding integration with more online dive logs GSoC 2015

2015-03-12 Thread Yosef Hamza
a) Left it as implemented first for now -safer- b) Done but when passing the gaschange to the helper C function the compiler raised a warning, I guessed that's not acceptable, So I did this hack. QString char *. Is that okay? c) Done §Yousef On Wed, Mar 11, 2015 at 12:20 AM, Dirk Hohndel

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Yosef Hamza
On Tue, Mar 10, 2015 at 5:02 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Mar 10, 2015 at 02:54:48PM +0200, Yosef Hamza wrote: Hey subsurface, My name is Yousef Hamza, and I'm 3rd year CESS student, I already have contributions to subsurface the desktop app and the iOS app. You

Re: Adding integration with more online dive logs GSoC 2015

2015-03-10 Thread Dirk Hohndel
On Wed, Mar 11, 2015 at 12:13:17AM +0200, Yosef Hamza wrote: On Tue, Mar 10, 2015 at 11:39 PM, Dirk Hohndel d...@hohndel.org wrote: On Tue, Mar 10, 2015 at 11:08:14PM +0200, Yosef Hamza wrote: a) the events are ordered by time, so the moment you have one where time.seconds 0 you can