[PATCH 2/3] Make autocomplete work on add dive

2016-05-20 Thread Joakim Bygdell
This sets the list models for autocompleting suit, buddy and divemaster. Signed-off-by: Joakim Bygdell --- mobile-widgets/qml/DiveDetails.qml | 3 +++ mobile-widgets/qml/DiveDetailsEdit.qml | 3 +++ mobile-widgets/qml/main.qml| 9 ++--- 3 files changed,

Re: [PATCH 1/3] Add init function to qmlmanager

2016-05-20 Thread Tomaz Canabrava
Joakim, Acked, But I do think this should be different controllers. But anyway, this looks good and I'll probably change it on the future just to make qmlmanager a managed, not a God class. Tomaz Em 20 de mai de 2016 13:50, "Joakim Bygdell" escreveu: In order to get

[PATCH 3/3] White space cleanup

2016-05-20 Thread Joakim Bygdell
Signed-off-by: Joakim Bygdell --- mobile-widgets/qml/DiveDetails.qml | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mobile-widgets/qml/DiveDetails.qml b/mobile-widgets/qml/DiveDetails.qml index aee8a89..3dfb879 100644 ---

Re: QML inconsistency Android <-> Desktop

2016-05-20 Thread Joakim Bygdell
> On 16 May 2016, at 21:32, Dirk Hohndel wrote: > > On Mon, May 16, 2016 at 09:24:33PM +0200, Joakim Bygdell wrote: >>> Can you send a follow up patch that addresses that? >> Sure. > > Thanks > Do you prefer a full patch series or just the new patches standalone? /Jocke

Re: QML inconsistency Android <-> Desktop

2016-05-20 Thread Dirk Hohndel
> On May 20, 2016, at 9:44 AM, Joakim Bygdell wrote: > > >> On 16 May 2016, at 21:32, Dirk Hohndel wrote: >> >> On Mon, May 16, 2016 at 09:24:33PM +0200, Joakim Bygdell wrote: Can you send a follow up patch that addresses that? >>> Sure. >> >>

[PATCH 1/3] Add init function to qmlmanager

2016-05-20 Thread Joakim Bygdell
In order to get autocomplete to work on manual dive add we apparently need a separate init function. Signed-off-by: Joakim Bygdell --- mobile-widgets/qmlmanager.cpp | 51 +++ mobile-widgets/qmlmanager.h | 7 ++ 2 files changed,