Re: Shearwater / CCR / ppO2 tracking

2019-03-12 Thread Dirk Hohndel
On Tue, Mar 12, 2019 at 05:07:04PM -0700, Linus Torvalds wrote:
> On Tue, Mar 12, 2019 at 8:29 AM Long, Martin  wrote:
> >
> > The old problem of the ppO2 setpoint being shown or imported, rather than 
> > the actual ppO2 values has come back again.
> 
> Right you are, and thanks for the report.
> 
> When I merged in libdivecomputer Jef's upstream to get back in sync
> again after the "Petrel Native Format (PNF)" parsing updates, it seems
> we - once again - lost our fixes to take per-cell calibration data
> into account, because Jeff hasn't taken those changes.
> 
> I went back and fixed it once again, and tried to verify that there
> was nothing else that had gotten lost.
> 
> Dirk - I also updated with some trivial updates with Jef that had
> occurred in the last month and a half. I pushed out the tree, but I
> don't have any CC data to test with, of course, so my fix it just
> ObviouslyCorrect(tm). Famous last words.

Thanks for catching this. Pushed to master.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Shearwater / CCR / ppO2 tracking

2019-03-12 Thread Linus Torvalds
On Tue, Mar 12, 2019 at 8:29 AM Long, Martin  wrote:
>
> The old problem of the ppO2 setpoint being shown or imported, rather than the 
> actual ppO2 values has come back again.

Right you are, and thanks for the report.

When I merged in libdivecomputer Jef's upstream to get back in sync
again after the "Petrel Native Format (PNF)" parsing updates, it seems
we - once again - lost our fixes to take per-cell calibration data
into account, because Jeff hasn't taken those changes.

I went back and fixed it once again, and tried to verify that there
was nothing else that had gotten lost.

Dirk - I also updated with some trivial updates with Jef that had
occurred in the last month and a half. I pushed out the tree, but I
don't have any CC data to test with, of course, so my fix it just
ObviouslyCorrect(tm). Famous last words.

  Linus
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: dive planner bug - gas consumption missing

2019-03-12 Thread Dean Murray
excuse me, link here:
https://github.com/Subsurface-divelog/subsurface/issues/1998


On Tue, Mar 12, 2019 at 9:07 PM Dean Murray  wrote:

> Done, thanks.
>
> On Tue, Mar 12, 2019 at 6:38 PM Willem Ferguson <
> willemfergu...@zoology.up.ac.za> wrote:
>
>> On 2019/03/12 03:48, Dean Murray wrote:
>> > Hi all, thanks for checking. I also now tested in Ubuntu 18.04 / xfce
>> > and also find no problem there. Just in Windows. Shall i report this
>> > via github if no one here is in a position to take a look anytime
>> > soon? Is there any further detail I should provide?
>> >
>> > Dean
>>
>> Thank you for your time and effort. Please report the bug in Github?
>>
>> Kind regards,
>>
>> willem
>>
>>
>>
>> --
>> This message and attachments are subject to a disclaimer.
>>
>> Please refer to
>> http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
>>  for
>> full
>> details.
>>
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: dive planner bug - gas consumption missing

2019-03-12 Thread Dean Murray
Done, thanks.

On Tue, Mar 12, 2019 at 6:38 PM Willem Ferguson <
willemfergu...@zoology.up.ac.za> wrote:

> On 2019/03/12 03:48, Dean Murray wrote:
> > Hi all, thanks for checking. I also now tested in Ubuntu 18.04 / xfce
> > and also find no problem there. Just in Windows. Shall i report this
> > via github if no one here is in a position to take a look anytime
> > soon? Is there any further detail I should provide?
> >
> > Dean
>
> Thank you for your time and effort. Please report the bug in Github?
>
> Kind regards,
>
> willem
>
>
>
> --
> This message and attachments are subject to a disclaimer.
>
> Please refer to
> http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf
>  for
> full
> details.
>
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: dive planner bug - gas consumption missing

2019-03-12 Thread Willem Ferguson

On 2019/03/12 03:48, Dean Murray wrote:
Hi all, thanks for checking. I also now tested in Ubuntu 18.04 / xfce 
and also find no problem there. Just in Windows. Shall i report this 
via github if no one here is in a position to take a look anytime 
soon? Is there any further detail I should provide?


Dean


Thank you for your time and effort. Please report the bug in Github?

Kind regards,

willem



--
This message and attachments are subject to a disclaimer.

Please refer to 
http://upnet.up.ac.za/services/it/documentation/docs/004167.pdf 
 for
full 
details.

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface