Re: How about 4.4.2?

2015-05-04 Thread Dirk Hohndel
On Fri, May 01, 2015 at 09:26:36AM -0700, Dirk Hohndel wrote:
 
 
  On May 1, 2015, at 09:09, Miika Turkia miika.tur...@gmail.com wrote:
  
  On Thu, Apr 30, 2015 at 10:05 AM, Dirk Hohndel d...@hohndel.org wrote:
  On Wed, Apr 29, 2015 at 11:26:57AM -0700, Dirk Hohndel wrote:
  I just merged our libdc branches with the latest upstream from
  libdivecomputer. More precisely, Subsurface-4.4 branch was merged, but
  Subsurface-testing was rebased, so that one will require a force pull. Jef
  has done some good work recently and added support for a few more dive
  computers.
  
  So if I were to make a 4.4.2 release with the latest libdivecomputer code
  included... are there any other fixes in master that I absolutely should
  back port?
  
  I know that I'd take a couple of my Uemis fixes as Uemis support in 4.4.1
  is actually rather broken :-(
  
  Anything else?
  
  The multi-dive editing seems to be broken also in v4.4-branch.
  (Overwrites tags that are different from the displayed dive.)
 
 I think I fixed that... Wasn't that before 4.4?
 
 I'm on my phone, will look into this later. Definitely something we should 
 fix for 4.4.2

OK, the XSLT fixes for the Eon Steel are in, as is the fix for the multi
dive editing of tags. Latest translations are pulled.

Anything else that I'm missing? Otherwise I'll cut 4.4.2 today.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-05-04 Thread Salvador Cuñat
Hi Dirk.

El lun., 4 may. 2015 a las 16:18, Dirk Hohndel (d...@hohndel.org)
escribió:


 Anything else that I'm missing? Otherwise I'll cut 4.4.2 today.


As far as I can see, there are untranslated strings that aren't loaded on
transifex, e.g.  Find moved images in File dropdown list, and others.

BTW, latest changes on user manual are untranslated too.

Regards.

Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-05-04 Thread Dirk Hohndel
On Mon, May 04, 2015 at 05:42:42PM +, Salvador Cuñat wrote:
 Hi Dirk.
 
 El lun., 4 may. 2015 a las 16:18, Dirk Hohndel (d...@hohndel.org)
 escribió:
 
 
  Anything else that I'm missing? Otherwise I'll cut 4.4.2 today.
 
 
 As far as I can see, there are untranslated strings that aren't loaded on
 transifex, e.g.  Find moved images in File dropdown list, and others.
 
 BTW, latest changes on user manual are untranslated too.

Are you talking the v4.4-branch? Or master.
Master is not fully translated. And a while away from a release. I will
issue a call for translations as that gets closer.

v4.4-branch shouldn't have received new strings since 4.4.1
(doesn't mean I didn't mess it up, but it SHOULDN'T)

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-05-04 Thread Salvador Cuñat
Hi Dirk.

2015-05-04 19:59 GMT+02:00 Dirk Hohndel d...@hohndel.org:


 Are you talking the v4.4-branch? Or master.
 Master is not fully translated. And a while away from a release. I will
 issue a call for translations as that gets closer.

 v4.4-branch shouldn't have received new strings since 4.4.1
 (doesn't mean I didn't mess it up, but it SHOULDN'T)


You are right,  I was talking about master.
 I apologize for this noise.

Regards.

Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-05-01 Thread Dirk Hohndel


 On May 1, 2015, at 09:09, Miika Turkia miika.tur...@gmail.com wrote:
 
 On Thu, Apr 30, 2015 at 10:05 AM, Dirk Hohndel d...@hohndel.org wrote:
 On Wed, Apr 29, 2015 at 11:26:57AM -0700, Dirk Hohndel wrote:
 I just merged our libdc branches with the latest upstream from
 libdivecomputer. More precisely, Subsurface-4.4 branch was merged, but
 Subsurface-testing was rebased, so that one will require a force pull. Jef
 has done some good work recently and added support for a few more dive
 computers.
 
 So if I were to make a 4.4.2 release with the latest libdivecomputer code
 included... are there any other fixes in master that I absolutely should
 back port?
 
 I know that I'd take a couple of my Uemis fixes as Uemis support in 4.4.1
 is actually rather broken :-(
 
 Anything else?
 
 The multi-dive editing seems to be broken also in v4.4-branch.
 (Overwrites tags that are different from the displayed dive.)

I think I fixed that... Wasn't that before 4.4?

I'm on my phone, will look into this later. Definitely something we should fix 
for 4.4.2

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-05-01 Thread Miika Turkia
On Thu, Apr 30, 2015 at 10:05 AM, Dirk Hohndel d...@hohndel.org wrote:
 On Wed, Apr 29, 2015 at 11:26:57AM -0700, Dirk Hohndel wrote:
 I just merged our libdc branches with the latest upstream from
 libdivecomputer. More precisely, Subsurface-4.4 branch was merged, but
 Subsurface-testing was rebased, so that one will require a force pull. Jef
 has done some good work recently and added support for a few more dive
 computers.

 So if I were to make a 4.4.2 release with the latest libdivecomputer code
 included... are there any other fixes in master that I absolutely should
 back port?

 I know that I'd take a couple of my Uemis fixes as Uemis support in 4.4.1
 is actually rather broken :-(

 Anything else?

The multi-dive editing seems to be broken also in v4.4-branch.
(Overwrites tags that are different from the displayed dive.)

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-04-30 Thread Dirk Hohndel
On Thu, Apr 30, 2015 at 09:20:31AM -0700, Dirk Hohndel wrote:
 On Thu, Apr 30, 2015 at 06:07:59PM +0200, Robert Helling wrote:
  Dirk,
  
   On 30.04.2015, at 18:05, Dirk Hohndel d...@hohndel.org wrote:
   
   If no one has anything else they want me to add I'll finish my testing and
   then just cut the release and move back to looking at 4.5 :-]
  
  my suggestion would be to wait for Miika to come up with something for
  the dialogs.de export (the sample interval).
 
 Reasonable suggestion, but I haven't seen anything that indicates there's
 a clear path to a fix right now... Once Miika reemerges from his dives
 he'll have to comment :-)

In the meantime, for those on Windows, I put a binary up for testing
(internal version is inconsistent with the filename, I know)
http://subsurface-divelog.org/downloads/daily/subsurface-4.4.2-RC1.exe

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-04-30 Thread Miika Turkia
On Thu, Apr 30, 2015 at 10:20 AM, Dirk Hohndel d...@hohndel.org wrote:
 On Thu, Apr 30, 2015 at 06:07:59PM +0200, Robert Helling wrote:
 Dirk,

  On 30.04.2015, at 18:05, Dirk Hohndel d...@hohndel.org wrote:
 
  If no one has anything else they want me to add I'll finish my testing and
  then just cut the release and move back to looking at 4.5 :-]

 my suggestion would be to wait for Miika to come up with something for
 the dialogs.de export (the sample interval).

 Reasonable suggestion, but I haven't seen anything that indicates there's
 a clear path to a fix right now... Once Miika reemerges from his dives
 he'll have to comment :-)

OK, I just sent a recommendation for handling this. Though the logic
might benefit from additional eyes.

miika
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-04-30 Thread Dirk Hohndel
On Thu, Apr 30, 2015 at 05:50:26PM -0600, Miika Turkia wrote:
 On Thu, Apr 30, 2015 at 10:20 AM, Dirk Hohndel d...@hohndel.org wrote:
  On Thu, Apr 30, 2015 at 06:07:59PM +0200, Robert Helling wrote:
  Dirk,
 
   On 30.04.2015, at 18:05, Dirk Hohndel d...@hohndel.org wrote:
  
   If no one has anything else they want me to add I'll finish my testing 
   and
   then just cut the release and move back to looking at 4.5 :-]
 
  my suggestion would be to wait for Miika to come up with something for
  the dialogs.de export (the sample interval).
 
  Reasonable suggestion, but I haven't seen anything that indicates there's
  a clear path to a fix right now... Once Miika reemerges from his dives
  he'll have to comment :-)
 
 OK, I just sent a recommendation for handling this. Though the logic
 might benefit from additional eyes.

I looked through them and the first two seem obvious. The third one is not
quite as clear but it does appear to make sense.

Linus has a bunch of dives on his Eon Steele. Maybe he can export them all
to divelogs.de then import them into a different file and then we can
compare if they still look sane...

I'll take the patches as they are and will push this to master (that makes
it easier for people to test). If this works as expected I can easily
cherry-pick them for 4.4.2

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-04-30 Thread Dirk Hohndel
On Wed, Apr 29, 2015 at 11:26:57AM -0700, Dirk Hohndel wrote:
 I just merged our libdc branches with the latest upstream from
 libdivecomputer. More precisely, Subsurface-4.4 branch was merged, but
 Subsurface-testing was rebased, so that one will require a force pull. Jef
 has done some good work recently and added support for a few more dive
 computers.
 
 So if I were to make a 4.4.2 release with the latest libdivecomputer code
 included... are there any other fixes in master that I absolutely should
 back port?
 
 I know that I'd take a couple of my Uemis fixes as Uemis support in 4.4.1
 is actually rather broken :-(
 
 Anything else?

No one? In that case 4.4.2 will be really easy to do... I have the latest
libdivecomputer state merged in the Subsurface-4.4 branch of
git.subsurface-divelog.org/ldc and have all the things I want to include
in 4.4.2 in the v4.4-branch of Subsurface.

I don't think there is a point in making a test binary for this... No one
ever seems to test the Uemis support (and that clearly included myself in
the case of 4.4 - I will test a multi part download on Windows with this
one before releasing it), and the rest is just libdivecomputer changes...

If no one has anything else they want me to add I'll finish my testing and
then just cut the release and move back to looking at 4.5 :-]

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: How about 4.4.2?

2015-04-30 Thread Dirk Hohndel
On Thu, Apr 30, 2015 at 06:07:59PM +0200, Robert Helling wrote:
 Dirk,
 
  On 30.04.2015, at 18:05, Dirk Hohndel d...@hohndel.org wrote:
  
  If no one has anything else they want me to add I'll finish my testing and
  then just cut the release and move back to looking at 4.5 :-]
 
 my suggestion would be to wait for Miika to come up with something for
 the dialogs.de export (the sample interval).

Reasonable suggestion, but I haven't seen anything that indicates there's
a clear path to a fix right now... Once Miika reemerges from his dives
he'll have to comment :-)

/D

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


How about 4.4.2? [was Re: new Windows 4.4.1 binary is up]

2015-04-29 Thread Dirk Hohndel
I just merged our libdc branches with the latest upstream from
libdivecomputer. More precisely, Subsurface-4.4 branch was merged, but
Subsurface-testing was rebased, so that one will require a force pull. Jef
has done some good work recently and added support for a few more dive
computers.

So if I were to make a 4.4.2 release with the latest libdivecomputer code
included... are there any other fixes in master that I absolutely should
back port?

I know that I'd take a couple of my Uemis fixes as Uemis support in 4.4.1
is actually rather broken :-(

Anything else?

/D

On Tue, Apr 28, 2015 at 03:02:22PM -0700, Dirk Hohndel wrote:
 Didn't want to go through the pain of calling it 4.4.2 - and the only
 difference is that uploads to Divelogs.de with non-ascii home path now
 seem to work.
 
 Rainer, if you have any other users who complained about that... this
 might be the solution.
 
 /D
 ___
 subsurface mailing list
 subsurface@subsurface-divelog.org
 http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface