Re: libgit2-dev and detection in subsurface/scripts/build.sh

On Wed, 14 Oct 2020, Dirk Hohndel via subsurface wrote: > > I actually think that this isn't a bad idea. Except that it also > should have a clause that allows ldconfig to be found in the PATH, > right? Sure, but are there distributions out there that place ldconfig in the non-root PATH? >

Re: libgit2-dev and detection in subsurface/scripts/build.sh

scu-Idbohrn via subsurface > wrote: > > Debian unstable here. > > I did not have libgit2-dev installed and noticed this in build.log: > > ./subsurface/scripts/build.sh: line 268: ldconfig: command not found > realpath: missing operand > Try 'realpat

Re: libgit2-dev and detection in subsurface/scripts/build.sh

On Sun, Oct 11, 2020 at 7:08 PM Cristian Ionescu-Idbohrn via subsurface < subsurface@subsurface-divelog.org> wrote: > Debian unstable here. > > I did not have libgit2-dev installed and noticed this in build.log: > > ./subsurface/scripts/build.sh: line 268: ldconfig

libgit2-dev and detection in subsurface/scripts/build.sh

Debian unstable here. I did not have libgit2-dev installed and noticed this in build.log: ./subsurface/scripts/build.sh: line 268: ldconfig: command not found realpath: missing operand Try 'realpath --help' for more information. That's because ldconfig is installed

Re: libgit2

On 8 June 2018 at 21:18, Willem Ferguson wrote: > Are there any new requirements with respect to libgit2? not really. > My previous builds > (until yesterday all built perfectly. I have libgit2 V0.26, yet, now, with > building the latest master I get: > > -- Checking f

libgit2

Are there any new requirements with respect to libgit2? My previous builds (until yesterday all built perfectly. I have libgit2 V0.26, yet, now, with building the latest master I get: -- Checking for module 'libgit2' --   No package 'libgit2' found CMake Error at /usr/share/cmake-3.5/Modules

[PATCH 10/12] Support libgit2 api 0.24

Signed-off-by: Anton Lundin --- core/git-access.c | 4 1 file changed, 4 insertions(+) diff --git a/core/git-access.c b/core/git-access.c index fe3a918..6fe90b0 100644 --- a/core/git-access.c +++ b/core/git-access.c @@ -308,7 +308,11 @@ static int

[PATCH] Be compatible with libgit2 0.22 again

The callback function was introduced in 0.23, so put it behind that ifdef. Signed-off-by: Anton Lundin --- git-access.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/git-access.c b/git-access.c index a9e411e..b133a76 100644 --- a/git-access.c +++

[PATCH] Be compatible with libgit2 0.22 again

In libgit2 0.22 tree_flags was called flags. Signed-off-by: Anton Lundin <gla...@acc.umu.se> --- git-access.c | 4 1 file changed, 4 insertions(+) diff --git a/git-access.c b/git-access.c index 388fa27..e09deb6 100644 --- a/git-access.c +++ b/git-access.c @@ -195,7 +195,11 @@ stat

[PATCH 1/5] Upgrade libgit2 for android

Signed-off-by: Anton Lundin gla...@acc.umu.se --- packaging/android/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packaging/android/build.sh b/packaging/android/build.sh index 63c99ff..f8d61e0 100644 --- a/packaging/android/build.sh +++ b/packaging/android/build.sh

Fix compiling against libgit2-0.22.1

Hi, The attached patch fixes compile errors against libgit2-0.22.1. It might not make sense at all but, for people like me who do not use git storage but want to run a bleeding-edge subsurface, it does the job. :) Cheers. -- Gaetan From c8944f796712882b9ea7dced929c5af97e24889b Mon Sep 17 00

Re: Fix compiling against libgit2-0.22.1

On Sun, Jun 14, 2015 at 05:23:11PM -1000, Gaetan Bisson wrote: Hi, The attached patch fixes compile errors against libgit2-0.22.1. It might not make sense at all but, for people like me who do not use git storage but want to run a bleeding-edge subsurface, it does the job. :) This breaks

update on libgit2

I have been working with one of the developers on the libgit2 team and am happy to announce that with his code libgit2 successfully uses an http proxy and I can connect to the Subsurface cloud storage infrastructure through a proxy. Since this hasn't landed it libgit2 master, yet, I'm not quite

Re: [libgit2] Compile issue on debian-unstable

with libgit2. I run Ubuntu 14.4 and the default version of libgit-dev is V19. Does the latest Subsurface master run with libgit2 V19? The first #if in that file appears to provide for this #if !LIBGIT2_VER_MAJOR LIBGIT2_VER_MINOR = 20 but I get make errors as discussed previously on this forum

Re: [libgit2] Compile issue on debian-unstable

On 19 February 2015 at 07:02, Miika Turkia miika.tur...@gmail.com wrote: On Ubuntu Utopic (14.10) I also have the problem with only 1 parameter for git_remote _fetch #define LIBGIT2_VERSION 0.20.0 I use the attached patch on my tree, but never sent it out ideally we can have

[libgit2] Compile issue on debian-unstable

, from git-access.c:11: /usr/local/include/git2/remote.h:359:17: note: declared here GIT_EXTERN(int) git_remote_fetch(git_remote *remote); ^ Makefile:1464: recipe for target '.obj/git-access.o' failed Debian Jessie actually ships libgit2-21, so it's easy to solve, simply

Re: [libgit2] Compile issue on debian-unstable

); ^ Makefile:1464: recipe for target '.obj/git-access.o' failed Debian Jessie actually ships libgit2-21, so it's easy to solve, simply building a libgit2-22 library, but it would introduce an extra step in the building instructions (at least, as removing 2-21 could break some

Re: [libgit2] Compile issue on debian-unstable

Hi Lubomir. I think Debian's libgit2-21 is equivalent to v0.21 I've just remembered I had a built (not debian package) libgit2 library, may be it's still hanging around, as /usr/local/include/ is not the usual install dir for debian. Gonna take a look. Regards. Salva. 2015-02-19 0:22 GMT+01

Re: [libgit2] Compile issue on debian-unstable

On 19 February 2015 at 02:14, Lubomir I. Ivanov neolit...@gmail.com wrote: i'm not sure why we have the wrapper for a 3 parameter git_remote_fetch(), as i can't find it in their log. fe3a40a4ff056400 is when git_remote_fetch() was added with one param and then it changed to 4 params at

Re: [libgit2] Compile issue on debian-unstable

. what a mess. I've just remembered I had a built (not debian package) libgit2 library, may be it's still hanging around, as /usr/local/include/ is not the usual install dir for debian. Gonna take a look. could be the case, but our macro may be wrong as well. l Hi Lubomir

Re: [libgit2] Compile issue on debian-unstable

On 19 February 2015 at 01:42, Salvador Cuñat salvador.cu...@gmail.com wrote: Hi Lubomir. I think Debian's libgit2-21 is equivalent to v0.21 BTW, what does /include/git2/version.h says in terms of x.xx version? c3ab1e5af4c43d added the 4 parameter version to git_remote_fetch() (version.h

Re: [PATCH] api change in libgit2-0.22

On Thu, Jan 22, 2015 at 10:14:03PM +0100, Martin Gysel wrote: Yet another api change in libgit2... let's quote the website libgit2 is ... linkable library with a solid API ... Yeah, right. What a mess. And I assume there is no easy check for the exact commits where this happens, so for people

[PATCH] api change in libgit2-0.22

Yet another api change in libgit2... let's quote the website libgit2 is ... linkable library with a solid API ... Signed-off-by: Martin Gysel m...@bearsh.org --- save-git.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/save-git.c b/save-git.c

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

: error: ‘git_libgit2_init’ was not declared in this scope The API changed for libgit2 0.22, not in 0.21. ok, i see. looks like i got confused here. odd, can't find such a thing as 0.22 in version.h or in their tags. is the current master *actual* version hidden in some way, while 0.21

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

: In function ‘int main(int, char**)’: ../../src/subsurface/main.cpp:48:19: error: ‘git_libgit2_init’ was not declared in this scope The API changed for libgit2 0.22, not in 0.21. ok, i see. looks like i got confused here. odd, can't find such a thing as 0.22 in version.h or in their tags

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On Dec 7, 2014, at 4:49 AM, Lubomir I. Ivanov neolit...@gmail.com wrote: erm, that patch won't work for everyone... i think i was trying to make a point that their API broke mid 0.21 (macro) version. so do we have to use another macro such as USE_LIBGIT22_API? ideas? No, I think we

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On Sunday 07 December 2014 19:09:03 Lubomir I. Ivanov wrote: also the version bump for 0.21 is not at the tag for 0.21, but before it. Ask them to bump the master version to 0.22 already. In fact, you can probably contribute that change yourself :-) Qt changes the version number in one of the

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On 7 December 2014 at 20:05, Thiago Macieira thi...@macieira.org wrote: On Sunday 07 December 2014 19:09:03 Lubomir I. Ivanov wrote: also the version bump for 0.21 is not at the tag for 0.21, but before it. Ask them to bump the master version to 0.22 already. In fact, you can probably

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On 7 December 2014 at 20:18, Gaetan Bisson bis...@archlinux.org wrote: [2014-12-06 15:48:03 +0200] Lubomir I. Ivanov: +#if !LIBGIT2_VER_MAJOR LIBGIT2_VER_MINOR = 20 !defined(USE_LIBGIT21_API) This breaks building against libgit2 for me: main.cpp: In function 'int main(int, char

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

, though. There's no mention of git_libgit2_init anywhere in my libgit2 headers. and what does version.h say? my bad, you already posted version.h so if 'git_libgit2_init' isn't there and this is the case for version.h: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 21

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

the master version to 0.22 already. In fact, you can probably contribute that change yourself :-) seems like a bad idea, i'm probably going to flame someone in the process... ;-) Hi, I noticed that the master branch still says that libgit2 is version 0.21. When trying to build Subsurface

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

says that libgit2 is version 0.21. When trying to build Subsurface with the master version, I'm getting build errors due to source-incompatible changes. Can I suggest that libgit2 change its version number soon after the release or at the latest at the same moment as a source- or binary

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

-- 0001-main.cpp-rework-the-libgit2-version-check.patch Description: Binary data ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

LIBGIT2_VER_MINOR 21 #define LIBGIT2_VER_REVISION 2 and this one (attached)? lubomir -- 0001-main.cpp-rework-the-libgit2-version-check.patch That one works. /Jocke ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

. from one of my earlier messages: 799e22ea (API broken) is after 4fb32a44 (version.h bumped to 0.21). 799e22ea made the git_libgit2_init() change. Well, there is no occurrence of libgit2_init in the 0.21.1 tarball: https://github.com/libgit2/libgit2/archive/v0.21.1.tar.gz -- Gaetan

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On 7 December 2014 at 21:34, Gaetan Bisson bis...@archlinux.org wrote: [2014-12-07 20:32:14 +0200] Lubomir I. Ivanov: so if 'git_libgit2_init' isn't there and this is the case for version.h: #define LIBGIT2_VER_MAJOR 0 #define LIBGIT2_VER_MINOR 21 there is no solution...it

[PATCH] main.cpp: fix broken build for libgit2 0.21

From: Lubomir I. Ivanov neolit...@gmail.com 799e22ea0c3f20 in libgit2 renamed a function, which breaks our build. To fix that we check the current version and if the USE_LIBGIT21_API definition was used. Signed-off-by: Lubomir I. Ivanov neolit...@gmail.com --- re-sending to the ML --- main.cpp

Re: [PATCH] main.cpp: fix broken build for libgit2 0.21

On Saturday 06 December 2014 15:49:57 Lubomir I. Ivanov wrote: +#if !LIBGIT2_VER_MAJOR LIBGIT2_VER_MINOR = 20 !defined(USE_LIBGIT21_API) git_threads_init(); +#else + git_libgit2_init(); +#endif Conditional is broken The API changed for libgit2 0.22, not in 0.21. -- Thiago Macieira

Re: [PATCH] Add libdivecomputer and libgit2 to Ubuntu building

On Sat, Nov 22, 2014 at 7:51 AM, Dirk Hohndel d...@hohndel.org wrote: On Sat, Nov 22, 2014 at 06:49:39AM +0200, Miika Turkia wrote: Some instructions how building libdivecomputer differs from Subsurface build. And mention to copy libigt2 over to other repository if needed. I have started

Re: [PATCH] Add libdivecomputer and libgit2 to Ubuntu building

On Sat, Nov 22, 2014 at 06:49:39AM +0200, Miika Turkia wrote: Some instructions how building libdivecomputer differs from Subsurface build. And mention to copy libigt2 over to other repository if needed. I have started to play with this and would like go a slightly different path (but I'd like

Re: ERROR: Package libgit2 not found

On Mon, 10 Nov 2014, Cristian Ionescu-Idbohrn wrote: The problem is debian packaging. There's already a bug filed for that, as I mentioned in an earlier post. See https://bugs.debian.org/768482. And the bug is now closed. A new libgit2-dev with proper dependencies was released to debian

Re: ERROR: Package libgit2 not found

On Mon, 10 Nov 2014, Dirk Hohndel wrote: On Nov 9, 2014, at 3:27 PM, Dirk Hohndel d...@hohndel.org wrote: Yes. Thanks. Unfortunately, there's still a problem when building subsurface from source :( It seems reasonable to at least document this on our web page. I'll try to do this

ERROR: Package libgit2 not found

Anyone else seeing this (on recent debian unstable)? , | $ qmake | Project ERROR: Package libgit2 not found ` Still, I have the libgit2 packages installed: , | libgit2-21:amd64install | libgit2-dev:amd64 install ` I

FTBFS libgit2

Is there anything new about libgit2 in the qmake file? I get this Project ERROR: Package libgit2 not found I have the dev files installed, and I tried to have a look but it seems like a straightforward directive so I don't know where the problem is. Using master from git. -- Salvo Tomaselli

Re: FTBFS libgit2

On Nov 9, 2014, at 9:10 AM, Salvo Tomaselli tipos...@tiscali.it wrote: Is there anything new about libgit2 in the qmake file? I get this Project ERROR: Package libgit2 not found I have the dev files installed, and I tried to have a look but it seems like a straightforward directive

Re: ERROR: Package libgit2 not found

On Nov 9, 2014, at 6:07 AM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: Answer to myself: $ pkg-config --print-errors --exists libgit2 Package libssh2 was not found in the pkg-config search path. Perhaps you should add the directory containing `libssh2.pc

Re: ERROR: Package libgit2 not found

-errors --exists libgit2 Package libssh2 was not found in the pkg-config search path. Perhaps you should add the directory containing `libssh2.pc' to the PKG_CONFIG_PATH environment variable Package 'libssh2', required by 'libgit2', not found I needed to install package libssh2-1-dev. Patch

Re: ERROR: Package libgit2 not found

On Sun, 9 Nov 2014, Cristian Ionescu-Idbohrn wrote: Package libgit2-21 shows these dependencies: Depends: libc6 (= 2.15), libhttp-parser2.1 (= 2.1), libssh2-1 (= 1.2.3), libssl1.0.0 (= 1.0.0), zlib1g (= 1:1.1.4) while the corresponding -dev package lists

Re: ERROR: Package libgit2 not found

On Sun, 9 Nov 2014, Dirk Hohndel wrote: On Nov 9, 2014, at 1:37 PM, Cristian Ionescu-Idbohrn cristian.ionescu-idbo...@axis.com wrote: There's even a bug files against libgit2-dev: https://bugs.debian.org/768482 Nevertheless: , | $ qmake | Project ERROR: Package

Re: ERROR: Package libgit2 not found

. Is it possible that this is an issue with libgit2 packaging on Debian? Subsurface in debian doesn't use libgit2, I wrote a patch to take it away because of the poor status of libgit2, otherwise Subsurface wouldn't have been in the upcoming stable release of debian. Yes. Thanks. Unfortunately