Re: Dive planner

2018-10-29 Thread Robert Helling
Hi, > On 29. Oct 2018, at 22:52, Robert Helling wrote: > > it seems, this is a regression that was introduced sometime between 4.8.1 and > 4.8.2. Bisecting…. I think I fixed this in https://github.com/Subsurface-divelog/subsurface/pull/1835

Re: Failing to store data on mobile

2018-10-29 Thread Dirk Hohndel
> On Oct 29, 2018, at 8:17 AM, Miika Turkia wrote: > > On Mon, Oct 29, 2018 at 4:34 PM Dirk Hohndel > wrote: > > > On Oct 28, 2018, at 9:40 PM, Miika Turkia > > wrote: > > > > I have tried to implement copy-paste functionality for the

Re: Failing to store data on mobile

2018-10-29 Thread Miika Turkia
On Mon, Oct 29, 2018 at 5:32 PM Dirk Hohndel wrote: > > On Oct 29, 2018, at 8:17 AM, Miika Turkia wrote: > > On Mon, Oct 29, 2018 at 4:34 PM Dirk Hohndel wrote: > >> >> > On Oct 28, 2018, at 9:40 PM, Miika Turkia >> wrote: >> > >> > I have tried to implement copy-paste functionality for the

Re: Failing to store data on mobile

2018-10-29 Thread Dirk Hohndel
> On Oct 28, 2018, at 9:40 PM, Miika Turkia wrote: > > I have tried to implement copy-paste functionality for the Subsurface-mobile. > The current branch (mobile-copy) seems to be working but when re-opening > Subsurface, nothing has been saved. So what is the trick to actually save > data

Re: Failing to store data on mobile

2018-10-29 Thread Linus Torvalds
On Mon, Oct 29, 2018 at 8:33 AM Dirk Hohndel wrote: > > That's strange, because that function calls mark_divelist_changed(true) - so > anything that is in the divelist should be saved to the local repo. Anything that changes a dive also needs to call 'invalidate_dive_cache()' for it to be saved

Re: Failing to store data on mobile

2018-10-29 Thread Miika Turkia
On Mon, Oct 29, 2018 at 4:34 PM Dirk Hohndel wrote: > > > On Oct 28, 2018, at 9:40 PM, Miika Turkia > wrote: > > > > I have tried to implement copy-paste functionality for the > Subsurface-mobile. The current branch (mobile-copy) seems to be working but > when re-opening Subsurface, nothing has

Re: Failing to store data on mobile

2018-10-29 Thread Dirk Hohndel
> On Oct 29, 2018, at 8:54 AM, Miika Turkia wrote: > > Anyway, it seems to be that Linus' hint of calling invalidate_dive_cache() > did the trick. Which begs the question if this should be added somewhere in that call chain in the first place... /D