Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-11 Thread Tomeu Vizoso
On Fri, Apr 11, 2008 at 12:12 PM, Simon Schampijer [EMAIL PROTECTED] wrote: Thanks Tomeu for reviewing. I few things I found out when looking into that - I don't think introduced by the patch but maybe worth to look at. - I had the 'connecting...' label in the palette on the mesh view

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-11 Thread Simon Schampijer
Thanks Tomeu for reviewing. I few things I found out when looking into that - I don't think introduced by the patch but maybe worth to look at. - I had the 'connecting...' label in the palette on the mesh view even though I was already connected. Later it went away. - The palette of the AP in

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-10 Thread Tomeu Vizoso
On Thu, Apr 10, 2008 at 12:53 AM, Eben Eliason [EMAIL PROTECTED] wrote: What do you mean here? +self.props.icon_name = icon_name +# This breaks style guidelines; we should store a reference +self._palette._icon.props.icon_name = icon_name I'm

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-10 Thread Marco Pesenti Gritti
If I remember correctly icon is a a Palette property so why not just access it through the property... Marco On Thu, Apr 10, 2008 at 9:31 AM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Thu, Apr 10, 2008 at 12:53 AM, Eben Eliason [EMAIL PROTECTED] wrote: What do you mean here? +

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-10 Thread Tomeu Vizoso
r+ On Thu, Apr 10, 2008 at 3:02 PM, Simon Schampijer [EMAIL PROTECTED] wrote: Eben Eliason wrote: I made the following changes to the patch: - display the AP icon in the palette in color - display the badge as well - removed the channel info in the secondary-text (for now)

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-09 Thread Simon Schampijer
Hi Eben, I made the following changes to the patch: - display the AP icon in the palette in color - display the badge as well - removed the channel info in the secondary-text (for now) What do you mean here? +self.props.icon_name = icon_name +# This breaks style

Re: [sugar] [PATCH] (partial) AP palette patch

2008-04-09 Thread Eben Eliason
I made the following changes to the patch: - display the AP icon in the palette in color - display the badge as well - removed the channel info in the secondary-text (for now) Sounds good. What do you mean here? +self.props.icon_name = icon_name +# This

[sugar] [PATCH] (partial) AP palette patch

2008-04-08 Thread Eben Eliason
This is my attempt at cleaning up the appearance and behavior of the palettes attached to APs in the neighborhood view. I can't see APs in jhbuild, so I can't test it. It compiles, but I won't promise it runs. Also, there are a couple of bits of info that I want to show that I didn't know how to