Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-28 Thread Tomeu Vizoso
r+ On Sat, Apr 26, 2008 at 4:53 PM, Eben Eliason [EMAIL PROTECTED] wrote: After much ado, here is the resulting patch. - Eben On Fri, Apr 25, 2008 at 2:17 PM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Wed, Apr 23, 2008 at 10:05 PM, Eben Eliason [EMAIL PROTECTED] wrote: On

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-25 Thread Tomeu Vizoso
On Wed, Apr 23, 2008 at 10:05 PM, Eben Eliason [EMAIL PROTECTED] wrote: On Wed, Apr 23, 2008 at 3:52 PM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Wed, Apr 23, 2008 at 9:45 PM, Eben Eliason [EMAIL PROTECTED] wrote: Hmm, you mean: if jobject.metadata.get('title', ''):

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Bert Freudenberg
On 23.04.2008, at 21:23, Eben Eliason wrote: if jobject.metadata.has_key['title'] and jobject.metadata.has_key['title']: Seems a bit redundant. - Bert - ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Tomeu Vizoso
On Wed, Apr 23, 2008 at 9:26 PM, Bert Freudenberg [EMAIL PROTECTED] wrote: On 23.04.2008, at 21:23, Eben Eliason wrote: if jobject.metadata.has_key['title'] and jobject.metadata.has_key['title']: Seems a bit redundant. ;) I would go for if jobject.metadata.get('title', ''):

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Eben Eliason
On Wed, Apr 23, 2008 at 3:26 PM, Bert Freudenberg [EMAIL PROTECTED] wrote: On 23.04.2008, at 21:23, Eben Eliason wrote: if jobject.metadata.has_key['title'] and jobject.metadata.has_key['title']: Seems a bit redundant. I agree, but this is the root of the problem. It represents the

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Bert Freudenberg
On 23.04.2008, at 21:32, Eben Eliason wrote: On Wed, Apr 23, 2008 at 3:26 PM, Bert Freudenberg [EMAIL PROTECTED] wrote: On 23.04.2008, at 21:23, Eben Eliason wrote: if jobject.metadata.has_key['title'] and jobject.metadata.has_key['title']: Seems a bit redundant. I agree, but this

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Eben Eliason
Hah, indeed. Well in any case, had it read what I intended to write, it would have *still* looked redundant enough to be ugly. - Eben On Wed, Apr 23, 2008 at 3:48 PM, Bert Freudenberg [EMAIL PROTECTED] wrote: On 23.04.2008, at 21:32, Eben Eliason wrote: On Wed, Apr 23, 2008 at 3:26 PM,

Re: [sugar] [PATCH] Fix appearance of activity bundles (in Journal)

2008-04-23 Thread Tomeu Vizoso
On Wed, Apr 23, 2008 at 9:45 PM, Eben Eliason [EMAIL PROTECTED] wrote: Hmm, you mean: if jobject.metadata.get('title', ''): title_text = jobject.metadata.get('title', '') else title_text = _('Untitled') title.props.text = title_text ... Do I not need to declare title_text