Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-13 Thread Tomeu Vizoso
On Tue, Jun 10, 2008 at 5:21 PM, Morgan Collett [EMAIL PROTECTED] wrote: http://dev.laptop.org/git?p=users/morgan/sugar-toolkit;a=shortlog;h=6298 - Guillaume's change, r+ from me - Can I push this to sugar-toolkit? Think so. #6298: Launch Chat for 1-1 XMPP chat +import json +

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-13 Thread Morgan Collett
On Fri, Jun 13, 2008 at 14:56, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Tue, Jun 10, 2008 at 5:21 PM, Morgan Collett [EMAIL PROTECTED] wrote: http://dev.laptop.org/git?p=users/morgan/sugar-toolkit;a=shortlog;h=6298 - Guillaume's change, r+ from me - Can I push this to sugar-toolkit? Think

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-13 Thread Morgan Collett
On Fri, Jun 13, 2008 at 14:56, Tomeu Vizoso [EMAIL PROTECTED] wrote: #6298: Launch Chat for 1-1 XMPP chat +activityfactory.create_with_uri('org.laptop.Chat', tp_channel) Marco, I thought we wanted to deprecate create_with_uri()? Do you have a better idea here? What I need is to

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-13 Thread Tomeu Vizoso
r+ ;) On Fri, Jun 13, 2008 at 3:41 PM, Morgan Collett [EMAIL PROTECTED] wrote: On Fri, Jun 13, 2008 at 14:56, Tomeu Vizoso [EMAIL PROTECTED] wrote: #6298: Launch Chat for 1-1 XMPP chat +activityfactory.create_with_uri('org.laptop.Chat', tp_channel) Marco, I thought we wanted to

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-10 Thread Morgan Collett
On Wed, Jun 4, 2008 at 17:25, Guillaume Desmottes [EMAIL PROTECTED] wrote: Le mercredi 04 juin 2008 à 17:08 +0200, Morgan Collett a écrit : The main code to review is at: http://dev.laptop.org/git?p=users/morgan/sugar;a=shortlog;h=6298 (3 most recent patches). As bundle_id is passed to both

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-06-04 Thread Guillaume Desmottes
Le mercredi 04 juin 2008 à 17:08 +0200, Morgan Collett a écrit : The main code to review is at: http://dev.laptop.org/git?p=users/morgan/sugar;a=shortlog;h=6298 (3 most recent patches). As bundle_id is passed to both constructor, you could move it to BaseInvite.__init__ Didn't read code

[sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-05-23 Thread Morgan Collett
I extended the Invites to handle connections for 1-1 connections. This should also handle incoming streaming media connections for VideoChat (when that activity has the necessary bits in place). It depends on Guillaume's patches in http://dev.laptop.org/ticket/6298 for presence-service, sugar,

Re: [sugar] [PATCH] Refactor invites for 1-1 Chat (#6298)

2008-05-23 Thread Michael Stone
On Fri, May 23, 2008 at 05:12:29PM +0200, Morgan Collett wrote: I will get this patch up in my git repo, as soon as I can figure out why it won't allow me to push (non-fast forward). Git is warning you about divergence: there are patches on the branch you're pushing into that you have not yet