Re: [sugar] [PATCH] adding a bad device to the frame shouldn't crash sugar

On Wed, Jun 04, 2008 at 11:44:09AM +0200, Tomeu Vizoso wrote: Looks good to me. Small comments inline: +import logging +logger = logging.getLogger('DevicesTray') What about moving the import along with the others and declaring the logger at the module level as in

[sugar] [PATCH] adding a bad device to the frame shouldn't crash sugar

--- src/view/frame/devicestray.py | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/src/view/frame/devicestray.py b/src/view/frame/devicestray.py index 1accdad..1b7f3d1 100644 --- a/src/view/frame/devicestray.py +++ b/src/view/frame/devicestray.py @@ -35,11