Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-19 Thread Simon Schampijer
Hi, the issue I see is that you have to hit the up/down keys twice or three times (focus entry widget, non-focus, focus scrollbar). So it might be hard to discover what is actually happening. @eben: how do we handle focus. We grab focus on the entry in the mesh view. We do not in the

Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-15 Thread Marco Pesenti Gritti
Any reason to not use key_press events or similar? I don't think we should patch gtk.ScrolledWindow behavior. Marco On Thu, May 15, 2008 at 12:38 PM, Tomeu Vizoso [EMAIL PROTECTED] wrote: Hi, the patch below adds the Up and Down arrow keys to the gtk.ScrolledWindow key bindings in the

Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-15 Thread Tomeu Vizoso
On Thu, May 15, 2008 at 12:56 PM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: Any reason to not use key_press events or similar? I don't think we should patch gtk.ScrolledWindow behavior. Well, I guess that Eben will want this behavior in all the list views (mesh, group, activity, more?).

Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-15 Thread Marco Pesenti Gritti
On Thu, May 15, 2008 at 1:04 PM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Thu, May 15, 2008 at 12:56 PM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: Any reason to not use key_press events or similar? I don't think we should patch gtk.ScrolledWindow behavior. Well, I guess that Eben will

Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-15 Thread Eben Eliason
On Thu, May 15, 2008 at 7:04 AM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Thu, May 15, 2008 at 12:56 PM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: Any reason to not use key_press events or similar? I don't think we should patch gtk.ScrolledWindow behavior. Well, I guess that Eben

Re: [sugar] [PATCH] scroll activity list with the arrow keys

2008-05-15 Thread Tomeu Vizoso
Hi, this new patch uses key-press-event. Thanks, Tomeu On Thu, May 15, 2008 at 5:08 PM, Eben Eliason [EMAIL PROTECTED] wrote: On Thu, May 15, 2008 at 7:04 AM, Tomeu Vizoso [EMAIL PROTECTED] wrote: On Thu, May 15, 2008 at 12:56 PM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: Any reason