Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
On Sun, Jun 8, 2008 at 3:51 AM, Jameson Chema Quinn [EMAIL PROTECTED] wrote: Sorry, Marco, but here is yet another version of the patch. I decided to refactor the Config class out of bundlebuilder - all it was carrying in the common start() case was bundle_name; and as for other cases, it is

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
On Sun, Jun 8, 2008 at 3:51 AM, Jameson Chema Quinn [EMAIL PROTECTED] wrote: Sorry, Marco, but here is yet another version of the patch. I decided to refactor the Config class out of bundlebuilder - all it was carrying in the common start() case was bundle_name; and as for other cases, it is

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
-import subprocess +from subprocess import Popen, PIPE import re import gettext from optparse import OptionParser +import warnings +import subprocess warnings seem unused, doesn't pylint warn you about it? Since you are importing subprocess just use that for Popen and PIPE. +from

[sugar] [PATCH] Browse - copy Image to clipboard under rainbow

2008-06-08 Thread Simon Schampijer
Hi, tomeu can you verify that patch? Use case: Copying an image using the palette under rainbow. We loose the data which exist in the filename, should we try to store this somehow? Best, Simon diff --git a/palettes.py b/palettes.py index d62fb5e..254201f 100644 --- a/palettes.py +++

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Jameson Chema Quinn
Some quick responses, before I dig into this... On Sun, Jun 8, 2008 at 4:08 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: -import subprocess +from subprocess import Popen, PIPE import re import gettext from optparse import OptionParser +import warnings +import subprocess warnings

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
On Sun, Jun 8, 2008 at 1:59 PM, Jameson Chema Quinn [EMAIL PROTECTED] wrote: It doesn't make sense for activitybundle to expose something a generic as list_files, especially since you are just using it to walk files inside that module. So I should duplicate the code of list_files? (This is my

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Jameson Chema Quinn
Here is the revised patch. It has your suggested changes, plus a couple more: - Check for existence of po directory in Builder - Config.__init__() is cleaned up. Now gets bundle name from activity.info. start() no longer needs a bundle name, and has deprecation warning. Also I put things in a

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
On Sun, Jun 8, 2008 at 9:26 PM, Jameson Chema Quinn [EMAIL PROTECTED] wrote: Here is the revised patch. It has your suggested changes, plus a couple more: - Check for existence of po directory in Builder - Config.__init__() is cleaned up. Now gets bundle name from activity.info. start() no

Re: [sugar] Features for Sugar 0.82

2008-06-08 Thread Kim Quirk
Sounds great Marco. I'd really like to get a build that Charlie and Joe can start testing asap. Will this come from the OLPC-3 branch? We will work with Michael on exactly where to get the build and release notes about what should be working. Thanks! Kim On Sat, Jun 7, 2008 at 8:39 AM, Marco

Re: [sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

2008-06-08 Thread Marco Pesenti Gritti
Also, you left this in. +print path Marco ___ Sugar mailing list Sugar@lists.laptop.org http://lists.laptop.org/listinfo/sugar