Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread Sayamindu Dasgupta
On Thu, Sep 18, 2008 at 6:06 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread Michael Stone
On Thu, Sep 18, 2008 at 01:23:57PM +0530, Sayamindu Dasgupta wrote: On Thu, Sep 18, 2008 at 6:06 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread Martin Dengler
On Thu, Sep 18, 2008 at 04:05:26AM -0400, Michael Stone wrote: On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread C. Scott Ananian
On Thu, Sep 18, 2008 at 3:53 AM, Sayamindu Dasgupta [EMAIL PROTECTED] wrote: String addtions ?? Now ?? Three words: Triangle, Box, and Spiral. I wonder if a compromise version of the patch might remove all the words and just use icons for the three different layouts. The words don't actually

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread Marco Pesenti Gritti
On Thu, Sep 18, 2008 at 4:57 PM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 8:38 AM, Martin Dengler [EMAIL PROTECTED] wrote: I'll do my review but Scott need not worry about mine since my patches are already in 0.82.1[1] and 8.2-758[2]. Hm, I'm actually a bit

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-18 Thread Sayamindu Dasgupta
On Thu, Sep 18, 2008 at 11:43 PM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 10:54 AM, C. Scott Ananian [EMAIL PROTECTED] wrote: On Thu, Sep 18, 2008 at 3:53 AM, Sayamindu Dasgupta [EMAIL PROTECTED] wrote: String addtions ?? Now ?? Three words: Triangle, Box, and

[sugar] Finale: consider merging a few fun Sugar patches?

2008-09-17 Thread Michael Stone
Folks, We've reached the last call for changes before final test and, in the hopes of ending our development cycle on a playful note, I'd like to ask the sugar team to consider whether they'd be comfortable reviewing and merging a couple of the outstanding UI patches like Scott's alternate

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-17 Thread Marco Pesenti Gritti
On Thu, Sep 18, 2008 at 2:30 AM, Marco Pesenti Gritti [EMAIL PROTECTED] wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. * The patches are large and I don't think it's impossible that

Re: [sugar] Finale: consider merging a few fun Sugar patches?

2008-09-17 Thread Michael Stone
On Thu, Sep 18, 2008 at 02:30:30AM +0200, Marco Pesenti Gritti wrote: * At *very* high level the patch sets looks sane. I would be comfortable with them going in if Scott reviews Martin set, and Martin reviews Scott set. Sounds good. Hopefully there are a few other sugar volunteers who could chip