Re: [Sugar-devel] [PATCH v3] Remove hippo from the frame

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-03 11:49:46 +0200: > Based on earlier work by Raul Gutierrez and Walter Bender. [...] Looks good, thanks! Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature __

[Sugar-devel] [ANNOUNCE] Election Details for 2011-2012

2011-10-08 Thread Luke Faraone
Hi all, It's that time of year again: oversight board election season! Three (3) seats are to be selected over the coming months. The timeline[1] for the election is as follows: == Timeline == - 2011-11-07 23:59 EST: Deadline for applications for membership. - 2011-11-12 23:59 EST: All members

Re: [Sugar-devel] [PATCH sugar] Make sure the connection is established before we use it SL #3119

2011-10-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-07 19:49:08 +0200: > The code is a bit racy. We need to make sure the connection is > already established to not get the traceback. Tested with > Salut and Gabble. When reading "git log", there's no Traceback, so it's not clear what the above re

Re: [Sugar-devel] [PATCH sugar] Make sure that we have a connection before we set our properties SL #3119

2011-10-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-07 19:47:34 +0200: > The issue here is that we di not have a connection yet, when ^ did > the name owner changes. It is safer to listen to the connection > watcher when a connection is added (which was the original code

Re: [Sugar-devel] [PATCH] Update alpha according to filter after events in neighborhoodview icons - SL #3091

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-07 18:19:18 +0200: > The design is strange, but this is how the neighborhood view has > worked for as long as I have been involved with the project. Each icon > subscribes to all of its possible event sources (the search box, the > network device it

Re: [Sugar-devel] [PATCH] SpreadLayout: fix grid cell allocation

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-05 23:05:16 +0200: > The calculation of how many grid cells to assign a child element > has a bug in that it rounds down instead of up. [...] Thanks for the patch (including the great description)! Acked-By: Sascha Silbe Sascha -- http://sascha.

Re: [Sugar-devel] [PATCH sugar] Control Panel: making about my computer section hardware independent, OLPC #11232

2011-10-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-10-07 11:13:15 +0200: > '/ofw' is not used anymore on the XO, '/proc/device-tree' is used now > instead. Instead of just adjusting for that change we took the > chance to make the section hardware independent. As the firmware > version we display the

[Sugar-devel] Moon string translation difficulties

2011-10-08 Thread Gary Martin
Hi Chris, I just wanted to ping and ask your opinion on how best to help translators know what to do when they encounter variable string formatting of some kind. For example, while trying to manually fix up strings with missing /n line ends in ps.po (to get a release out today), I've also just

Re: [Sugar-devel] [PATCH 1/2] Fix presence detection of keyboard layouts/options

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-06 16:58:53 +0200: > "foo is []" is not a valid way of checking if a list is empty > as this code intends. > > "foo" alone as a boolean operator is an equivalent length check, > and also serves as a "is not None" check too. Thanks for the patch! A

Re: [Sugar-devel] [PATCH 2/2] Only activate keyboard configuration if it was configured, OLPC #11175

2011-10-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2011-10-06 16:59:29 +0200: > Sugar is currently activing a new keyboard config even if the user ^ activating > did not change any settings. [...] Thanks for the patch! Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http