Re: [Sugar-devel] Messages from the page to the browser in webkit2

2013-04-02 Thread Manuel Quiñones
2013/3/23 Daniel Narvaez dwnarv...@gmail.com Hey, Lionel's enyo-activity uses the webkit console-message signal to send messages from the browser to the web page. This is a bit of an hack. Also the signal is not available in webkit2 (though it might be added at some point). This kind of

Re: [Sugar-devel] Messages from the page to the browser in webkit2

2013-04-02 Thread Peter Robinson
On Tue, Apr 2, 2013 at 2:17 PM, Manuel Quiñones ma...@laptop.org wrote: 2013/3/23 Daniel Narvaez dwnarv...@gmail.com Hey, Lionel's enyo-activity uses the webkit console-message signal to send messages from the browser to the web page. This is a bit of an hack. Also the signal is not

Re: [Sugar-devel] Messages from the page to the browser in webkit2

2013-04-02 Thread Manuel Quiñones
2013/4/2 Peter Robinson pbrobin...@gmail.com: We also need to think when to switch Browse activity to webkit2. It's enabled in F-19/gnome 3.8 I believe so if you want to start playing the SoaSv9 Alpha Test composes in a VM would be an excellent spot to start :-D All versions here:

Re: [Sugar-devel] Features for 0.100

2013-04-02 Thread Manuel Quiñones
2013/3/29 Daniel Narvaez dwnarv...@gmail.com: This sounds like a pretty cool feature with a simple enough implementation. I'd say it's a good idea for 0.100. Yes, and the others too. So the general plan of adding this almost implemented features after review, and also html5 research is good in

Re: [Sugar-devel] Features for 0.100

2013-04-02 Thread Martin Abente
Let me know if there is something I can do to help. On Tue, Apr 2, 2013 at 10:18 AM, Manuel Quiñones ma...@laptop.org wrote: 2013/3/29 Daniel Narvaez dwnarv...@gmail.com: This sounds like a pretty cool feature with a simple enough implementation. I'd say it's a good idea for 0.100. Yes,

Re: [Sugar-devel] Github review workflow

2013-04-02 Thread Manuel Quiñones
2013/3/28 Daniel Narvaez dwnarv...@gmail.com: Hi, I started experimenting a bit with github code reviews, with Walter as ginuea pig :) We wasn't too sure about stuff like rebasing, using separate branches etc, so tonight I played a bit myself with creating pull requests. Something like the

Re: [Sugar-devel] Messages from the page to the browser in webkit2

2013-04-02 Thread Thomas Gilliard
On 04/02/2013 06:19 AM, Peter Robinson wrote: On Tue, Apr 2, 2013 at 2:17 PM, Manuel Quiñones ma...@laptop.org mailto:ma...@laptop.org wrote: 2013/3/23 Daniel Narvaez dwnarv...@gmail.com mailto:dwnarv...@gmail.com Hey, Lionel's enyo-activity uses the webkit

[Sugar-devel] Recent movement on Sugar master repository

2013-04-02 Thread Manuel Quiñones
Hi devs, I've seen some movement in current master. I suppose all this was reviewed, but what I wonder is if we are sticking to the signed-off-by / acked-by signing. The commits in question are: commit f423ec21b4bf0d953a470a383cc801b61a087e98 Author: Walter Bender walter.ben...@gmail.com Date:

Re: [Sugar-devel] Recent movement on Sugar master repository

2013-04-02 Thread Daniel Narvaez
Hey, sorry, I forgot about those. Though I think it's worth to think if we really need them while we are reworking reviews a bit. When is signed-off-by useful in sugar? How is reviewed-by applied? Is it the reviewer which rebase and add them before pushing? On 2 April 2013 18:30, Manuel

Re: [Sugar-devel] Github review workflow

2013-04-02 Thread Daniel Narvaez
On 2 April 2013 16:43, Manuel Quiñones ma...@laptop.org wrote: 7 Push the changes to another remote branch Is there a need for a new branch for each pull request? Pushing again to the topic1 will automatically update the pull request in github. The problem is when rebasing (i.e. making

Re: [Sugar-devel] Recent movement on Sugar master repository

2013-04-02 Thread Manuel Quiñones
Hi Daniel, 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: Hey, sorry, I forgot about those. Though I think it's worth to think if we really need them while we are reworking reviews a bit. When is signed-off-by useful in sugar? I think we just have been following other projects like the linux

Re: [Sugar-devel] Recent movement on Sugar master repository

2013-04-02 Thread Daniel Narvaez
So I'm not sure these are worth the overhead. Especially for signing it doesn't seem to be very useful for us, if not in some special cases, and it adds one more thing we need to require from contributors... I'd rather bug them about improving the code then about using a tag of dubious utility.

[Sugar-devel] Usage of Signed-off-by / Acked-by - Re: Recent movement on Sugar master repository

2013-04-02 Thread Manuel Quiñones
As we are revisiting all the review process, can we revisit the usage of signing the patches? What are they useful for? 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: So I'm not sure these are worth the overhead. Especially for signing it doesn't seem to be very useful for us, if not in some

Re: [Sugar-devel] Github review workflow

2013-04-02 Thread Manuel Quiñones
2013/4/2 Daniel Narvaez dwnarv...@gmail.com: On 2 April 2013 16:43, Manuel Quiñones ma...@laptop.org wrote: 7 Push the changes to another remote branch Is there a need for a new branch for each pull request? Pushing again to the topic1 will automatically update the pull request in github.

Re: [Sugar-devel] Github review workflow

2013-04-02 Thread Walter Bender
On Tue, Apr 2, 2013 at 1:47 PM, Manuel Quiñones ma...@laptop.org wrote: 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: On 2 April 2013 16:43, Manuel Quiñones ma...@laptop.org wrote: 7 Push the changes to another remote branch Is there a need for a new branch for each pull request? Pushing

[Sugar-devel] [sugar-artworkPATCH] Multi-Select icons; plus adding theme for insensitive UI (else the look is ghostly).

2013-04-02 Thread Ajay Garg
The patch is to be applied in mainline-repo, master-branch. gtk3/theme/gtk-widgets.css.em | 5 ++ icons/scalable/actions/Makefile.am | 2 + icons/scalable/actions/select-all.svg | 80 + icons/scalable/actions/select-none.svg | 72

[Sugar-devel] Sugar 0.100 status report - April 2

2013-04-02 Thread Daniel Narvaez
Hello, I will try to send out regular reports about the progress of the 0.100 release, weekly, bi-weekly or monthly depending on how much is happening. 1. A bit late, but we finally have a schedule for the release.We are not going to have a feature acceptance deadline this time. We decided to

[Sugar-devel] [DESIGN] Journal Details view - Re: Sugar 0.100 status report - April 2

2013-04-02 Thread Manuel Quiñones
Some UI feedback for the recently added comment box: 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: 5. Walter Bender landed several patches to add a comment box to journal entries. It will be populated both by the Portfolio activity and by the web services integration which is being worked on.

Re: [Sugar-devel] [DESIGN] Journal Details view - Re: Sugar 0.100 status report - April 2

2013-04-02 Thread Gary Martin
On 2 Apr 2013, at 23:59, Manuel Quiñones ma...@laptop.org wrote: Some UI feedback for the recently added comment box: 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: 5. Walter Bender landed several patches to add a comment box to journal entries. It will be populated both by the Portfolio

Re: [Sugar-devel] [DESIGN] Journal Details view - Re: Sugar 0.100 status report - April 2

2013-04-02 Thread Manuel Quiñones
Hey Gary, 2013/4/2 Gary Martin garycmar...@googlemail.com: On 2 Apr 2013, at 23:59, Manuel Quiñones ma...@laptop.org wrote: Some UI feedback for the recently added comment box: 2013/4/2 Daniel Narvaez dwnarv...@gmail.com: 5. Walter Bender landed several patches to add a comment box to