Re: [Sugar-devel] [IAEP] FW: Sugar 0.100 status report - April 2

2013-04-04 Thread Manuel Quiñones
2013/4/4 Ajay Garg a...@activitycentral.com: On Thu, Apr 4, 2013 at 1:08 AM, Manuel Quiñones ma...@laptop.org wrote: The feature page doesn't explicitly state, but I remember it allows batch removal. Ahh yes... it does :) Oh, right Ajay, it is in the summary:

Re: [Sugar-devel] Usage of Signed-off-by / Acked-by - Re: Recent movement on Sugar master repository

2013-04-04 Thread Gonzalo Odiard
On Wed, Apr 3, 2013 at 1:27 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Perhaps you can explain exactly what Signed-off-by adds compared to the author field in tnormal cases? I know it's not much work, but it adds one more thing we need to request to patch submitters. I tend to think the

Re: [Sugar-devel] Usage of Signed-off-by / Acked-by - Re: Recent movement on Sugar master repository

2013-04-04 Thread Daniel Narvaez
On 4 April 2013 14:23, Gonzalo Odiard gonz...@laptop.org wrote: About Reviewed-by, if you have say a 10 patches set, is one-by-one interactive rebase the only way to add the tag to all the patches? I'm not too attached to the one click pull request merging from the web UI... pulling and

[Sugar-devel] [PATCH] Bring back dragging of elements from the activities to the frame clipboard - SL #3819

2013-04-04 Thread Manuel Quiñones
TestCase: - open an activity like Browse, Read, Log (not Write, is a special case) - bring up the frame - drag things to the left side panel of the frame (images, links, or selected text) The elements should be added to the clipboard which is inside the panel. They should have the proper icon

Re: [Sugar-devel] Acked-by vs Reviewed-by

2013-04-04 Thread Manuel Quiñones
2013/4/3 James Cameron qu...@laptop.org: That's really up to the maintainer. If the maintainer pushes the patch, then Acked-by may be inferred. In general these procedures scale well to large numbers of maintainers, contributors, and reviewers. I'm not sure they remain appropriate for

Re: [Sugar-devel] Acked-by vs Reviewed-by

2013-04-04 Thread Daniel Narvaez
On 4 April 2013 19:02, Manuel Quiñones ma...@laptop.org wrote: 2013/4/3 James Cameron qu...@laptop.org: That's really up to the maintainer. If the maintainer pushes the patch, then Acked-by may be inferred. In general these procedures scale well to large numbers of maintainers,

Re: [Sugar-devel] [PATCH] Bring back dragging of elements from the activities to the frame clipboard - SL #3819

2013-04-04 Thread Flavio Danesse
Manuel, I think this code can be improved and greatly simplified if instead of using things like: selection_data.split uris = ('\ n') use: uris = selection.get_uris () Instead of using: selection.get_data (* args, ** kwargs) You can work directly on selection and get the data type with:

Re: [Sugar-devel] [PATCH] Bring back dragging of elements from the activities to the frame clipboard - SL #3819

2013-04-04 Thread Flavio Danesse
Actually if you for example: selection.get_uris (* args, ** kwargs) will return a list of uris in selection, so if no uris it will return an empty list, then do not even need to know what type of data is in selection. 2013/4/4 Flavio Danesse fdane...@gmail.com Manuel, I think this code can

Re: [Sugar-devel] [PATCH] Bring back dragging of elements from the activities to the frame clipboard - SL #3819

2013-04-04 Thread Manuel Quiñones
2013/4/4 Flavio Danesse fdane...@gmail.com: Actually if you for example: selection.get_uris (* args, ** kwargs) will return a list of uris in selection, so if no uris it will return an empty list, then do not even need to know what type of data is in selection. Excellent Flavio! I have to

[Sugar-devel] Webkit drag and drop bug

2013-04-04 Thread Daniel Narvaez
Hello, I opened a bug about the issue with dragged links having a \x00 at the end. https://bugs.webkit.org/show_bug.cgi?id=113962 I'm not really a gtk drag drop or a webkit expert, but that really seems like the issue to me. Let's see if someone comments. Might be worth trying if