Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-09 Thread James Cameron
Tested on XO-1.5 with os125, patch applied over Record-78. - Activity tab fine, - Photo tab fine, capture, fullscreen, playback, but information tab for the playback image had preview overlaying Tags (white box) and Date, - Record tab fine, capture, fullscreen, playback, same problem as above

[Sugar-devel] [PATCH] Fixes to the record UI

2010-06-09 Thread Erik Blankinship
El Wed, 09-06-2010 a las 11:39 +1000, James Cameron escribió: * There was probably a reason why it moved them off screen instead of** hiding them. Do you have any idea what it is?** ** b480c7ed2e4848f33f11f9df27f6cb34e7c76b82 was a move of elements** offscreen instead of hiding, committed

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-09 Thread Daniel Drake
On 8 June 2010 23:25, Anish Mangal anishmangal2...@gmail.com wrote: Hi, I did reply to your mail earlier today, I'll paste my comments here ... Still unanswered questions from my last mail: There was probably a reason why it moved them off screen instead of hiding them. Do you have any

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-09 Thread Erik Blankinship
This comment in ui.py explains why #we move offscreen to resize or else we get flashes on screen, and setting hide() doesn't allow resize moves OK. So this patch introduces some flashing ? [It looks like my recent post regarding this matter was not slipped into this thread nicely

[Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread anishmangal2002
From: anishmangal2002 anishmangal2...@gmail.com How the existing UI works: The record UI consists of many windows/widgets. In a particular mode or view, it displays and resizes the widgets appropriate for that view and tries to hide the other windows by moving them off-screen. Now, on sugar-0.88

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Aleksey Lim
On Wed, Jun 09, 2010 at 12:22:19AM +0530, anishmangal2...@gmail.com wrote: From: anishmangal2002 anishmangal2...@gmail.com How the existing UI works: The record UI consists of many windows/widgets. In a particular mode or view, it displays and resizes the widgets appropriate for that view

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Aleksey Lim
On Tue, Jun 08, 2010 at 07:45:06PM +, Aleksey Lim wrote: On Wed, Jun 09, 2010 at 12:22:19AM +0530, anishmangal2...@gmail.com wrote: From: anishmangal2002 anishmangal2...@gmail.com How the existing UI works: The record UI consists of many windows/widgets. In a particular mode or

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Bernie Innocenti
El Tue, 08-06-2010 a las 19:45 +, Aleksey Lim escribió: Patch looks good for me, if it doesn't beat Daniel's release plans, I guess we can commit (you are in commiters list) it and bump new Record release (you can also release new version). Fantastic. Anish, can you commit and provide a

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Aleksey Lim
On Tue, Jun 08, 2010 at 05:56:22PM -0400, Bernie Innocenti wrote: El Tue, 08-06-2010 a las 19:45 +, Aleksey Lim escribió: Patch looks good for me, if it doesn't beat Daniel's release plans, I guess we can commit (you are in commiters list) it and bump new Record release (you can also

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Daniel Drake
On 8 June 2010 13:52, anishmangal2...@gmail.com wrote: Fix description: The patch works by hiding or resizing (to size 1px by 1px) the widgets not required in a particular view/mode. The updateVideoComponents method has been modified to hide the widgets not required in a particular view.

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread James Cameron
There was probably a reason why it moved them off screen instead of hiding them. Do you have any idea what it is? b480c7ed2e4848f33f11f9df27f6cb34e7c76b82 was a move of elements offscreen instead of hiding, committed 2007-08-31 by erikb, there's no explanation given, and the SVN repository

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Paul Fox
james wrote: There was probably a reason why it moved them off screen instead of hiding them. Do you have any idea what it is? b480c7ed2e4848f33f11f9df27f6cb34e7c76b82 was a move of elements offscreen instead of hiding, committed 2007-08-31 by erikb, there's no explanation given,

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Bernie Innocenti
El Wed, 09-06-2010 a las 11:39 +1000, James Cameron escribió: There was probably a reason why it moved them off screen instead of hiding them. Do you have any idea what it is? b480c7ed2e4848f33f11f9df27f6cb34e7c76b82 was a move of elements offscreen instead of hiding, committed 2007-08-31

Re: [Sugar-devel] [PATCH] Fixes to the record UI

2010-06-08 Thread Anish Mangal
Hi, I did reply to your mail earlier today, I'll paste my comments here ... Still unanswered questions from my last mail: There was probably a reason why it moved them off screen instead of hiding them. Do you have any idea what it is? This comment in ui.py explains why #we move