On Sun, Sep 19, 2010 at 20:28, Dipankar Patro dipan...@seeta.in wrote:
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
Reviewed-By: Sascha Silbe
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
Reviewed-By: Sascha Silbe sascha-...@silbe.org
---
src/jarabe/desktop/schoolserver.py | 27
Reviewed-by: James Cameron qu...@laptop.org
(I agree with Sascha, there are minor whitespace issues that should be
fixed ... whitespace consistency greatly aids comprehension by humans
who have learned the patterns).
--
James Cameron
http://quozl.linux.org.au/
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
---
src/jarabe/desktop/schoolserver.py | 22 +++---
1 files changed, 19
Excerpts from Dipankar Patro's message of Sat Sep 18 19:18:55 +0200 2010:
+class TimeoutHTTP(httplib.HTTP):
+def __init__(self, host='', port=None, strict=None, timeout = None):
+if port == 0:
+port = None
+# FIXME: we are depending on undocumented internals
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
---
src/jarabe/desktop/schoolserver.py | 20 +---
1 files changed, 17 insertions(+),
On Thu, Sep 9, 2010 at 16:15, Dipankar Patro dipan...@seeta.in wrote:
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
---
Excerpts from Tomeu Vizoso's message of Wed Sep 08 11:00:13 +0200 2010:
+class TimeoutHTTP(httplib.HTTP):
http://docs.python.org/library/httplib.html says:
Note
The public interface for this module changed substantially in Python
2.0. The HTTP class is retained only for backward
Excerpts from Dipankar Patro's message of Wed Sep 08 16:48:46 +0200 2010:
-server = ServerProxy(url)
+server = xmlrpclib.ServerProxy(url)
Have you tried this patch? TimeoutTransport isn't used anywhere.
Sascha
--
http://sascha.silbe.org/
http://www.infra-silbe.de/
signature.asc
Registration with the school server is currently done synchronously.
To prevent the UI from hanging indefinitely, if the school server is reachable
but unresponsive, we add an explicit timeout.
---
src/jarabe/desktop/schoolserver.py | 19 ---
1 files changed, 16 insertions(+), 3
Excerpts from Dipankar Patro's message of Tue Sep 07 19:44:17 +0200 2010:
+class TimeoutHTTP(httplib.HTTP):
+ def __init__(self, host='', port=None, strict=None,
timeout=socket._GLOBAL_DEFAULT_TIMEOUT):
Line too long ( 80 chars). I don't think you'll ever get passed timeout
as a parameter,
11 matches
Mail list logo
