Re: [Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-17 Thread Martin Langhoff
On Wed, Feb 16, 2011 at 12:54 PM, Simon Schampijer si...@schampijer.de wrote: the general approach - just a few small comments inline. Thanks! There's a patch in reply, and a few comments from me here... +    def remove_window_by_xid(self, xid): +        Remove a window from the windows

Re: [Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-17 Thread Simon Schampijer
On 02/17/2011 01:21 PM, Martin Langhoff wrote: On Wed, Feb 16, 2011 at 12:54 PM, Simon Schampijersi...@schampijer.de wrote: the general approach - just a few small comments inline. Thanks! There's a patch in reply, and a few comments from me here... +def remove_window_by_xid(self,

Re: [Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-17 Thread Simon Schampijer
Pushed as dc8f6ed7852f919fe7123d458706fb82430257e9 Sascha gave his formal bless, too. Regards, Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-16 Thread Simon Schampijer
On 02/12/2011 05:27 PM, martin.langh...@gmail.com wrote: From: Martin Langhoffmar...@laptop.org Now activities have a stack of windows (Activity._windows). The lowest still-valid window in the stack is considered the main window. When a window is closed, the shell finds what activity had that

[Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-12 Thread martin . langhoff
From: Martin Langhoff mar...@laptop.org Now activities have a stack of windows (Activity._windows). The lowest still-valid window in the stack is considered the main window. When a window is closed, the shell finds what activity had that window, tells it to remove it from its stack. If that was

Re: [Sugar-devel] [PATCH 1/2] shell: handle activities that cycle through windows dlo#10695

2011-02-12 Thread Martin Langhoff
On Sat, Feb 12, 2011 at 2:09 PM, martin.langh...@gmail.com wrote: diff --git a/src/jarabe/model/shell.py b/src/jarabe/model/shell.py index 661e370..bd7e367 100644 I'd like to recall this particular patch. Apologies, posted the wrong version. cheers, m --  martin.langh...@gmail.com