Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default

2012-09-26 Thread Simon Schampijer
Ok, as discussed on irc, the text with a # is a comment not meant to be doc visible. Pushed as 1570f7742e606d09e9fb9079711dd6a43346784d Thanks for the review and testing, Simon On 09/26/2012 01:39 PM, Manuel QuiƱones wrote: Wow impressive patch. Is a great usability improvement, and havin

Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default

2012-09-26 Thread Manuel QuiƱones
Wow impressive patch. Is a great usability improvement, and having the placeholder text is nice. Also I don't see the text reset issue that I was seeing in your previous test app, sent to the design thread [1]. About code styling, do we have an agreement mixing docstrings like """this""" and # t

Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default

2012-09-26 Thread Gary Martin
Hi Simon, On 26 Sep 2012, at 08:40, Simon Schampijer wrote: > From: Simon Schampijer > > This patch does implement the following behavior: > > - the search entry in all the views (Home (Favorites and Activity list), > Group and Neighborhood) is unfocused by default > > - the search entry ca

Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default

2012-09-26 Thread Simon Schampijer
On 09/26/2012 09:40 AM, Simon Schampijer wrote: From: Simon Schampijer This patch does implement the following behavior: - the search entry in all the views (Home (Favorites and Activity list), Group and Neighborhood) is unfocused by default - the search entry can be focused by clicking in

[Sugar-devel] [PATCH shell] Views: defocus the search entry by default

2012-09-26 Thread Simon Schampijer
From: Simon Schampijer This patch does implement the following behavior: - the search entry in all the views (Home (Favorites and Activity list), Group and Neighborhood) is unfocused by default - the search entry can be focused by clicking in the entry or by starting to type - the search e