Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-18 Thread Simon Schampijer
On 04/17/2012 11:42 PM, Martin Langhoff wrote: On Mon, Apr 16, 2012 at 3:33 AM, Simon Schampijersi...@schampijer.de wrote: Thanks for the patch, looks good. I tested here with my AP that does announce in non utf-8 char and it works fine. Cool! Great stuff. What does your funny-chars AP read

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-17 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of 2012-04-11 23:40:55 +0200: [embedded NUL in SSIDs] Yes, that's the one case I wanted to test but couldn't (quickly) get HostAP to do it. I'm now quite sure that with the current versions, I can't get either iwconfig (which can be used to set up a Prism

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-17 Thread Martin Langhoff
On Mon, Apr 16, 2012 at 3:33 AM, Simon Schampijer si...@schampijer.de wrote: Thanks for the patch, looks good. I tested here with my AP that does announce in non utf-8 char and it works fine. Cool! Great stuff. What does your funny-chars AP read like in the UI with this patch? We have the

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-16 Thread Simon Schampijer
On 04/02/2012 06:40 PM, Sascha Silbe wrote: IEEE 802.11 [2] defines the SSID as a sequence of octets (i.e. bytes), but Sugar treated it as UTF-8 character data. While in most cases the SSID is actually some human-readable string, there's neither a guarantee for that nor does any (de-facto or

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-11 Thread Sascha Silbe
Excerpts from Martin Langhoff's message of 2012-04-10 21:43:20 +0200: There is only one thing that still worries me. According to the spec, the ESSID may also contain nulls in the middle of the array. I don't know how NM handles such cases in its communication with nm-client via d-bus. I

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-10 Thread Sascha Silbe
Excerpts from Daniel Drake's message of 2012-04-03 19:22:52 +0200: Had a quick read through the patch, looks good. Thanks for the review! Pushed as 7f8ba95 [1] to master. Backport to 0.94 prepared [2], but not tested yet. Sascha [1]

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-10 Thread Martin Langhoff
On Tue, Apr 3, 2012 at 1:22 PM, Daniel Drake d...@laptop.org wrote: Had a quick read through the patch, looks good. Same here. Thanks Sascha for this! There is only one thing that still worries me. According to the spec, the ESSID may also contain nulls in the middle of the array. I don't know

Re: [Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-03 Thread Daniel Drake
On Mon, Apr 2, 2012 at 10:40 AM, Sascha Silbe si...@activitycentral.com wrote: IEEE 802.11 [2] defines the SSID as a sequence of octets (i.e. bytes), but Sugar treated it as UTF-8 character data. While in most cases the SSID is actually some human-readable string, there's neither a guarantee

[Sugar-devel] [PATCH sugar] Don't treat SSID as UTF-8 character sequence (fixes SL#2023)

2012-04-02 Thread Sascha Silbe
IEEE 802.11 [2] defines the SSID as a sequence of octets (i.e. bytes), but Sugar treated it as UTF-8 character data. While in most cases the SSID is actually some human-readable string, there's neither a guarantee for that nor does any (de-facto or de-jure) standard specify the encoding to use. As