Re: [Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-08 Thread Manuel QuiƱones
2012/8/8 Gonzalo Odiard : >> > * API changed in the drag and drop code in Gtk >> > * Changes in the way to get color information from the theme. >> >> I would also add in the message that this is because Gtk.Style was >> deprecated by Gtk.StyleContext. If you mention it the next time, the >> revie

Re: [Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-07 Thread Gonzalo Odiard
> > > * API changed in the drag and drop code in Gtk > > * Changes in the way to get color information from the theme. > > I would also add in the message that this is because Gtk.Style was > deprecated by Gtk.StyleContext. If you mention it the next time, the > review can be faster too :) > > Be

Re: [Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-07 Thread Manuel QuiƱones
Thanks Gonzalo. 2012/8/7 : > From: Gonzalo Odiard > > This patch solves the following problems: > > * API changed in the drag and drop code in Gtk > * Changes in the way to get color information from the theme. I would also add in the message that this is because Gtk.Style was deprecated by Gtk

Re: [Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-07 Thread Benjamin Berg
On Tue, 2012-08-07 at 16:06 -0300, godi...@sugarlabs.org wrote: > From: Gonzalo Odiard > > This patch solves the following problems: > > * API changed in the drag and drop code in Gtk > * Changes in the way to get color information from the theme. > * The internal button was not visible. > > Si

Re: [Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-07 Thread Gonzalo Odiard
This patch is needed by Paint port to Gtk3, but can be tested applying the following patch to HelloWorld activity: diff --git a/activity.py b/activity.py index 2252983..96ee5d3 100644 --- a/activity.py +++ b/activity.py @@ -28,6 +28,8 @@ from sugar3.activity.widgets import TitleEntry from sugar3.

[Sugar-devel] [sugar-toolkit-gtk3] Finish the port of ColorToolButton to gtk3

2012-08-07 Thread godiard
From: Gonzalo Odiard This patch solves the following problems: * API changed in the drag and drop code in Gtk * Changes in the way to get color information from the theme. * The internal button was not visible. Signed-of-by: Gonzalo Odiard --- src/sugar3/graphics/colorbutton.py | 30 +