2012/9/19 Gonzalo Odiard :
> Today we explored with Simon different alternatives:
> (icon_name is a property of Gtk.Gtk.RadioToolButton, but is not set in the
> same way,
> and the button looks bigger)
>
> I think we should have a consistent API, doing the same than in toolbutton.
Yeah thanks Gonz
Hi Gonzalo,
thanks for this great writeup!
On 09/19/2012 09:13 PM, Gonzalo Odiard wrote:
> Today we explored with Simon different alternatives:
>
> - override the icon-name property and fallback to what we do in
> set_named_icon
> - override the icon-name property and print a warning to use 'nam
Today we explored with Simon different alternatives:
- override the icon-name property and fallback to what we do in
set_named_icon
- override the icon-name property and print a warning to use 'named_icon'
- override the icon-name property, do what we do in set_named_icon and
remove the named_icon
Oh wait I overlooked this. What's the benefit of having two
properties exactly the same? I would vote to use named_icon as in the
constructor, and change Paint.
2012/9/18 Manuel Quiñones :
> Thanks Gonzalo. Yes this fixes the regression, which was affecting
> Paint, and may affect other ports so
Thanks Gonzalo. Yes this fixes the regression, which was affecting
Paint, and may affect other ports so I vote for adding this instead of
deprecating the API. So now both:
radial_button = RadioToolButton(named_icon='view-radial')
and:
radial_button = RadioToolButton()
radial_button.props.icon_
From: Gonzalo Odiard
With g-i bindings, setting the property don't change the size
and the button is bigger than should be.
Now we have two properties for the same, icon_name and named_icon,
maybe one should be deprecated.
Signed-off-by: Gonzalo Odiard
---
src/sugar3/graphics/radiotoolbutton.p
6 matches
Mail list logo
