Re: [Sugar-devel] Code review (was: Re: [PATCH] Added Protected-Activities-Support to sugar (SL#2087))

2010-09-09 Thread Tomeu Vizoso
On Wed, Sep 8, 2010 at 22:47, Daniel Drake d...@laptop.org wrote: On 8 September 2010 14:44, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: If there's consensus that we want to stay with the method first chosen by the submitter, then I'll refrain from doing that in the future and

[Sugar-devel] Code review (was: Re: [PATCH] Added Protected-Activities-Support to sugar (SL#2087))

2010-09-08 Thread Sascha Silbe
Excerpts from Daniel Drake's message of Wed Sep 08 21:34:33 +0200 2010: Where a review process has started on trac, please keep the patch reviews on trac. That's probably my fault, I've been referring people from Trac to the mailing list for review. My assumption was that they're simply not

Re: [Sugar-devel] Code review (was: Re: [PATCH] Added Protected-Activities-Support to sugar (SL#2087))

2010-09-08 Thread Daniel Drake
On 8 September 2010 14:44, Sascha Silbe sascha-ml-reply-to-201...@silbe.org wrote: If there's consensus that we want to stay with the method first chosen by the submitter, then I'll refrain from doing that in the future and will concentrate on patches submitted on the mailing list. I think