Re: [Sugar-devel] Pull requests + buildbot

2014-04-07 Thread Daniel Narvaez
Did you see the details link? It's the same link we receive by email. On Monday, 7 April 2014, Gonzalo Odiard godi...@sugarlabs.org wrote: Nice trick. Is possible add a comment with the build result, then we receive a mail? (Or at least in the fail case) Gonzalo On Sun, Apr 6, 2014 at

Re: [Sugar-devel] Pull requests + buildbot

2014-04-07 Thread Gonzalo Odiard
I asked because I received the mails yesterday for every pull request, and then when was opened and closed, but not when a build failed. Even in Test breaking build (#332) May be is only received by who sent the pr? Gonzalo On Mon, Apr 7, 2014 at 6:23 AM, Daniel Narvaez dwnarv...@gmail.com

Re: [Sugar-devel] Pull requests + buildbot

2014-04-07 Thread Daniel Narvaez
I probably added some confusion with my testing. Some of those emails was me opening/closing pull requests etc. I'm not completely sure, but I suspect no emails are sent at all for this, the idea being that when a reviewer looks at the pull request the status will almost certainly be there. Though

Re: [Sugar-devel] Pull requests + buildbot

2014-04-06 Thread Manuel QuiƱones
2014-04-05 21:51 GMT-03:00 Daniel Narvaez dwnarv...@gmail.com: Hey, I have finally setup integration between pull requests and buildbot. When you push a pull request buildbot will trigger a build and update the github UI to indicate success or failure. The idea is that we should not

Re: [Sugar-devel] Pull requests + buildbot

2014-04-06 Thread Daniel Narvaez
It starts a build whenever a pr is opened or reopened, while it's building it shows that there is a build pending, then it changes the status to success/failure. It also starts a new build if commits are added or changed. On 6 April 2014 21:17, Manuel QuiƱones ma...@laptop.org wrote:

Re: [Sugar-devel] Pull requests + buildbot

2014-04-06 Thread Gonzalo Odiard
Nice trick. Is possible add a comment with the build result, then we receive a mail? (Or at least in the fail case) Gonzalo On Sun, Apr 6, 2014 at 6:20 PM, Daniel Narvaez dwnarv...@gmail.com wrote: It starts a build whenever a pr is opened or reopened, while it's building it shows that there

[Sugar-devel] Pull requests + buildbot

2014-04-05 Thread Daniel Narvaez
Hey, I have finally setup integration between pull requests and buildbot. When you push a pull request buildbot will trigger a build and update the github UI to indicate success or failure. The idea is that we should not normally merge a pull request unless the build was successful. You can