Re: [Sugar-devel] activity instance directory

2016-01-20 Thread James Cameron
Thanks, I await your testing of my pull request. On Thu, Jan 21, 2016 at 07:13:47AM +0200, Tony Anderson wrote: > Hi, James > > It would seem the correct solution is to have Sugar implement > the procedure specified in the 'low level activity'. The instance folder > should be cleared when the

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread Tony Anderson
Hi, James It would seem the correct solution is to have Sugar implement the procedure specified in the 'low level activity'. The instance folder should be cleared when the activity quits. If an activity needs longer persistence, it can put the file in the data folder and then manage it. The

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread James Cameron
We can't know what is wrong, because the logs aren't available, but my guess is one or more downloads were started, and the total for the day reached 1.2 Gb. That's all it takes. Downloads in progress are invisible to a user of Browse, so it is an easy mistake to make. For data shared between

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread James Cameron
Tony, Please test this pull request; https://github.com/sugarlabs/sugar-toolkit-gtk3/pull/306 "Remove Rainbow, clear activity instance/ and tmp/ Sugar depended on Rainbow for clearing the activity instance/ and tmp/ directories. But Rainbow is no longer used downstream. - remove support for

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread Sam P.
Thanks for the good analysis James! I don't think that deleting on startup is an optimal idea. It is counter-intuitive that the user must open every activity on their computer when they want to reclaim space. It is also bad in the case of infrequently used activities. I think that a

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread James Cameron
G'day Sam, The pull request I've made will handle a preserved .sugar directory on upgrade by deleting the directories the next time an activity is started, as well as when an activity is closed or crashes. Implemented in the shell, or sugar-launch, or activity to activity start, on behalf of the

Re: [Sugar-devel] activity instance directory

2016-01-20 Thread Gonzalo Odiard
A few issues: * Browse already have a mechanism to remove the temporary downloaded files, we need to know what is wrong [1]. * Temporary directories are shared between instances, if we remove temporary directories at activity start or stop, we need check if there are other instances of the

Re: [Sugar-devel] activity instance directory

2016-01-19 Thread James Cameron
The API documentation was wrong, and has been edited. https://wiki.sugarlabs.org/go/Development_Team/Low-level_Activity_API Rainbow did delete instance and tmp. Sugar did not. Rainbow has not been in OLPC OS for some time. (/etc/olpc-security must exist, /usr/bin/rainbow-run must be