On Wed, 2010-10-13 at 13:03 +0200, Tomeu Vizoso wrote:
On Wed, Oct 13, 2010 at 12:57, Simon Schampijer si...@schampijer.de wrote:
On 10/13/2010 10:49 AM, Tomeu Vizoso wrote:
[adding the IAEP, marketing and systems mailing lists]
Can someone that has access please just make this change.
The patch disables the Start and Start With menu items for files
which can't be opened by any installed activity and instead
replace it with a hover dropdown with a menu item 'No activity
installed to start entry'
---
src/jarabe/journal/palettes.py | 38 +++---
1
Please find the explanation to the patch in the comments.
On Fri, Oct 15, 2010 at 4:19 PM, Mukul Gupta mu...@seeta.in wrote:
The patch disables the Start and Start With menu items for files
which can't be opened by any installed activity and instead
replace it with a hover dropdown with a
Aleksey, James,
Thank you. Appreciate your feedback.
I have resubmitted a revised patch as per pep8 standards
http://lists.sugarlabs.org/archive/sugar-devel/2010-October/027863.html
James,
resume_label = _('No activity installed to start entry')
For now, I have kept the wordings to be as per
Hi,
patches are accumulating as we wait for 0.90 branches in Pootle.
Anybody opposes to branching now in git?
I'm under the impression that this will mean that translators won't be
able to commit translations for 0.90 until such branches are created.
Sayamindu, do you think you could find some
On Fri, Oct 15, 2010 at 7:06 AM, Mukul Gupta mu...@seeta.in wrote:
Please find the explanation to the patch in the comments.
On Fri, Oct 15, 2010 at 4:19 PM, Mukul Gupta mu...@seeta.in wrote:
The patch disables the Start and Start With menu items for files
which can't be opened by any
On Thu, Oct 14, 2010 at 20:09, godi...@sugarlabs.org wrote:
From: Gonzalo Odiard godi...@sugarlabs.org
This is a regresion, probably introduced when changed the toolbar.
May be pass self.abiword_canvas and self to ImageToolbar is not the smarter
option.
You are right, would be better if
On Fri, Oct 15, 2010 at 04:19:43PM +0530, Mukul Gupta wrote:
The patch disables the Start and Start With menu items for files
which can't be opened by any installed activity and instead
replace it with a hover dropdown with a menu item 'No activity
installed to start entry'
---
Hi--I can add this information this weekend.
Christian
On Oct 15, 2010, at 6:36 AM, Bernie Innocenti ber...@codewiz.org
wrote:
On Wed, 2010-10-13 at 13:03 +0200, Tomeu Vizoso wrote:
On Wed, Oct 13, 2010 at 12:57, Simon Schampijer
si...@schampijer.de wrote:
On 10/13/2010 10:49 AM, Tomeu
Previously registration url was set hardcoded for XO device.
Modififed the code for same behavior on all devices. Register
url is taken from gconf prop. If the gconf is empty or unset,
registration url falls back to 'schoolserver'.
---
src/jarabe/desktop/schoolserver.py |9 ++---
1 files
On Thu, Oct 14, 2010 at 5:35 PM, Paul Fox p...@laptop.org wrote:
sascha wrote:
Excerpts from Gonzalo Odiard's message of Thu Oct 14 22:09:09 +0200
2010:
It's simple and it's explained in http://dev.laptop.org/ticket/10396
At least in Read (and in most if not all activities), the
On 10/15/2010 02:04 PM, Tomeu Vizoso wrote:
Hi,
patches are accumulating as we wait for 0.90 branches in Pootle.
Anybody opposes to branching now in git?
No, let's do it. Thought about it several times already myself.
Regards,
Simon
___
On Fri, Oct 15, 2010 at 17:00, Gonzalo Odiard godi...@sugarlabs.org wrote:
On Fri, Oct 15, 2010 at 8:36 AM, Tomeu Vizoso to...@sugarlabs.org wrote:
On Thu, Oct 14, 2010 at 20:09, godi...@sugarlabs.org wrote:
From: Gonzalo Odiard godi...@sugarlabs.org
This is a regresion, probably
On 10/15/2010 12:30 AM, Lucian Branescu Mihaila wrote:
== Source ==
http://download.sugarlabs.org/sources/sucrose/fructose/Browse/Browse-119.tar.bz2
== News ==
This is a bugfix release.
* Release 119 (Lucian Branescu Mihaila)
* generate preview image for downloaded images (SL#1106) (Gonzalo
What is the status of the other maintainers?
I can volunteer to be co-co-maintainer :)
Gonzalo
On Fri, Oct 15, 2010 at 12:05 PM, Tomeu Vizoso to...@sugarlabs.org wrote:
On Fri, Oct 15, 2010 at 17:00, Gonzalo Odiard godi...@sugarlabs.org
wrote:
On Fri, Oct 15, 2010 at 8:36 AM, Tomeu
Make sugar-datastore as PEP8 / pylint clean as possible (again). All remaining
complaints are pylint bugs (doesn't recognise keyword arguments in decorators)
resp. shortcomings in pep8 (cannot selectively disable a warning for a
specific piece of code).
Sascha Silbe (3):
PEP8 cleanups
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py
index 9eb975f..5f518ab 100644
--- a/src/carquinyol/filestore.py
+++ b/src/carquinyol/filestore.py
@@ -155,7 +155,8 @@ class FileStore(object):
os.remove(file_path)
No other name I can think of is a better fit and no external code is using
this class, so it isn't an issue.
Disabling the warning reduces pylint clutter and makes it easier to spot real
issues.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/carquinyol/indexstore.py
Caught by pylint.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/carquinyol/datastore.py b/src/carquinyol/datastore.py
index 86d5b02..28d7247 100644
--- a/src/carquinyol/datastore.py
+++ b/src/carquinyol/datastore.py
@@ -19,7 +19,6 @@ import logging
import uuid
import time
On 15 October 2010 17:15, Simon Schampijer si...@schampijer.de wrote:
On 10/15/2010 12:30 AM, Lucian Branescu Mihaila wrote:
== Source ==
http://download.sugarlabs.org/sources/sucrose/fructose/Browse/Browse-119.tar.bz2
== News ==
This is a bugfix release.
* Release 119 (Lucian Branescu
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics/palettewindow.py
index fcdc2e3..81540e3 100644
--- a/src/sugar/graphics/palettewindow.py
+++ b/src/sugar/graphics/palettewindow.py
@@ -147,6 +147,7 @@ class
This is the sugar-toolkit part of the style cleanups I've wanted to
land at least two releases ago, but kept missing the window.
I have done some basic testing, but naturally cannot test all code
paths I've touched (some even appear to be unused). This is why I'd like
to land this right after we
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activityhandle.py
b/src/sugar/activity/activityhandle.py
index 4aeac71..b29973e 100644
--- a/src/sugar/activity/activityhandle.py
+++ b/src/sugar/activity/activityhandle.py
@@ -69,7 +69,7 @@ class
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 0094693..e3654d8 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -928,7 +928,7 @@ class _ClientHandler(dbus.service.Object,
pep8 wants inline comments to be prefixed by at least two spaces. Let's just
move them to a separate line as that's easier to read anyway.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/graphics/icon.py b/src/sugar/graphics/icon.py
index 100f05a..ea3a9c0 100644
---
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py
index 3f5188e..2b01366 100644
--- a/src/sugar/datastore/datastore.py
+++ b/src/sugar/datastore/datastore.py
@@ -153,7 +153,7 @@ class DSObject(object):
return
Caught by pep8.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/examples/radiopalette.py b/examples/radiopalette.py
index 85b43ce..f8336bd 100644
--- a/examples/radiopalette.py
+++ b/examples/radiopalette.py
@@ -17,6 +17,7 @@ box.pack_start(toolbar, False)
text_view =
has_key() has been deprecated for quite some time now.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 183d4a8..0094693 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -256,7
We know that our code is correct and column should always be assigned, but it
never hurts to act defensively and guard against bugs in other pieces of the
code (or other components like GTK).
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/graphics/palettewindow.py
Caught by PEP8. This is important for Sugar because the XO has a small screen
where long lines would make the code hard to understand (because you need to
constantly scroll horizontally).
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py
I've left the powers as-is because IMO they should directly follow the base,
unlike other operators.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/bundlebuilder.py
b/src/sugar/activity/bundlebuilder.py
index fc8ebc8..2952d71 100644
---
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/presence/connectionmanager.py
b/src/sugar/presence/connectionmanager.py
index 78b744e..502b7a8 100644
--- a/src/sugar/presence/connectionmanager.py
+++ b/src/sugar/presence/connectionmanager.py
@@ -24,8 +24,7 @@ from
format is the name of a parameter of the function we are wrapping, so we
shouldn't change it.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index 00c6fd0..8f1903f 100644
--- a/src/sugar/wm.py
+++ b/src/sugar/wm.py
@@ -38,6 +38,7 @@ def
This avoids the overhead from the string formatting on production systems.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/wm.py b/src/sugar/wm.py
index eaa196e..00c6fd0 100644
--- a/src/sugar/wm.py
+++ b/src/sugar/wm.py
@@ -32,7 +32,7 @@ def _property_get_trapped(window,
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activity.py b/src/sugar/activity/activity.py
index 64bc840..7229096 100644
--- a/src/sugar/activity/activity.py
+++ b/src/sugar/activity/activity.py
@@ -823,6 +823,7 @@ class Activity(Window, gtk.Container):
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/graphics/style.py b/src/sugar/graphics/style.py
index d5f82ff..7f48d9a 100644
--- a/src/sugar/graphics/style.py
+++ b/src/sugar/graphics/style.py
@@ -83,7 +83,7 @@ class Color(object):
if html_color[0] == '#':
Most of the code uses , so adjust the few deviations.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/bundlebuilder.py
b/src/sugar/activity/bundlebuilder.py
index 7bf02ed..d058b55 100644
--- a/src/sugar/activity/bundlebuilder.py
+++
pylint isn't smart enough to figure out the return type of Popen.communicate(),
so squelch the warning.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/bundlebuilder.py
b/src/sugar/activity/bundlebuilder.py
index 1d7b613..60721d3 100644
---
Adapt to upstream format change.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/activity/activityfactory.py
b/src/sugar/activity/activityfactory.py
index 6bd661f..a206d15 100644
--- a/src/sugar/activity/activityfactory.py
+++ b/src/sugar/activity/activityfactory.py
@@
logging.exception() handles exceptions nicely for us, no need to explicitly
use traceback.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/util.py b/src/sugar/util.py
index 889cc62..e0a431b 100644
--- a/src/sugar/util.py
+++ b/src/sugar/util.py
@@ -29,7 +29,6 @@ import
Caught by pylint. I wonder if we need this piece of code as nobody every
triggered it.
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/src/sugar/graphics/palettewindow.py
b/src/sugar/graphics/palettewindow.py
index 81540e3..c5deecd 100644
--- a/src/sugar/graphics/palettewindow.py
Tomeu prefers ' for strings, so let's use it wherever we don't have a good
reason to use .
Signed-off-by: Sascha Silbe sascha-...@silbe.org
diff --git a/examples/radiopalette.py b/examples/radiopalette.py
index f8336bd..3117aec 100644
--- a/examples/radiopalette.py
+++ b/examples/radiopalette.py
Excerpts from Simon Schampijer's message of Fri Oct 15 17:54:14 +0200 2010:
On 10/15/2010 02:04 PM, Tomeu Vizoso wrote:
patches are accumulating as we wait for 0.90 branches in Pootle.
Anybody opposes to branching now in git?
No, let's do it. Thought about it several times already
Excerpts from Manusheel Gupta's message of Sat Oct 09 04:46:02 +0200 2010:
Ishan tried to add the tag - Coauthored by in his patch, and that line
gets scrubbed off.
Have you added it right at the end, like you would do with the
Reviewed-By: tag? E.g.:
(assuming author is set to Shanjit Singh
Excerpts from Gonzalo Odiard's message of Thu Oct 14 22:23:35 +0200 2010:
Please mention the module name as part of the patch summary, e.g.:
[PATCH Write] keep file type across load/save (SL #2127)
The subject is created by git send-email. I can change the first line from
the patch,
Excerpts from shanjit's message of Fri Oct 15 23:37:42 +0200 2010:
Downgrading an activity is now made possible. [...]
You've told git send-email to mark your patch as a reply to some message
that I've not only never received, but that's also the same as the one
referenced by a totally
46 matches
Mail list logo
