Re: [Sugar-devel] [DESIGN] List View of Activities (hovering stars)

On Sat, Sep 29, 2012 at 6:00 PM, Gary Martin garycmar...@googlemail.com wrote: So if the star is currently enabled (colorized) and you hover over it, you'll first see the grey rounded rectangle outline, then if you click/press it you will still see the grey rectangle outline and the star will

Re: [Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317

On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: This gives us more complete coverage of cases where ENOSPC or other errors are hit when creating/updating datastore entries. I reviewed this patch and I think it's OK. I didn't test it because I'm not sure how to

Re: [Sugar-devel] [PATCH 2/7] Remove invalid/corrupt on-disk entries #2317

On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: When operating close to ENOSPC, we sometimes end up with incomplete or invalid on-disk entries. So we prune these during index rebuild. I took a look at this patch and it seems to be OK. -- Kaufmann Manuel Blog:

Re: [Sugar-devel] [PATCH 3/7] metadatastore: store/change files on disk defensively #2317

Hi, I reviewed this patch and it seems to be OK for me. The only thing that I do not understand well is this comment / section. Can you explain to me this a bit more? Thanks On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: +# FIXME: this codepath handles raw