Re: [Sugar-devel] [DESIGN] List View of Activities (hovering stars)
On Sat, Sep 29, 2012 at 6:00 PM, Gary Martin garycmar...@googlemail.com wrote: So if the star is currently enabled (colorized) and you hover over it, you'll first see the grey rounded rectangle outline, then if you click/press it you will still see the grey rectangle outline and the star will change immediately to disabled (uncolorized star), as you release and move the mouse away the grey rounded rectangle outline will disappear. If the star is currently disabled (uncolorized) and you hover over it, you'll first see the grey rounded rectangle outline, then if you click/press it you will still see the grey rectangle outline and the star will change immediately to enabled (colorized star), as you release and move the mouse away the grey rounded rectangle outline will disappear. Cool! This is exactly what I tried to write. Thanks to clarify it. -- Kaufmann Manuel Blog: http://humitos.wordpress.com/ Porfolio: http://fotos.mkaufmann.com.ar/ PyAr: http://www.python.com.ar/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH 1/7] Add ds_clean flag to trigger index rebuilds #2095, #2317
On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: This gives us more complete coverage of cases where ENOSPC or other errors are hit when creating/updating datastore entries. I reviewed this patch and I think it's OK. I didn't test it because I'm not sure how to simulate that scenario. Just a comment: why you didn't add a callback function (_delete_completion_cb) to the delete method and make create / update / delete consistent between them? In that method we can add self._mark_clean Thought: we are dealing near ENOSPC, right? So, maybe the clean_flag will not be created (this is already handled in the patch) and this patch will not take effect the next time the XO restarts and we will be in the same situation again. -- Kaufmann Manuel Blog: http://humitos.wordpress.com/ Porfolio: http://fotos.mkaufmann.com.ar/ PyAr: http://www.python.com.ar/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH 2/7] Remove invalid/corrupt on-disk entries #2317
On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote: When operating close to ENOSPC, we sometimes end up with incomplete or invalid on-disk entries. So we prune these during index rebuild. I took a look at this patch and it seems to be OK. -- Kaufmann Manuel Blog: http://humitos.wordpress.com/ Porfolio: http://fotos.mkaufmann.com.ar/ PyAr: http://www.python.com.ar/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH 3/7] metadatastore: store/change files on disk defensively #2317
Hi,
I reviewed this patch and it seems to be OK for me.
The only thing that I do not understand well is this comment /
section. Can you explain to me this a bit more? Thanks
On Fri, Sep 21, 2012 at 12:55 AM, Martin Langhoff mar...@laptop.org wrote:
+# FIXME: this codepath handles raw image data
+# str() is 8-bit clean right now, but
+# this won't last. We will need more explicit
+# handling of strings, int/floats vs raw data
+if isinstance(value, unicode):
+value = value.encode('utf-8')
+elif not isinstance(value, basestring):
+value = str(value)
--
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
