Shaan,
* the sources are different, and this is not unusual, and not a problem worth
reporting unless an explanation cannot be found,
* the commits in salsa explain the reason for every difference.
Now that you have detected a difference, please make sure you read the commits,
in all aspects;
* the commit message,
* the commit diff,
* the context or ordering in which the diff occurs.
The diff format must be learned to the point you can be comfortable to make a
change by hand. Not that you have to; tools like patch(1) can do it for you,
but sometimes a diff is malformed when it is sent by other means than git.
On Tue, Jun 09, 2020 at 06:29:10PM +0100, Chihurumnaya Ibiam wrote:
> Thanks for the update.
>
> Both files in the Debian salsa repo and the github repo have matching lines
> and
> I'm also guessing the file at
> the installed /usr/share/activities/browseactivity will also have matching -
> can you confirm if it does? - lines
> but the traceback prints the wrong lines.
>
> --
>
> Ibiam Chihurumnaya
> [1]ibiamchihurumn...@gmail.com
>
> On Tue, Jun 9, 2020 at 6:02 PM [2]shaansubbaiah.c...@bmsce.ac.in <[3]
> shaansubbaiah.c...@bmsce.ac.in> wrote:
>
> Hello Ibiam,
>
> Comparing browse.py in:
>
> 1. Github repository [4]https://github.com/sugarlabs/browse-activity/
> 2. Debian Salsa repository [5]https://salsa.debian.org/pkg-sugar-team/
> sugar-browse-activity/-/blob/master/browser.py
> 3. The installed activity at /usr/share/activities/browseactivity
>
> The Github and Salsa versions have matching line numbers. Difference
> between the Github and installed versions:
>
> --- bgit # browse.py in Github
> +++ bdeb # installed browse.py
> @@ -110,15 +110,13 @@
> [
> '',
> '',
> -' -'path="/org/laptop/WebActivity/">',
> -'',
> -"''",
> -'Home page URL',
> -'URL to show as default or when home
> button '
> -'is pressed.',
> -'',
> -'',
> +' path="/org/laptop/WebActivity/">',
> +'',
> +"''",
> +'Home page URL',
> +'URL to show as default or
> when home button is pressed.',
> +'',
> +'',
> '',
> ]
> open(os.path.join(path, src), 'w').writelines(lines)
>
> Seems the only difference was the lines that was split into new lines have
> been concatenated to a single line.
>
> Best,
> Shaan
>
> On Monday, 8 June, 2020, 10:19:48 pm IST, Chihurumnaya Ibiam <[6]
> ibiamchihurumn...@gmail.com> wrote:
>
> You might have to include it as a dependency for your next release as
> that's the latest version
> that Browse currently has, what doesn't sit well with me is the line
> difference, I can't do any
> investigation at the moment but it'll be great if you took a look at the
> source code to confirm the line
> differences. Thanks.
>
> --
>
> Ibiam Chihurumnaya
> [7]ibiamchihurumn...@gmail.com
>
>
>
> On Mon, Jun 8, 2020 at 7:46 AM [8]shaansubbaiah.c...@bmsce.ac.in <[9]
> shaansubbaiah.c...@bmsce.ac.in> wrote:
>
> Hello Ibiam,
> The version of the browse-activity installed was 205-2.
>
> Sorry for the late reply, temporarily away from home, I'm on a
> different system testing Sugar and internet bandwidth isn't very high.
> Should be back in a day or two.
>
> Best,
> Shaan
>
> On Sunday, 7 June, 2020, 3:50:23 am IST, Chihurumnaya Ibiam <[10]
> ibiamchihurumn...@gmail.com> wrote:
>
> Thanks Shaan, what version of Browse are you running as the lines in
> the traceback are off
> from the latest version?
>
> --
>
> Ibiam Chihurumnaya
> [11]ibiamchihurumn...@gmail.com
>
>
>
> On Sat, Jun 6, 2020 at 6:58 PM [12]shaansubbaiah.c...@bmsce.ac.in
> <[13]
> shaansubbaiah.c...@bmsce.ac.in> wrote:
>
> Hello Ibiam,
> Installing the libglib2.0-dev package fixes the issue. I have also
> just found that this issue is mentioned in the browse-activity
> readme '' Unusually, Browse also depends on glib-compile-schemas
> to
> compile a Gio.Settings schema. ''.
>
> Online searches also return similar results, eg. :
> [14]https://askubuntu.com/questions/204643/
> getting-missing-dependency-for-compilation-glib-compile-schemas
> and
>
