Re: [Sugar-devel] [PATCH] adding sugar source radio button to view source toolbar

2011-07-02 Thread Sascha Silbe
Excerpts from Walter Bender's message of Sat Jul 02 21:51:49 +0200 2011: On Sat, Jul 2, 2011 at 2:27 PM, Sascha Silbe si...@activitycentral.com wrote: Excerpts from Walter Bender's message of Mon Jun 06 20:26:05 +0200 2011: [Sugar source and Copy to bundle patches

[Sugar-devel] [PATCH sugar] Frame: Show windows that were already mapped during Sugar start-up

2011-07-01 Thread Sascha Silbe
We won't receive callbacks for windows that were already mapped before ShellModel gets instantiated because we can only connect to the signals afterwards. Signed-off-by: Sascha Silbe si...@activitycentral.com --- src/jarabe/frame/activitiestray.py |3 +++ 1 files changed, 3 insertions(+), 0

Re: [Sugar-devel] [DESIGN] [PATCH sugar] Add support for removing connections / forgetting network credentials

2011-07-01 Thread Sascha Silbe
Excerpts from Gary Martin's message of Mon Jun 27 04:15:41 +0200 2011: On 26 Jun 2011, at 20:38, Sascha Silbe si...@activitycentral.com wrote: Let the user remove the settings for individual networks in addition to the all-or-nothing approach Discard network history in the Control Panel

Re: [Sugar-devel] [PATCH sugar] Gabble: do not add ourself to the model twice OLPC #10965

2011-07-01 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Sun Jun 26 15:19:49 +0200 2011: We do add ourself to the model by default. When we are connected to the server it often gives us as well ourself back. I wonder why some servers do this, but don't see any harm in your change. Acked-By: Sascha Silbe

Re: [Sugar-devel] [PATCH sugar] Add missing import (follow up of OLPC #10798)

2011-07-01 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Fri Jul 01 15:58:16 +0200 2011: This is a regression fix introduced by OLPC #10798. Maybe: This is a fix for a regression introduced by commit 9d0d372 (Raise alert when trying to send an entry without an associated file OLPC #10798). Acked-By: Sascha

[Sugar-devel] [PATCH v2 sugar] Wireless network Frame device: add suport for disabling wireless devices

2011-06-30 Thread Sascha Silbe
This duplicates the existing functionality in the Control Panel for more convenient access. Disabling wifi devices can save power, thereby increasing battery life. Signed-off-by: Sascha Silbe si...@activitycentral.com --- v1-v2: Set primary palette text I didn't change the option labels because

[Sugar-devel] [PATCH sugar] Wireless network Frame device: Add text for disconnected state

2011-06-30 Thread Sascha Silbe
Showing just an empty palette whenever we are disconnected (e.g. because no favourite AP is in range) is rather confusing for users. Signed-off-by: Sascha Silbe si...@activitycentral.com --- This patch changes the appearance [1] for the case that wifi is enabled. I'll post an updated patch

[Sugar-devel] [PATCH Browse] Start password manager

2011-06-30 Thread Sascha Silbe
] http://wiki.sugarlabs.org/go/File:Browse-save-password.png Signed-off-by: Sascha Silbe si...@activitycentral.com --- webactivity.py |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/webactivity.py b/webactivity.py index dade56a..3c02e03 100644 --- a/webactivity.py +++ b

[Sugar-devel] [DESIGN] [PATCH RFC sugar] Wireless network Frame device: add suport for disabling wireless devices

2011-06-27 Thread Sascha Silbe
This duplicates the existing functionality in the Control Panel for more convenient access. Disabling wifi devices can save power, thereby increasing battery life. Signed-off-by: Sascha Silbe si...@activitycentral.com --- This is fully working but I'm not sure about the correct way to change

Re: [Sugar-devel] [PATCH Browse 0/2] Add support for Export as PDF

2011-06-26 Thread Sascha Silbe
Excerpts from Christoph Derndorfer's message of Sat Jun 04 22:20:08 +0200 2011: (1) Are you suggesting that rather than being able to print directly from an activity users will have to export whatever they want to print to PDF, then launch a separate activity or go into the Journal to start

[Sugar-devel] [PATCH sugar 0/2] Escape user data and translations in markup

2011-06-26 Thread Sascha Silbe
passed to other widgets needs to be escaped as well. Sascha Silbe (2): Escape all text passed to Palette.primary_text and .secondary_text Escape all text passed to MenuItem.text_label extensions/deviceicon/network.py |5 ++- src/jarabe/desktop/activitieslist.py |4 ++- src/jarabe

[Sugar-devel] [PATCH sugar 1/2] Escape all text passed to Palette.primary_text and .secondary_text

2011-06-26 Thread Sascha Silbe
sugar.graphics.palette.Palette passes primary_text and secondary_text through to GTK without escaping it, so we need to make sure it doesn't contain anything special in user data (activity title, bundle_id, nick name, etc.) or translations. Signed-off-by: Sascha Silbe si...@activitycentral.com

[Sugar-devel] [PATCH sugar 2/2] Escape all text passed to MenuItem.text_label

2011-06-26 Thread Sascha Silbe
sugar.graphics.menuitem.MenuItem passes text_label through to GTK without escaping it, so we need to make sure it doesn't contain anything special in user data or translations. Signed-off-by: Sascha Silbe si...@activitycentral.com --- extensions/deviceicon/network.py |3 +- src/jarabe

[Sugar-devel] [DESIGN] [PATCH sugar] Add support for removing connections / forgetting network credentials

2011-06-26 Thread Sascha Silbe
Let the user remove the settings for individual networks in addition to the all-or-nothing approach Discard network history in the Control Panel. Signed-off-by: Sascha Silbe si...@activitycentral.com --- First shot at the Forget this favourite network option we discussed at [1]. There's

Re: [Sugar-devel] [DESIGN] icons for import/export document proposal

2011-06-20 Thread Sascha Silbe
Excerpts from Gary Martin's message of Sun Jun 19 18:20:54 +0200 2011: Just caught up with the 2nd half of last weeks meeting and thought I'd pass along a screenshot of the Labryinth activity toolbar as it includes export icons for both pdf and png objects:

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779 / SL #2499

2011-06-18 Thread Sascha Silbe
Excerpts from godiard's message of Wed Jun 08 17:09:14 +0200 2011: If the user go back, or select any page in the history and close the activity, need restore at the next start, the history, and the index in the history too. Thanks for the patch! Pushed as 7072ec5 [1]. Sascha [1]

Re: [Sugar-devel] [PATCH] Display build number at Name Page

2011-06-18 Thread Sascha Silbe
Excerpts from Esteban Bordón's message of Wed Jun 15 17:01:55 +0200 2011: This patch show the build number in the name page for first boot (see attached file). It's very useful to test the correct massive flashing for technical team. Nice idea. As for the patch, I wonder why you use different

Re: [Sugar-devel] [PATCH] Journal: Do not rescan external device if is not needed - OLPC #10841

2011-06-18 Thread Sascha Silbe
Excerpts from godiard's message of Fri Jun 17 16:20:03 +0200 2011: [src/jarabe/journal/listview.py] @@ -118,7 +118,8 @@ class BaseListView(gtk.Bin): model.deleted.connect(self.__model_deleted_cb) def __model_created_cb(self, sender, **kwargs): -self._set_dirty() +

Re: [Sugar-devel] FUSE for Journal?

2011-06-17 Thread Sascha Silbe
Excerpts from Sameer Verma's message of Fri Jun 17 20:27:46 +0200 2011: I've been messing with FUSE (http://en.wikipedia.org/wiki/Filesystem_in_Userspace) in another context (http://en.wikipedia.org/wiki/Tahoe_Least-Authority_Filesystem) and was wondering if the Sugar Journal would talk to

[Sugar-devel] [PATCH sugar] Make the Frame a pop-up window

2011-06-11 Thread Sascha Silbe
the override-redirect flag can guarantee this happens. [1] http://tronche.com/gui/x/icccm/sec-4.html#s-4.2.2 Signed-off-by: Sascha Silbe si...@activitycentral.com --- Like the sugar-toolkit patch, this isn't a problem with metacity, just notion (haven't tried any other window manager). There's

Re: [Sugar-devel] [PATCH sugar] Fix invitations from a non sugar client (empathy), part of OLPC #10814

2011-06-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Jun 08 19:15:56 +0200 2011: Yes, was the wrong patch, sorry. This is how it looks like now: Looks good, thanks. Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc

Re: [Sugar-devel] [PATCH sugar] Add copy-to option in the Journal

2011-06-08 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Jun 08 19:23:52 +0200 2011: [copy(): map get_file() == None to file_path = ''] We show an alert when you try to copy an entry without a file to an external device. But you are able to make a duplicate of an entry without a file (copy to

[Sugar-devel] [PATCH Browse] Clarify warning on Stop with pending downloads (SL#1508)

2011-06-07 Thread Sascha Silbe
-05-29T16:09:15.html Closes: SL#1508 Signed-off-by: Sascha Silbe si...@activitycentral.com --- downloadmanager.py |4 webactivity.py | 14 +++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/downloadmanager.py b/downloadmanager.py index a88389f..4eab726

Re: [Sugar-devel] [PATCH sugar] Register with schoolserver: adopt to changes in xmlrpclib for python 2.7 OLPC #10776

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon May 23 10:01:01 +0200 2011: I guess we don't need to subclass Transport, but we probably need to call socket.setdefaulttimeout() during Sugar start-up: [...] Hmm, yes sounds about right. I don't think we have to do it during sugar startup

Re: [Sugar-devel] [PATCH sugar-toolkit] Handle DBUS tubes in the activity telepathy client, part of OLPC #10738

2011-06-07 Thread Sascha Silbe
point out the exact version relationships in the Release Notes, of course. I don't want to block these patches any further, so in the hope that you'll write the Release Notes [1] entry explaining what non-Python activity authors need to change I give my: Acked-By: Sascha Silbe si

Re: [Sugar-devel] [PATCH] customize icon patch

2011-06-07 Thread Sascha Silbe
Excerpts from Walter Bender's message of Mon Jun 06 20:31:08 +0200 2011: Alas, git send-email would [not] accept this patch. Please see the attach patch (and icon). This icon is used by the new View Source copy bundle code. The reason is that you're using very long lines that cannot be

Re: [Sugar-devel] [PATCH sugar] Use the same wording for the filesize of an entry without a file SL #2880

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Jun 06 11:25:36 +0200 2011: The change has no impact on existing translations, since we use as well util.format_size when no filesize is specified. Acked-By: Sascha Silbe si...@activitycentral.com Thanks for the patch! Sascha -- http

Re: [Sugar-devel] [PATCH sugar] Make sure the entry has the right color when copying from external device to Journal SL #2690

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Fri Jun 03 12:38:03 +0200 2011: [src/jarabe/journal/model.py] @@ -615,6 +617,9 @@ def copy(metadata, mount_point): Copies an object to another mount point metadata = get(metadata['uid']) +if mount_point == '/' and

Re: [Sugar-devel] [PATCH sugar] Add copy-to option in the Journal

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Sun May 29 15:59:56 +0200 2011: If you look at 'get_file' [1], you can see that we return 'None' when there is not a file associated with the entry. This is the case for example for memorize activity entry. When we want to clone such an entry

Re: [Sugar-devel] [PATCH sugar] Fix invitations from a non sugar client (empathy), part of OLPC #10814

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue May 31 19:39:25 +0200 2011: [src/jarabe/model/invites.py] +class PrivateInvite(BaseInvite): [...] +def join(self): [...] +if bundle is None: +self._call_handle_with() Did you post the wrong patch? In your previous mail

Re: [Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-06-07 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon May 30 15:57:26 +0200 2011: Looks nice and simple but seems to be more complicated in practice: We don't follow changes to the activity title because the palette gets created just once in ActivityView.__init__(). I think it has to do with

Re: [Sugar-devel] [PATCH] Browse: Set and restore index in the history - Fix OLPC #10779

2011-06-07 Thread Sascha Silbe
Excerpts from godiard's message of Mon Jun 06 22:31:48 +0200 2011: If the user go back, or select any page in the history and close the activity, need restore at the next start, the history, and the index in the history too. Please mentions the upstream ticket (SL#2499 [1]) as well. I tried

[Sugar-devel] [DESIGN] NetworkManager / Neighborhood design changes

2011-06-05 Thread Sascha Silbe
[This is the source view in Wiki Creole 1.0. Feel free to view the rendered HTML version instead] Porting Sugar to the NetworkManager 0.9 API and enabling new use cases (including connecting to networks with hidden SSIDs) requires some design changes in both the Neighborhood and the Frame. To get

[Sugar-devel] [ANNOUNCE] sugar-jhbuild: no more Ubuntu support

2011-05-29 Thread Sascha Silbe
I am sad to announce that we are dropping Ubuntu support for sugar-jhbuild. Karmic Koala (9.10), the last version of Ubuntu that shipped all packages required to use Sugar (including all Fructose activities), has went end-of-life on 2011-05-01. Apart from a bug in the Ubuntu version of Xephyr

[Sugar-devel] [PATCH Browse 1/2] Generalise GetSourceListener to SaveListener

2011-05-29 Thread Sascha Silbe
Slightly enhance and rename GetSourceListener so it can be used for waiting for completion of any save operation, not just GetSource. Signed-off-by: Sascha Silbe si...@activitycentral.com --- browser.py | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff

[Sugar-devel] [PATCH Browse 0/2] Add support for Export as PDF

2011-05-29 Thread Sascha Silbe
won't get confused by multiple different ways to configure printing from within the various activities. Because PDF is a standard interchange format, this also enables more (and better!) ways of sharing documents (while preserving their exact form) than printing. Sascha Silbe (2): Generalise

[Sugar-devel] [PATCH Browse 2/2] Add support for exporting (printing) to PDF

2011-05-29 Thread Sascha Silbe
Signed-off-by: Sascha Silbe si...@activitycentral.com --- browser.py| 68 + webtoolbar.py | 10 2 files changed, 78 insertions(+), 0 deletions(-) diff --git a/browser.py b/browser.py index 649a71e..bd57e79 100644

[Sugar-devel] Non-maintainer uploads of activities

2011-05-28 Thread Sascha Silbe
Hi! I would like to propose adopting the Debian Non-Maintainer-Upload (NMU) process [1] for Fructose. Individual activity authors would also be encouraged to allow their activities to be NMU'ed following this policy. The sections I'd consider applicable to Sugar Labs are 5.11.1, 5.11.2 (read

Re: [Sugar-devel] [PATCH sugar-toolkit] Handle DBUS tubes in the activity telepathy client, part of OLPC #10738

2011-05-28 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon May 23 13:14:51 +0200 2011: On 04/16/2011 01:05 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Thu Apr 14 19:43:05 +0200 2011: This adds the handling of DBUS tube channels to the 'HandlerChannelFilter' in activity's

Re: [Sugar-devel] [PATCH sugar] Display title in palette of shared activity OLPC #10676

2011-05-28 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed May 25 15:57:34 +0200 2011: The patch does display the activity name as primary text and the session title as secondary text. This is coherent with the palette of an activity in the frame. Looks nice and simple but seems to be more complicated

Re: [Sugar-devel] [PATCH sugar] Raise alert when trying to send an entry without an associated file OLPC #10798

2011-05-28 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed May 25 18:30:45 +0200 2011: We raise the same error when we try to copy an entry without an associated file to an external device. Acked-By: Sascha Silbe si...@activitycentral.com Thanks for the patch! Do you know if there has been any progress

Re: [Sugar-devel] [PATCH sugar-toolkit] Only show joined buddies on sharer side, part of OLPC#10578

2011-05-28 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon May 23 17:43:45 +0200 2011: This is correct yes. Bad wording, better would be: Show joined buddies on both sides, part of OLPC #10578. OK, with that change: Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org

Re: [Sugar-devel] [PATCH sugar] Add copy-to option in the Journal

2011-05-28 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed May 25 00:53:36 +0200 2011: This will be part of replacing the keep button. The discussion is taking place at: http://lists.sugarlabs.org/archive/sugar-devel/2011-May/031316.html There are mockups and the implementation details. I like the

Re: [Sugar-devel] Fwd: [Sur] La bestia que renace una y otra vez

2011-05-25 Thread Sascha Silbe
Excerpts from Walter Bender's message of Wed May 25 14:36:59 +0200 2011: I will respond to this but would like to discuss it with the two of you first. (Assuming you mean the discussion to be open to everyone, but would like to invite Simon and me in particular as you CC'ed sugar-devel) I

Re: [Sugar-devel] [PATCH] adding support for Tuquito GNU/Linux distribution

2011-05-22 Thread Sascha Silbe
Excerpts from Alvar Maciel's message of Sun May 22 18:37:02 +0200 2011: Ok. Now I want to make deb packages of the stable version of sugar tu put in our ppa (https://launchpad.net/~paquetes-tuquito). And I have a question. Were I can download the sources of the last stable release to make

Re: [Sugar-devel] Browse activity

2011-05-21 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Fri May 20 19:42:34 +0200 2011: May be replacing Browse with Surf is the right solution, but in the short term we need work improving Browse. I can help reviewing patches and doing releases if you want. I might come back to that offer, thanks. However

Re: [Sugar-devel] [PATCH 1/3] adding svg mimetype SL#1772

2011-05-21 Thread Sascha Silbe
Excerpts from Rafael Ortiz's message of Fri May 20 22:32:59 +0200 2011: Adding support for svg mimetype on browse activity Pushed (with a different description) as 7964449 [1], thanks! Sascha [1] http://git.sugarlabs.org/browse/mainline/commit/7964449b0be7f941a533013b558a404db7873398 --

[Sugar-devel] [DESIGN] Re: [PATCH 3/3] better wording #1508 + pep8 fixes

2011-05-21 Thread Sascha Silbe
Excerpts from Rafael Ortiz's message of Fri May 20 22:36:09 +0200 2011: This patch proposes a better wording for cancel/stop buttons while exiting browse activity plus pep8 fixes for downloadmanager.py Your patch doesn't apply to current mainline master (even with git am -3). However I've

Re: [Sugar-devel] [DESIGN] [PATCH 3/3] better wording #1508 + pep8 fixes

2011-05-21 Thread Sascha Silbe
Excerpts from Sascha Silbe's message of Sat May 21 15:13:25 +0200 2011: I like the first change, but maybe we can still improve on the second one? Stop Download maybe? We keep the partially downloaded file in the Journal. I take that back. We _do_ delete all pending downloads (in the Journal)

[Sugar-devel] [PATCH Browse 2/2] Delete temporary files under all conditions

2011-05-21 Thread Sascha Silbe
-by: Sascha Silbe si...@activitycentral.com --- downloadmanager.py | 37 ++--- 1 files changed, 22 insertions(+), 15 deletions(-) diff --git a/downloadmanager.py b/downloadmanager.py index 934693f..a88389f 100644 --- a/downloadmanager.py +++ b/downloadmanager.py @@ -38,7

[Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-21 Thread Sascha Silbe
to close Browse). Signed-off-by: Sascha Silbe si...@activitycentral.com --- webactivity.py |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/webactivity.py b/webactivity.py index b444861..5f1ea5e 100644 --- a/webactivity.py +++ b/webactivity.py @@ -184,6 +184,7

Re: [Sugar-devel] Browse activity

2011-05-20 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Wed May 18 15:46:07 +0200 2011: According to git, nobody is working in Browse master. Lucian and me are the current maintainers [1]. However, we are already busy with other work and thus usually only handle patch review and releases, not work on Browse

Re: [Sugar-devel] [PATCH sugar] Register with schoolserver: adopt to changes in xmlrpclib for python 2.7 OLPC #10776

2011-05-20 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu May 19 16:08:36 +0200 2011: s/adopt/adapt/ (or adjust) Python 2.7 switched from using httplib.HTTP to using httplib.HTTPConnection, as the httplib.HTTPConnection includes a timeout by default we can use a xmlrpclib.Transport directly and do

Re: [Sugar-devel] [PATCH] adding support for Tuquito GNU/Linux distribution

2011-05-20 Thread Sascha Silbe
[Re-send to sugar-devel after accidentally sending privately] Excerpts from Alvar Maciel's message of Sat Apr 09 17:16:23 +0200 2011: Tuquito is a Ubuntu based distribution - http://www.tuquito.org.ar Made in Argentina our goal is to make an usable distribution whit support for educators from

Re: [Sugar-devel] [PATCH sugar] Anly approve and not handle channels in the shell, part of OLPC #10738

2011-05-20 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 28 21:18:31 +0200 2011: On 04/15/2011 06:47 PM, Sascha Silbe wrote: [...] Given that filt is non-empty, do we really need the explicit conversions? I.e. would the following work? No, we really need the explicit conversion: [error message

Re: [Sugar-devel] [PATCH sugar-toolkit] Shared activity does not announce the 'buddy-left' signal #10800

2011-05-20 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Apr 13 16:28:47 +0200 2011: This fixes a copy and paste error. A good test case is the Memorize activity since we listen for the 'buddy-left' signal there to update the members list inside the activity. Acked-By: Sascha Silbe si

Re: [Sugar-devel] [PATCH sugar-toolkit] remove obsolete comment

2011-05-20 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 28 16:52:57 +0200 2011: Thanks for the patch, please push only to master. Pushed as 3553fbd [1], thanks! Sascha [1] http://git.sugarlabs.org/sugar-toolkit/mainline/commit/3553fbd2f0c7c747d0b37a4bede2360f6282f740 -- http://sascha.silbe.org/

Re: [Sugar-devel] [PATCH 2/2] disabling become root button

2011-05-20 Thread Sascha Silbe
Excerpts from Rafael Ortiz's message of Thu May 19 18:52:59 +0200 2011: Temporaly Disabling become root button on terminal activity avoiding problems reported SL#2756 and #2597, also in merge request on gitorious CC'ing Gary and Walter to discuss the UI side of this. As discussed in both

Re: [Sugar-devel] [IAEP] copy files to/from server

2011-05-18 Thread Sascha Silbe
Excerpts from Martin Langhoff's message of Tue May 17 18:34:09 +0200 2011: Unfortuntely, there's no easy way to do it with CIFS or NFS -- it would be an interesting addition to Sugar (possibly to the Journal) but it's a big project. NFS mounts do turn up as storage devices in the Journal (at

Re: [Sugar-devel] Adjusting the activity loading screen

2011-05-03 Thread Sascha Silbe
Excerpts from Sridhar Dhanapalan's message of Tue May 03 07:23:34 +0200 2011: This problem looks like a bug, so I have filed a report: http://bugs.sugarlabs.org/ticket/2824 I have replied on (and closed) the ticket. Summary: Works as designed; using a standard protocol is planned (#2434) but

Re: [Sugar-devel] [PATCH sugar-toolkit] Handle DBUS tubes in the activity telepathy client, part of OLPC #10738

2011-04-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 14 19:43:05 +0200 2011: This adds the handling of DBUS tube channels to the 'HandlerChannelFilter' in activity's telepathy client. It would be nice to have some rationale for the change. Why didn't we do this before and in what way is the new

Re: [Sugar-devel] [PATCH sugar] Anly approve and not handle channels in the shell, part of OLPC #10738

2011-04-18 Thread Sascha Silbe
, }] (The content seems to be static, so it wouldn't make sense to log it.) The general approach looks fine. With or without the above changes, but after you got Samuels Tested-By: Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de

Re: [Sugar-devel] [PATCH sugar-toolkit] Fix invitations from a non sugar client (empathy), part of OLPC #10814

2011-04-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 14 19:43:20 +0200 2011: This differentiates between sugar and non sugar invitations using the handle type. For non-sugar invitations we use the activity id to determine which activity to join. How exactly does this work? Who creates the

Re: [Sugar-devel] dialog during installation?

2011-04-18 Thread Sascha Silbe
Excerpts from Erik Blankinship's message of Thu Apr 14 14:48:00 +0200 2011: Is there any way to present a modal dialog during the installation of a sugar activity? (For example: you will want to be on an xo to run this software with an option to cancel installation) No, there isn't.

Re: [Sugar-devel] [PATCH sugar] Fix invitations from a non sugar client (empathy), part of OLPC #10814

2011-04-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Apr 14 19:42:35 +0200 2011: [src/jarabe/model/invites.py] +class BaseInvite(object): +Invitation to shared activity or private 1-1 Telepathy channel +def __init__(self, dispatch_operation_path, handle, handler):

Re: [Sugar-devel] [PATCH sugar-toolkit] Only show joined buddies on sharer side, part of OLPC#10578

2011-04-18 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Fri Apr 15 23:08:40 +0200 2011: This is a follow-up patch to 95b4eeec758ffa729d0dbb219b21d428115fcc74 Reading the ticket you referenced, I gather this is a bug fix to make _both_ sides log all the buddies that were joined, not just the sharer side as

Re: [Sugar-devel] [PATCH sugar] Journal detail view copy-palette: fallback to more generic icon when needed, part of OLPC #10805

2011-04-11 Thread Sascha Silbe
the fallback code to make it more robust and display the icon. Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel

Re: [Sugar-devel] [PATCH sugar] Copy to external device: do not fail on custom binary metadata OLPC #10807

2011-04-11 Thread Sascha Silbe
maybe ask the activity authors to not use binary blobs for metadata, or base64 them before storing them in the metadata. More reasoning and background information in the ticket itself. I've followed up on the ticket. Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http

Re: [Sugar-devel] [PATCH sugar] Fix search on external device OLPC #10808

2011-04-11 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Mon Apr 04 17:54:51 +0200 2011: We passed the wrong ordering of arguments to _get_file_metadata, regression fix. Acked-by: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc

[Sugar-devel] [PATCH sugar-toolkit] remove obsolete comment

2011-04-11 Thread Sascha Silbe
GTK bug #502871 [1] has been fixed in 2007. [1] http://bugzilla.gnome.org/show_bug.cgi?id=502871 Signed-off-by: Sascha Silbe si...@activitycentral.com --- src/sugar/graphics/icon.py |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/sugar/graphics/icon.py b/src

Re: [Sugar-devel] [PATCH] revise timezone list, #2195

2011-04-03 Thread Sascha Silbe
Excerpts from James Cameron's message of Wed Mar 23 00:58:09 +0100 2011: Thanks for the patch! It's a good start, but unfortunately not enough. POSIX defines TZ as std offset dst offset, rule [1], ... No, according to [1] only the std offset form is required, the remaining fields are

Re: [Sugar-devel] [PATCH] The activity icon does not handle the case of a activity without metadata.

2011-04-03 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Thu Mar 31 17:21:19 +0200 2011: If the activity is initiated with create_object=False Acked-by: Sascha Silbe si...@activitycentral.com Pushed as 35cb4e3 [1] (master) and a883557 [2] (sucrose-0.92). Thanks for the patch! Sascha [1] http

Re: [Sugar-devel] icon search path

2011-04-02 Thread Sascha Silbe
Excerpts from Walter Bender's message of Sat Apr 02 18:24:05 +0200 2011: Is there a way to add to the path used to search for icons by name? From sugar.activity.main.main(): gtk.icon_theme_get_default().append_search_path(bundle.get_icons_path()) So something like: icon_theme =

Re: [Sugar-devel] [PATCH] Do startup animation of the activity icon using scaling and alpha - v2

2011-03-31 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Mon Mar 28 05:35:22 +0200 2011: Thanks for review this patch. I can't wait for faster startup in activities :) I attach a new patch and reply your comments here I accidentally pulled in the OLPC Sugar 0.92 packages into my Dextrose test images and

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-31 Thread Sascha Silbe
}, +dbus.Array([], 's'), dbus_interface=ACCOUNT) Similarly, all parameters fit on a single line. Acked-by: Sascha Silbe si...@activitycentral.com Thanks for the patch! Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature

Re: [Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 17:41:26 +0200 2011: Hmm, the default behavior is that the Invoker does cache the palette [1]. OK, good point. So as a pure bug fix, your current patch is more in line with the existing code. Therefore: Acked-by: Sascha Silbe si

Re: [Sugar-devel] [PATCH sugar] Fix inviting from friends view OLPC #10767

2011-03-31 Thread Sascha Silbe
Acked-By: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org

Re: [Sugar-devel] [PATCH sugar-toolkit] Store all the buddies that have been joined in the activity metadata OLPC #10578

2011-03-31 Thread Sascha Silbe
' dictionary keeps on tracking the users currently in the activity. Is this a regression from pre-0.90? If so, please mention that in the description. Acked-by: Sascha Silbe si...@activitycentral.com Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP

Re: [Sugar-devel] [PATCH] The activity icon does not handle the case of a activity without metadata.

2011-03-31 Thread Sascha Silbe
Excerpts from Gonzalo Odiard's message of Wed Mar 30 19:22:43 +0200 2011: +if metadata is not None and metadata.get('icon-color', ''): We can drop the second parameter of the get(). The default is None which will be evaluated as False, like the empty string did. Acked-by: Sascha Silbe si

Re: [Sugar-devel] [PATCH sugar-datastore 1/3] Add regression test for SL#2668

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:35:33 +0200 2011: In general: I wonder if we should add test suites for specific bugs, or if they should be just test the available API. Maybe a test that can be done by a human [1] is good enough for those bugs. The best way to

Re: [Sugar-devel] [PATCH sugar-datastore 3/3] don't destroy unchanged data store entries (SL#2668)

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:29:22 +0200 2011: This part of the patch looks good. I added a test case to [1] to make sure we can test it accordingly. [...] Acked-by: Simon Schampijer si...@laptop.org Thanks! Pushed as ad9244e [1]. Sascha [1]

Re: [Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 21:31:20 +0200 2011: On 03/05/2011 03:26 PM, Sascha Silbe wrote: We don't want anyone to be able to alter a file that is inside the data store, bypassing the API. What happens to the files that have been written prior to that patch

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 19:01:23 +0200 2011: +def __button_clicked_cb(self, button): +self.palette.popup(immediate=True, state=1) I guess this should use the Palette.SECONDARY constant instead of hard coding an integer value. FWIW, the way I did this

Re: [Sugar-devel] [PATCH sugar] Reveal the file transfer palette immediatly on left click #10796

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 21:28:17 +0200 2011: Good catch, done, anything else? The code looks good. My spell checker nags about immediatly in the subject and I'd prefer to have an OLPC prefix for the bug number since it's not an upstream ticket. Acked-by: Sascha

Re: [Sugar-devel] [PATCH sugar-datastore 2/3] Make sure data store checkouts are read-only

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 18:20:48 +0200 2011: Ok, that sounds tricky indeed. So go for it without the conversion. Thanks! Pushed as a7644fc [1] to master and sucrose-0.92. Sascha [1]

Re: [Sugar-devel] [PATCH sugar-datastore 1/3] Add regression test for SL#2668

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 31 18:16:00 +0200 2011: Ahh, I see - there is the plan for a full testsuite (aehm, unreviewed), go for it then. Thanks! I added your Ack to the patch, but will hold off on pushing it until after the test suite enters mainline. On that note,

Re: [Sugar-devel] [PATCH] adding support for Tuquito GNU/Linux distribution

2011-03-31 Thread Sascha Silbe
Excerpts from Alvar Maciel's message of Thu Mar 31 17:53:28 +0200 2011: From 50c37da039dc8baafccd925b6b3f034a4ffbaaa9 Mon Sep 17 00:00:00 2001 From: amaciel al...@tuquito.org.ar Date: Tue, 29 Mar 2011 15:10:53 -0300 Subject: [PATCH] Adding support for Tuquito GNU/Linux distribution [...]

Re: [Sugar-devel] [PATCH sugar] Construct the published name based on the public key OLPC #10737

2011-03-29 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 29 18:37:19 +0200 2011: Acked-by: Sascha Silbe si...@activitycentral.com If you care enough, some minor corrections would be: Limit the name to be only 8 characters maximum. The avahi service name has a 64 character limit. It consists

Re: [Sugar-devel] [PATCH sugar] ActivityListPalette: fix bundle_changed disconnection

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 16:18:20 +0100 2011: Acked-by: Simon Schampijer si...@laptop.org Thanks, pushed as 5b5ec61 [1]. Sascha [1] http://git.sugarlabs.org/sugar/mainline/commit/5b5ec6156bbba69a5a5f6e7caef19eaceb823c33 -- http://sascha.silbe.org/

Re: [Sugar-devel] [PATCH sugar-toolkit] fix regressions introduced by 29582de67f3189d232e170b1e07e9bf34233fb51

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 16:54:22 +0100 2011: Acked-by: Simon Schampijer si...@laptop.org Thanks, pushed with the requested change (PRIORITY_LOW) and a slightly improved description as 85e714e [1]. Sascha [1]

Re: [Sugar-devel] [PATCH sugar-toolkit] Avoid showing decorated windows during start-up (OLPC#10713)

2011-03-27 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 08 00:13:43 +0100 2011: I actually tried similar already as well. The issue can still be seen, it seem a bit less visible but I can still see it. Do you mean that even with my patch, you can still trigger this issue? If so, can you give a

Re: [Sugar-devel] Why cannot collections of ---.xo files on a USB stick be run without installation in sugar?

2011-03-27 Thread Sascha Silbe
Excerpts from James Cameron's message of Tue Mar 01 07:38:47 +0100 2011: Subject: [PATCH] sugar-install-bundle to accept multiple files Signed-off-by: James Cameron qu...@laptop.org Thanks, pushed as ada2844 [1]. +for line in fileinput.input(): Nice trick (I didn't know about the

Re: [Sugar-devel] [PATCH] Do startup animation of the activity icon using scaling and alpha - v2

2011-03-25 Thread Sascha Silbe
Excerpts from godiard's message of Wed Mar 23 19:40:47 +0100 2011: Thanks for your patch! I can't wait for an accelerated launcher screen. ;) This render the SVG image only one time, and then use alpha and scaling of the rendered icon and will speed up the overall activity startup. Any patch

Re: [Sugar-devel] [PATCH sugar] Cache the XO palette in the Home View, part of #2726

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 21:16:32 +0100 2011: The patch does cache the palette of the Owner, this has been the behavior before 356641c332d6cc889b265dfc29598004cf37763c. As registering (and therefore the change of the palette) happens rather seldom compared to the

Re: [Sugar-devel] [PATCH v4 sugar] Time out on registration process to prevent indefinite UI hang (SL#2289)

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 15:04:29 +0100 2011: PS: Filing bugs upstream will a) increase the chance they get fixed by someone else, b) avoid duplicate work by sharing test results and c) give both upstream and other downstreams a better overview of what's

Re: [Sugar-devel] [PATCH sugar] Limit the nick name to be only 8 characters maximum #10737

2011-03-25 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Tue Mar 22 22:49:53 +0100 2011: Avahi uses GetHostName (on the XO this is something like 'xo-a7-2e-70' based on the HW address). If GetHostName is based on gethostname(), then it is far from unique. Most distributions default to a constant name like

Re: [Sugar-devel] [PATCH v4 sugar] Time out on registration process to prevent indefinite UI hang (SL#2289)

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 21:05:56 +0100 2011: I lately see this error [1] when trying to connect to a schoolserver. Maybe you (or someone else) have an idea what the issue is. If I do construct the ServerProxy without the _TimeoutTransport the registration

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: What message is 300298237-10204-1-git-send-email-si...@schampijer.de? It never arrived here. And why did both Gonzalo and you make your (unrelated) patches a reply to it? This is really confusing. Please use

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 15:01:44 +0100 2011: http://lists.sugarlabs.org/archive/sugar-devel/2011-March/030439.html This is the message, so that looks right to me. Ah, looks like a copy paste error: Message-ID:

Re: [Sugar-devel] Git rep for the ad-hoc mayan icons?

2011-03-24 Thread Sascha Silbe
Excerpts from Gary Martin's message of Thu Mar 24 18:19:44 +0100 2011: http://git.sugarlabs.org/~garycmartin/sugar-artwork/garycmartins-emblem-clone Your clone seems to be out of date. Try: git remote add mainline git://git.sugarlabs.org/sugar-artwork/mainline.git git pull mainline

<    1   2   3   4   5   6   7   8   9   10   >